From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932190AbcEKPQV (ORCPT <rfc822;w@1wt.eu>);
	Wed, 11 May 2016 11:16:21 -0400
Received: from mail-wm0-f68.google.com ([74.125.82.68]:34223 "EHLO
	mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751741AbcEKPQU (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 11 May 2016 11:16:20 -0400
Date: Wed, 11 May 2016 17:16:15 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Yu-cheng Yu <yu-cheng.yu@intel.com>, linux-kernel@vger.kernel.org,
        x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@suse.de>,
        Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
        "Ravi V. Shankar" <ravi.v.shankar@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
Subject: Re: [PATCH v6 07/13] x86/xsaves: Fix PTRACE frames for XSAVES
Message-ID: <20160511151615.GA13006@gmail.com>
References: <cover.1462914897.git.yu-cheng.yu@intel.com>
 <33faa9b05447cd1b5bee02b1292249df7951b433.1462914897.git.yu-cheng.yu@intel.com>
 <573346D0.7040508@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <573346D0.7040508@linux.intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Dave Hansen <dave.hansen@linux.intel.com> wrote:

> On 05/10/2016 04:29 PM, Yu-cheng Yu wrote:
> > XSAVES uses compacted format and is a kernel instruction. The kernel
> > should use standard-format, non-supervisor state data for PTRACE.
> > 
> > Signed-off-by: Yu-cheng Yu <yu-cheng.yu@intel.com>
> 
> This looks fine.  There are a few comments that could use some sprucing
> up, like:
> 
> +	/*
> +	 * Reject if the user sets any forbidden features.
> +	 */
> 
> But it's minor stuff.
> 
> Reviewed-by: Dave Hansen <dave.hansen@intel.com>

Well it's too late for v4.7 due to intrusiveness, so please refine the series and 
also incorporate the cleanups requested by Boris. I can put it into -tip whenever 
you guys submit it, but it will have to wait for v4.8 most likely.

Thanks,

	Ingo