From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57517)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1b0UH9-000050-Fj
	for qemu-devel@nongnu.org; Wed, 11 May 2016 09:34:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1b0UH4-0002Vo-5Q
	for qemu-devel@nongnu.org; Wed, 11 May 2016 09:34:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50504)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1b0UH4-0002Vc-0M
	for qemu-devel@nongnu.org; Wed, 11 May 2016 09:34:02 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 799B38F01E
	for <qemu-devel@nongnu.org>; Wed, 11 May 2016 13:34:01 +0000 (UTC)
Date: Wed, 11 May 2016 15:33:58 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20160511153358.7c9d008e@nial.brq.redhat.com>
In-Reply-To: <20160510201935.GB4457@thinpad.lan.raisama.net>
References: <1462192431-146342-1-git-send-email-imammedo@redhat.com>
	<1462192431-146342-11-git-send-email-imammedo@redhat.com>
	<20160510201935.GB4457@thinpad.lan.raisama.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 10/42] pc: piix4/ich9: add
 'cpu-hotplug-legacy' property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com, marcel@redhat.com, eblake@redhat.com, armbru@redhat.com, drjones@redhat.com

On Tue, 10 May 2016 17:19:35 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:

> On Mon, May 02, 2016 at 02:33:19PM +0200, Igor Mammedov wrote:
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>  
> 
> As the property is useless if no code is reading
> s->pm.cpu_hotplug_legacy. What about squashing patches 10/42 and
> 12/42 together?
I've thought splitting trivial boiler plate code for adding property
would make it smaller/easier to review.
But I'm ok with squashing it into 12/42 if it makes review easier.