From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v4 1/8] virtio: hide phys addr check inside
	pci ops
Date: Wed, 11 May 2016 16:05:39 -0700
Message-ID: <20160511230539.GX5641@yliu-dev.sh.intel.com>
References: <1461892716-19122-1-git-send-email-jianfeng.tan@intel.com>
 <1461892716-19122-2-git-send-email-jianfeng.tan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Huawei Xie <huawei.xie@intel.com>,
 rich.lane@bigswitch.com, mst@redhat.com,
 nakajima.yoshihiro@lab.ntt.co.jp, p.fedin@samsung.com,
 michael.qiu@intel.com, ann.zhuangyanying@huawei.com,
 mukawa@igel.co.jp, nhorman@tuxdriver.com
To: Jianfeng Tan <jianfeng.tan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 2B04466DB
 for <dev@dpdk.org>; Thu, 12 May 2016 01:01:08 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1461892716-19122-2-git-send-email-jianfeng.tan@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Apr 29, 2016 at 01:18:29AM +0000, Jianfeng Tan wrote:
> This patch is to move phys addr check from virtio_dev_queue_setup
> to pci ops. To makt that happen, make sure virtio_ops.setup_queue
> return the result if we pass through the check.
> 
> Signed-off-by: Huawei Xie <huawei.xie@intel.com>
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> Acked-By: Neil Horman <nhorman@tuxdriver.com>

This patch doesn't even exist in your old versions; it doesn't make
sense to carry the Ack here.

Besides that, this patch looks good to me:

Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

	--yliu