From: Mark Brown <broonie@kernel.org>
To: John Hsu <KCHSU0@nuvoton.com>
Cc: AP MS30 Linux ALSA <alsa-devel@alsa-project.org>,
"anatol.pomozov@gmail.com" <anatol.pomozov@gmail.com>,
AC30 YHChuang <YHCHuang@nuvoton.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"benzh@chromium.org" <benzh@chromium.org>,
AC30 CTLin0 <CTLIN0@nuvoton.com>, MS40 MHKuo <MHKuo@nuvoton.com>,
"yong.zhi@intel.com" <yong.zhi@intel.com>
Subject: Re: [PATCH 1/2] ASoC: nau8825: non-clock jack detection for power saving at standby
Date: Thu, 12 May 2016 11:58:33 +0100 [thread overview]
Message-ID: <20160512105833.GB6261@sirena.org.uk> (raw)
In-Reply-To: <5733FE8E.1040104@nuvoton.com>
[-- Attachment #1.1: Type: text/plain, Size: 1161 bytes --]
On Thu, May 12, 2016 at 11:54:54AM +0800, John Hsu wrote:
> On 5/12/2016 1:15 AM, Mark Brown wrote:
> > I'm afraid this still leaves me none the wiser, sorry. If this
> > switching to the internal clock is essential to the device operation
> > then I'd expect it to be made transparent to callers so it should
> > happen transparently rather than appearing via set_sysclk(). If it's
> > not and it's just a performance optimisation then erroring out is
> > definitely excessive but if the optimisation can be implemented
> > transparently then it might be nice to do that.
> In the driver patch, the internal clock switching is transparently
> done by driver when the codec runs advanced jack detection. Our
> purpose is to prevent the machine turns on the internal clock by
> itself when no headset connected. That will not affect function
> work but make more power consumption. Maybe we can change to clock
> disabled quietly when the machine turns on the internal clock when
> no headset connected. Is it the right way?
Yes, that seems good. Printing a warning is also fine because it does
increase power consumption but erroring out seems excessive.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2016-05-12 10:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 8:15 [PATCH 1/2] ASoC: nau8825: non-clock jack detection for power saving at standby John Hsu
2016-04-29 8:15 ` [PATCH 2/2] ASoC: nau8825: cross talk suppression measurement function John Hsu
2016-05-02 16:27 ` [PATCH 1/2] ASoC: nau8825: non-clock jack detection for power saving at standby Mark Brown
2016-05-03 9:20 ` John Hsu
2016-05-04 16:39 ` Mark Brown
2016-05-06 7:41 ` John Hsu
2016-05-06 18:18 ` Mark Brown
2016-05-09 2:57 ` John Hsu
2016-05-09 16:35 ` Mark Brown
2016-05-10 3:18 ` John Hsu
2016-05-11 17:15 ` Mark Brown
2016-05-12 3:54 ` John Hsu
2016-05-12 10:58 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512105833.GB6261@sirena.org.uk \
--to=broonie@kernel.org \
--cc=CTLIN0@nuvoton.com \
--cc=KCHSU0@nuvoton.com \
--cc=MHKuo@nuvoton.com \
--cc=YHCHuang@nuvoton.com \
--cc=alsa-devel@alsa-project.org \
--cc=anatol.pomozov@gmail.com \
--cc=benzh@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.