From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752799AbcELNJb (ORCPT ); Thu, 12 May 2016 09:09:31 -0400 Received: from mail.kernel.org ([198.145.29.136]:39994 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751806AbcELNJa (ORCPT ); Thu, 12 May 2016 09:09:30 -0400 Date: Thu, 12 May 2016 10:09:25 -0300 From: Arnaldo Carvalho de Melo To: David Ahern Cc: He Kuang , peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/7] perf tools: Remove the logical that skip buildid cache if symfs is given Message-ID: <20160512130925.GG20258@kernel.org> References: <1463042596-61703-1-git-send-email-hekuang@huawei.com> <1463042596-61703-4-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463042596-61703-4-git-send-email-hekuang@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, May 12, 2016 at 08:43:12AM +0000, He Kuang escreveu: > Symfs dir and buildid dir are two places that perf looks into for > symbols, currently, if symfs dir is given, buildid-cache is skipped. > > In the cross-platform perf record/script scenario, we need vdsos in > buildid-cache dir and other libs in symfs dir at the same time. And > consider that the binaries indexed by buildid do not cause ambiguity, > this patch simply removes that logical. Makes perfect sense, David, do you have any concern? Can I have your Acked-by? - Arnaldo > Signed-off-by: He Kuang > --- > tools/perf/util/dso.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c > index b39b80c..a07166c5 100644 > --- a/tools/perf/util/dso.c > +++ b/tools/perf/util/dso.c > @@ -64,8 +64,7 @@ int dso__read_binary_type_filename(const struct dso *dso, > break; > case DSO_BINARY_TYPE__BUILD_ID_CACHE: > /* skip the locally configured cache if a symfs is given */ > - if (symbol_conf.symfs[0] || > - (dso__build_id_filename(dso, filename, size) == NULL)) > + if (dso__build_id_filename(dso, filename, size) == NULL) > ret = -1; > break; > > -- > 1.8.5.2