From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752723AbcEMLRu (ORCPT ); Fri, 13 May 2016 07:17:50 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:50658 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751741AbcEMLRs (ORCPT ); Fri, 13 May 2016 07:17:48 -0400 Date: Fri, 13 May 2016 12:17:27 +0100 From: Mark Brown To: Lu Baolu Cc: felipe.balbi@linux.intel.com, Mathias Nyman , Greg Kroah-Hartman , Lee Jones , Heikki Krogerus , Liam Girdwood , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20160513111727.GD22038@sirena.org.uk> References: <1462426383-3949-1-git-send-email-baolu.lu@linux.intel.com> <1462426383-3949-2-git-send-email-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wLAMOaPNJ0fu1fTG" Content-Disposition: inline In-Reply-To: <1462426383-3949-2-git-send-email-baolu.lu@linux.intel.com> X-Cookie: Whistler's mother is off her rocker. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 188.29.165.172 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v8 1/7] regulator: fixed: add support for ACPI interface X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --wLAMOaPNJ0fu1fTG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 05, 2016 at 01:32:57PM +0800, Lu Baolu wrote: > + gpiod = gpiod_get(dev, "gpio", GPIOD_ASIS); > + if (IS_ERR(gpiod)) > + return ERR_PTR(-ENODEV); > + config->gpio = desc_to_gpio(gpiod); > + config->enable_high = device_property_read_bool(dev, > + "enable-active-high"); > + gpiod_put(gpiod); This isn't going to work at all if the GPIO is shared between multiple regulators but I can't immediately see a sensible way to fix that without some surgery on the GPIO APIs so let's leave it for now. --wLAMOaPNJ0fu1fTG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXNbfDAAoJECTWi3JdVIfQ29MIAIW0BmKxP+f2SRZxsVj3ZZb0 Z/Iij4i7XkhXs2xE5YBwx1FS/Z3VXn9QFLos4I6D5iSze1mHl+IdY+RRh1MfIlOZ yNONxyFf87/LKLu8jqWRNTDJijpGQxQ2AJeSWNT/fkneS9oLgaubjWE/DuuRZcMq B9PVf4AblJTEzpRErUodUBlQw5YG+jlxbxHfyaKiD7MSxDf1LUL1+svsTDR/4NWm sS8rQshByQCEbndm77kmWj0bzidxzlbd8A+vobZ/K6leRrt+UlYXAn6uJr154pOX Cfs8bz8NYp5gtny9TebugxIPAwzyvwIV5kilfU2G2ciiSOxHQHAe+9KjK4Ed/EE= =6d+g -----END PGP SIGNATURE----- --wLAMOaPNJ0fu1fTG--