From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753521AbcEPJcX (ORCPT ); Mon, 16 May 2016 05:32:23 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:34848 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752724AbcEPJcU (ORCPT ); Mon, 16 May 2016 05:32:20 -0400 Date: Mon, 16 May 2016 17:23:23 +0800 From: Peter Chen To: Roger Quadros Cc: peter.chen@freescale.com, balbi@kernel.org, tony@atomide.com, gregkh@linuxfoundation.org, dan.j.williams@intel.com, mathias.nyman@linux.intel.com, Joao.Pinto@synopsys.com, sergei.shtylyov@cogentembedded.com, jun.li@freescale.com, grygorii.strashko@ti.com, yoshihiro.shimoda.uh@renesas.com, robh@kernel.org, nsekhar@ti.com, b-liu@ti.com, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v8 13/14] usb: gadget: udc: adapt to OTG core Message-ID: <20160516092323.GD24609@shlinux2.ap.freescale.net> References: <1463133808-10630-1-git-send-email-rogerq@ti.com> <1463133808-10630-14-git-send-email-rogerq@ti.com> <20160516070249.GB24609@shlinux2.ap.freescale.net> <57398451.2060103@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57398451.2060103@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 16, 2016 at 11:26:57AM +0300, Roger Quadros wrote: > Hi, > > On 16/05/16 10:02, Peter Chen wrote: > > On Fri, May 13, 2016 at 01:03:27PM +0300, Roger Quadros wrote: > >> + > >> +static int usb_gadget_connect_control(struct usb_gadget *gadget, bool connect) > >> +{ > >> + struct usb_udc *udc; > >> + > >> + mutex_lock(&udc_lock); > >> + udc = usb_gadget_to_udc(gadget); > >> + if (!udc) { > >> + dev_err(gadget->dev.parent, "%s: gadget not registered.\n", > >> + __func__); > >> + mutex_unlock(&udc_lock); > >> + return -EINVAL; > >> + } > >> + > >> + if (connect) { > >> + if (!gadget->connected) > >> + usb_gadget_connect(udc->gadget); > >> + } else { > >> + if (gadget->connected) { > >> + usb_gadget_disconnect(udc->gadget); > >> + udc->driver->disconnect(udc->gadget); > >> + } > >> + } > >> + > >> + mutex_unlock(&udc_lock); > >> + > >> + return 0; > >> +} > >> + > > > > Since this is called for vbus interrupt, why not using > > usb_udc_vbus_handler directly, and call udc->driver->disconnect > > at usb_gadget_stop. > > We can't assume that this is always called for vbus interrupt so > I decided not to call usb_udc_vbus_handler. > > udc->vbus is really pointless for us. We keep vbus states in our > state machine and leave udc->vbus as ture always. > > Why do you want to move udc->driver->disconnect() to stop? > If USB controller disconnected from bus then the gadget driver > must be notified about the disconnect immediately. The controller > may or may not be stopped by the core. > Then, would you give some comments when this API will be used? I was assumed it is only used for drd state machine. > > > >> return 0; > >> @@ -660,9 +830,15 @@ static ssize_t usb_udc_softconn_store(struct device *dev, > >> return -EOPNOTSUPP; > >> } > >> > >> + /* In OTG mode we don't support softconnect, but b_bus_req */ > >> + if (udc->gadget->otg_dev) { > >> + dev_err(dev, "soft-connect not supported in OTG mode\n"); > >> + return -EOPNOTSUPP; > >> + } > >> + > > > > The soft-connect can be supported at dual-role mode currently, we can > > use b_bus_req entry once it is implemented later. > > Soft-connect should be done via sysfs handling within the OTG core. > This can be added later. I don't want anything outside the OTG core > to handle soft-connect behaviour as it will be hard to keep things > in sync. > > I can update the comment to something like this. > > /* In OTG/dual-role mode, soft-connect should be handled by OTG core */ Ok, let's Felipe decide it. > > > > >> if (sysfs_streq(buf, "connect")) { > >> usb_gadget_udc_start(udc); > >> - usb_gadget_connect(udc->gadget); > >> + usb_udc_connect_control(udc); > > > > This line seems to be not related with this patch. > > > Right. I'll remove it. > > cheers, > -roger -- Best Regards, Peter Chen From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Chen Subject: Re: [PATCH v8 13/14] usb: gadget: udc: adapt to OTG core Date: Mon, 16 May 2016 17:23:23 +0800 Message-ID: <20160516092323.GD24609@shlinux2.ap.freescale.net> References: <1463133808-10630-1-git-send-email-rogerq@ti.com> <1463133808-10630-14-git-send-email-rogerq@ti.com> <20160516070249.GB24609@shlinux2.ap.freescale.net> <57398451.2060103@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <57398451.2060103-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Roger Quadros Cc: peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org, balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, mathias.nyman-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, Joao.Pinto-HKixBCOQz3hWk0Htik3J/w@public.gmane.org, sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org, jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org, grygorii.strashko-l0cyMroinI0@public.gmane.org, yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org, robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org, b-liu-l0cyMroinI0@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, May 16, 2016 at 11:26:57AM +0300, Roger Quadros wrote: > Hi, > > On 16/05/16 10:02, Peter Chen wrote: > > On Fri, May 13, 2016 at 01:03:27PM +0300, Roger Quadros wrote: > >> + > >> +static int usb_gadget_connect_control(struct usb_gadget *gadget, bool connect) > >> +{ > >> + struct usb_udc *udc; > >> + > >> + mutex_lock(&udc_lock); > >> + udc = usb_gadget_to_udc(gadget); > >> + if (!udc) { > >> + dev_err(gadget->dev.parent, "%s: gadget not registered.\n", > >> + __func__); > >> + mutex_unlock(&udc_lock); > >> + return -EINVAL; > >> + } > >> + > >> + if (connect) { > >> + if (!gadget->connected) > >> + usb_gadget_connect(udc->gadget); > >> + } else { > >> + if (gadget->connected) { > >> + usb_gadget_disconnect(udc->gadget); > >> + udc->driver->disconnect(udc->gadget); > >> + } > >> + } > >> + > >> + mutex_unlock(&udc_lock); > >> + > >> + return 0; > >> +} > >> + > > > > Since this is called for vbus interrupt, why not using > > usb_udc_vbus_handler directly, and call udc->driver->disconnect > > at usb_gadget_stop. > > We can't assume that this is always called for vbus interrupt so > I decided not to call usb_udc_vbus_handler. > > udc->vbus is really pointless for us. We keep vbus states in our > state machine and leave udc->vbus as ture always. > > Why do you want to move udc->driver->disconnect() to stop? > If USB controller disconnected from bus then the gadget driver > must be notified about the disconnect immediately. The controller > may or may not be stopped by the core. > Then, would you give some comments when this API will be used? I was assumed it is only used for drd state machine. > > > >> return 0; > >> @@ -660,9 +830,15 @@ static ssize_t usb_udc_softconn_store(struct device *dev, > >> return -EOPNOTSUPP; > >> } > >> > >> + /* In OTG mode we don't support softconnect, but b_bus_req */ > >> + if (udc->gadget->otg_dev) { > >> + dev_err(dev, "soft-connect not supported in OTG mode\n"); > >> + return -EOPNOTSUPP; > >> + } > >> + > > > > The soft-connect can be supported at dual-role mode currently, we can > > use b_bus_req entry once it is implemented later. > > Soft-connect should be done via sysfs handling within the OTG core. > This can be added later. I don't want anything outside the OTG core > to handle soft-connect behaviour as it will be hard to keep things > in sync. > > I can update the comment to something like this. > > /* In OTG/dual-role mode, soft-connect should be handled by OTG core */ Ok, let's Felipe decide it. > > > > >> if (sysfs_streq(buf, "connect")) { > >> usb_gadget_udc_start(udc); > >> - usb_gadget_connect(udc->gadget); > >> + usb_udc_connect_control(udc); > > > > This line seems to be not related with this patch. > > > Right. I'll remove it. > > cheers, > -roger -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html