From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46615)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcmvbkbc@gmail.com>) id 1b2JkL-00075i-OK
	for qemu-devel@nongnu.org; Mon, 16 May 2016 10:43:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcmvbkbc@gmail.com>) id 1b2JkH-00043L-Gq
	for qemu-devel@nongnu.org; Mon, 16 May 2016 10:43:48 -0400
Received: from mail-lf0-x229.google.com ([2a00:1450:4010:c07::229]:34747)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcmvbkbc@gmail.com>) id 1b2JkH-00043B-8p
	for qemu-devel@nongnu.org; Mon, 16 May 2016 10:43:45 -0400
Received: by mail-lf0-x229.google.com with SMTP id m64so117457305lfd.1
	for <qemu-devel@nongnu.org>; Mon, 16 May 2016 07:43:45 -0700 (PDT)
Date: Mon, 16 May 2016 17:43:35 +0300
From: Max Filippov <jcmvbkbc@gmail.com>
Message-ID: <20160516144335.GA31697@octofox.metropolis>
References: <1463404380-29302-1-git-send-email-sergey.fedorov@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1463404380-29302-1-git-send-email-sergey.fedorov@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] cpu-exec: Fix direct jump to TB spanning
 page
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sergey Fedorov <sergey.fedorov@linaro.org>
Cc: qemu-devel@nongnu.org, Peter Crosthwaite <crosthwaite.peter@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Sergey Fedorov <serge.fdrv@gmail.com>, Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>, Richard Henderson <rth@twiddle.net>

On Mon, May 16, 2016 at 04:13:00PM +0300, Sergey Fedorov wrote:
> From: Sergey Fedorov <serge.fdrv@gmail.com>
> 
> It is not safe to make a direct jump to a TB spanning two pages in
> system emulation because the mapping for the second page can get changed
> but we don't take care of direct jumps in this case.
> 
> However in user mode emulation, this is not the case because there's
> only static address translation and TBs are always invalidated properly.
> 
> Fixes: 5b053a4a2827 ("tcg: Clean up direct block chaining safety checks")
> 
> Reported-by: Max Filippov <jcmvbkbc@gmail.com>
> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
> Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>
> ---
>  cpu-exec.c | 9 +++++++++
>  1 file changed, 9 insertions(+)

Tested-by: Max Filippov <jcmvbkbc@gmail.com>

-- 
Thanks.
-- Max