From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932293AbcEQGAr (ORCPT ); Tue, 17 May 2016 02:00:47 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:36979 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753814AbcEQGAp (ORCPT ); Tue, 17 May 2016 02:00:45 -0400 Date: Tue, 17 May 2016 07:00:59 +0100 From: Lee Jones To: Julia Lawall Cc: SF Markus Elfring , Tony Lindgren , linux-omap@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org Subject: Re: mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbered_child() Message-ID: <20160517060059.GB17238@dell> References: <566ABCD9.1060404@users.sourceforge.net> <5682D228.7070902@users.sourceforge.net> <20160111082922.GB14104@x1> <05b7db2a-437a-60ac-d289-71d2150e7f5f@users.sourceforge.net> <3c168185-ec2d-f1f7-fe70-8a230b884ed2@users.sourceforge.net> <9f94708f-6433-5227-78ee-52fbfb30fdaf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 May 2016, Julia Lawall wrote: > On Mon, 16 May 2016, SF Markus Elfring wrote: > > > >> * Change an error message. > > > > > > Why? Is dev_err needed? > > > > I interpreted Lee's response in this way. > > https://lkml.org/lkml/2016/1/11/104 > > OK. He didn't ask for the message to be changed though. It's a bit > unfortunate that it now takes up multiple lines. And I believe it also > prints redundant information. Perhaps he will have some further thoughts > on the matter. Yes, Julia is right. We normally don't print anything for OOM errors since Linux reports on them already. Please remove the print altogether. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Tue, 17 May 2016 06:00:59 +0000 Subject: Re: mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbered_child() Message-Id: <20160517060059.GB17238@dell> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <5682D228.7070902@users.sourceforge.net> <20160111082922.GB14104@x1> <05b7db2a-437a-60ac-d289-71d2150e7f5f@users.sourceforge.net> <3c168185-ec2d-f1f7-fe70-8a230b884ed2@users.sourceforge.net> <9f94708f-6433-5227-78ee-52fbfb30fdaf@users.sourceforge.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: Julia Lawall Cc: SF Markus Elfring , Tony Lindgren , linux-omap@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org On Mon, 16 May 2016, Julia Lawall wrote: > On Mon, 16 May 2016, SF Markus Elfring wrote: >=20 > > >> * Change an error message. > > >=20 > > > Why? Is dev_err needed? > >=20 > > I interpreted Lee's response in this way. > > https://lkml.org/lkml/2016/1/11/104 >=20 > OK. He didn't ask for the message to be changed though. It's a bit=20 > unfortunate that it now takes up multiple lines. And I believe it also=20 > prints redundant information. Perhaps he will have some further thoughts= =20 > on the matter. Yes, Julia is right. We normally don't print anything for OOM errors since Linux reports on them already. Please remove the print altogether. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html