From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752366AbcEQLPy (ORCPT <rfc822;w@1wt.eu>);
	Tue, 17 May 2016 07:15:54 -0400
Received: from merlin.infradead.org ([205.233.59.134]:36871 "EHLO
	merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751204AbcEQLPx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 17 May 2016 07:15:53 -0400
Date: Tue, 17 May 2016 13:15:38 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Michael Neuling <mikey@neuling.org>,
        Matt Fleming <matt@codeblueprint.co.uk>, mingo@kernel.org,
        linux-kernel@vger.kernel.org, clm@fb.com, mgalbraith@suse.de,
        tglx@linutronix.de, fweisbec@gmail.com, anton@samba.org,
        oliver <oohall@gmail.com>,
        "Shreyas B. Prabhu" <shreyas@linux.vnet.ibm.com>
Subject: Re: [RFC][PATCH 4/7] sched: Replace sd_busy/nr_busy_cpus with
 sched_domain_shared
Message-ID: <20160517111538.GX3193@twins.programming.kicks-ass.net>
References: <20160511123345.GD3192@twins.programming.kicks-ass.net>
 <20160511182402.GD3205@twins.programming.kicks-ass.net>
 <1463018737.28449.38.camel@neuling.org>
 <20160512050750.GK3192@twins.programming.kicks-ass.net>
 <1463051272.28449.59.camel@neuling.org>
 <20160512113359.GO3192@twins.programming.kicks-ass.net>
 <1463098346.25753.15.camel@neuling.org>
 <20160516140032.GQ3193@twins.programming.kicks-ass.net>
 <20160517102007.GI3205@twins.programming.kicks-ass.net>
 <20160517105204.GA9986@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160517105204.GA9986@linux.vnet.ibm.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 17, 2016 at 04:22:04PM +0530, Srikar Dronamraju wrote:
> > 
> > Maybe even something like so; which would make Power <= 6 use the
> > default topology and result in a shared LLC between the on package cores
> > etc..
> > 
> > Power7 is then special for not having a shared L3 but having the
> > asymmetric SMT thing and Power8 again gains the shared L3 while
> > retaining the asymmetric SMT stuff.
> 
> 
> Asymmetric SMT is only for Power 7. Its not enabled for Power 8.
> On Power8, if there are only 2 active threads assume thread 0 and thread
> 4 running in smt 8 mode, it would internally run as if running in smt 2
> mode without any scheduler tweaks. (This is unlike power 7).

Ah, good to know. In that case, you can use the generic topology for
everything except power7. IOW, just make that existing
set_sched_topology() call depend on CPU_FTRS_POWER7 or so (if that is
the correct magic incantation).