From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752881AbcERLwN (ORCPT ); Wed, 18 May 2016 07:52:13 -0400 Received: from smtprelay0147.hostedemail.com ([216.40.44.147]:42217 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751899AbcERLwL (ORCPT ); Wed, 18 May 2016 07:52:11 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:1981:2194:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:3873:3874:4250:5007:6120:6261:7875:7901:10004:10400:10848:10967:11232:11658:11914:12517:12519:12663:12740:13069:13161:13229:13311:13357:13439:14096:14097:14181:14659:14721:21080:21433,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: nerve98_2fb28605c6729 X-Filterd-Recvd-Size: 2048 Date: Wed, 18 May 2016 07:52:06 -0400 From: Steven Rostedt To: Jason Wang Cc: Jesper Dangaard Brouer , Eric Dumazet , davem@davemloft.net, mst@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra Subject: Re: [PATCH net-next] tuntap: introduce tx skb ring Message-ID: <20160518075206.0ca4c500@grimm.local.home> In-Reply-To: <573C42B4.6040708@redhat.com> References: <1463361421-4397-1-git-send-email-jasowang@redhat.com> <1463370998.18194.74.camel@edumazet-glaptop3.roam.corp.google.com> <57397C14.1080701@redhat.com> <20160518101359.37f5343b@redhat.com> <573C42B4.6040708@redhat.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 May 2016 18:23:48 +0800 Jason Wang wrote: > > > > > > > Maybe Steven Rostedt have an even better ring queue implementation > > already avail in the kernel? > > > > You mean ring buffer in tracing? Not sure, but it looks rather complex > at first glance. Yes it is, and I'm not sure it would be appropriate here or not. The tracing ring buffer is highly tuned to be lockless and per cpu (allocates a buffer per cpu), it also does not need to disable interrupts and can be used in NMI context. The complexity comes from being able to locklessly swap out pages from the ring buffer to send across the network or to disk while a record is happening. Perf has a simpler ring buffer made for mmapping, but it's still rather coupled with the perf core. It would be nice to make that ring buffer a bit more generic and not so tied to perf itself. -- Steve