From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: brouer@redhat.com, "Michael S. Tsirkin" <mst@redhat.com>,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] tuntap: introduce tx skb ring
Date: Wed, 18 May 2016 10:16:31 +0200 [thread overview]
Message-ID: <20160518101631.368e3447@redhat.com> (raw)
In-Reply-To: <573A761D.8080909@redhat.com>
On Tue, 17 May 2016 09:38:37 +0800 Jason Wang <jasowang@redhat.com> wrote:
> >> And if tx_queue_length is not power of 2,
> >> we probably need modulus to calculate the capacity.
> > Is that really that important for speed?
>
> Not sure, I can test.
In my experience, yes, adding a modulus does affect performance.
> > If yes, round it up to next power of two.
>
> Right, this sounds a good solution.
Good idea.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2016-05-18 8:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 1:17 [PATCH net-next] tuntap: introduce tx skb ring Jason Wang
2016-05-16 3:56 ` Eric Dumazet
2016-05-16 7:51 ` Jason Wang
2016-05-18 8:13 ` Jesper Dangaard Brouer
2016-05-18 8:23 ` Michael S. Tsirkin
2016-05-18 10:23 ` Jason Wang
2016-05-18 11:52 ` Steven Rostedt
2016-05-18 16:26 ` Michael S. Tsirkin
2016-05-18 16:41 ` Eric Dumazet
2016-05-18 16:46 ` Michael S. Tsirkin
2016-05-19 11:59 ` Jesper Dangaard Brouer
2016-05-16 4:23 ` Michael S. Tsirkin
2016-05-16 7:52 ` Jason Wang
2016-05-16 8:08 ` Michael S. Tsirkin
2016-05-17 1:38 ` Jason Wang
2016-05-18 8:16 ` Jesper Dangaard Brouer [this message]
2016-05-18 8:21 ` Michael S. Tsirkin
2016-05-18 9:21 ` Jesper Dangaard Brouer
2016-05-18 9:55 ` Michael S. Tsirkin
2016-05-18 10:42 ` Jason Wang
2016-05-18 10:58 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160518101631.368e3447@redhat.com \
--to=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.