From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CEECA1A1DFD for ; Fri, 20 May 2016 00:30:11 -0700 (PDT) Date: Fri, 20 May 2016 09:29:57 +0200 From: Johannes Thumshirn Subject: Re: [PATCH v3 1/5] libnvdimm: stop requiring a driver ->remove() method Message-ID: <20160520072957.GA4413@c203.arch.suse.de> References: <146360496572.37439.6497663679891935585.stgit@dwillia2-desk3.amr.corp.intel.com> <146360497107.37439.10316060945952347673.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <146360497107.37439.10316060945952347673.stgit@dwillia2-desk3.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: linux-block@vger.kernel.org, hch@lst.de, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org List-ID: On Wed, May 18, 2016 at 01:56:11PM -0700, Dan Williams wrote: > The dax_pmem driver was implementing an empty ->remove() method to > satisfy the nvdimm bus driver that unconditionally calls ->remove(). > Teach the core bus driver to check if ->remove() is NULL to remove that > requirement. > = > Reported-by: Johannes Thumshirn > Signed-off-by: Dan Williams Looks good, Reviewed-by: Johannes Thumshirn -- = Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton HRB 21284 (AG N=FCrnberg) Key fingerprint =3D EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:48106 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754586AbcETHaF (ORCPT ); Fri, 20 May 2016 03:30:05 -0400 Date: Fri, 20 May 2016 09:29:57 +0200 From: Johannes Thumshirn To: Dan Williams Cc: linux-nvdimm@lists.01.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, hch@lst.de Subject: Re: [PATCH v3 1/5] libnvdimm: stop requiring a driver ->remove() method Message-ID: <20160520072957.GA4413@c203.arch.suse.de> References: <146360496572.37439.6497663679891935585.stgit@dwillia2-desk3.amr.corp.intel.com> <146360497107.37439.10316060945952347673.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: <146360497107.37439.10316060945952347673.stgit@dwillia2-desk3.amr.corp.intel.com> Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On Wed, May 18, 2016 at 01:56:11PM -0700, Dan Williams wrote: > The dax_pmem driver was implementing an empty ->remove() method to > satisfy the nvdimm bus driver that unconditionally calls ->remove(). > Teach the core bus driver to check if ->remove() is NULL to remove that > requirement. > > Reported-by: Johannes Thumshirn > Signed-off-by: Dan Williams Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg GF: Felix Imend�rffer, Jane Smithard, Graham Norton HRB 21284 (AG N�rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755428AbcETHaH (ORCPT ); Fri, 20 May 2016 03:30:07 -0400 Received: from mx2.suse.de ([195.135.220.15]:48106 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754586AbcETHaF (ORCPT ); Fri, 20 May 2016 03:30:05 -0400 Date: Fri, 20 May 2016 09:29:57 +0200 From: Johannes Thumshirn To: Dan Williams Cc: linux-nvdimm@ml01.01.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, hch@lst.de Subject: Re: [PATCH v3 1/5] libnvdimm: stop requiring a driver ->remove() method Message-ID: <20160520072957.GA4413@c203.arch.suse.de> References: <146360496572.37439.6497663679891935585.stgit@dwillia2-desk3.amr.corp.intel.com> <146360497107.37439.10316060945952347673.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <146360497107.37439.10316060945952347673.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 18, 2016 at 01:56:11PM -0700, Dan Williams wrote: > The dax_pmem driver was implementing an empty ->remove() method to > satisfy the nvdimm bus driver that unconditionally calls ->remove(). > Teach the core bus driver to check if ->remove() is NULL to remove that > requirement. > > Reported-by: Johannes Thumshirn > Signed-off-by: Dan Williams Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850