From: Chris Wilson <chris@chris-wilson.co.uk>
To: Dave Gordon <david.s.gordon@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v4 4/4] Try inlining sg_next()
Date: Fri, 20 May 2016 08:35:33 +0100 [thread overview]
Message-ID: <20160520073533.GA23871@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <1463704290-3491-4-git-send-email-david.s.gordon@intel.com>
On Fri, May 20, 2016 at 01:31:30AM +0100, Dave Gordon wrote:
> Signed-off-by: Dave Gordon <david.s.gordon@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
Much better. The effect of the inline
gem:exec:fault:1MiB: +4.90%
gem:exec:fault:1MiB:forked: +7.99%
gem:exec:fault:16MiB: +22.94%
gem:exec:fault:16MiB:forked: +19.96%
gem:exec:fault:256MiB: +27.45%
gem:exec:fault:256MiB:forked: +36.89%
And it brings this series into parity with mine.
----
Avoiding the out-of-line call to sg_next() reduces the kernel execution
overhead by 10% in some workloads (for example the Unreal Engine 4 demo
Atlantis on 2GiB GTTs) which are dominated by the cost of inserting PTEs
due to texture thrashing. We can demonstrate this in a microbenchmark
that forces us to rebind the object on every execbuf, where we can
measure a 25% improvement, in the time required to execute an execbuf
requiring a texture to be rebound, for inlining the sg_next() for large
texture sizes.
Benchmark: igt/benchmarks/gem_exec_fault
Benchmark: igt/benchmarks/gem_exec_trace/Atlantis
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-05-20 7:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 0:31 [PATCH v4 1/4] drm/i915: refactor i915_gem_object_pin_map() Dave Gordon
2016-05-20 0:31 ` [PATCH v4 2/4] drm/i915: optimise i915_gem_object_map() for small objects Dave Gordon
2016-05-20 0:31 ` [PATCH v4 3/4] Introduce & use new lightweight SGL iterators Dave Gordon
2016-05-20 8:15 ` Chris Wilson
2016-05-20 9:56 ` Chris Wilson
2016-05-20 0:31 ` [PATCH v4 4/4] Try inlining sg_next() Dave Gordon
2016-05-20 7:35 ` Chris Wilson [this message]
2016-05-20 9:18 ` ✗ Ro.CI.BAT: failure for series starting with [v4,1/4] drm/i915: refactor i915_gem_object_pin_map() Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160520073533.GA23871@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=david.s.gordon@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.