From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH v4 3/4] Introduce & use new lightweight SGL
	iterators
Date: Fri, 20 May 2016 09:15:06 +0100
Message-ID: <20160520081506.GF3590@nuc-i3427.alporthouse.com>
References: <1463704290-3491-1-git-send-email-david.s.gordon@intel.com>
 <1463704290-3491-3-git-send-email-david.s.gordon@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118])
 by gabe.freedesktop.org (Postfix) with ESMTP id BDCAD6E2B3
 for <intel-gfx@lists.freedesktop.org>; Fri, 20 May 2016 08:15:09 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <1463704290-3491-3-git-send-email-david.s.gordon@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Dave Gordon <david.s.gordon@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBNYXkgMjAsIDIwMTYgYXQgMDE6MzE6MjlBTSArMDEwMCwgRGF2ZSBHb3Jkb24gd3Jv
dGU6Cj4gVGhlIGV4aXN0aW5nIGZvcl9lYWNoX3NnX3BhZ2UoKSBpdGVyYXRvciBpcyBzb21ld2hh
dCBoZWF2eXdlaWdodCwgYW5kIGlzCj4gbGltaXRpbmcgaTkxNSBkcml2ZXIgcGVyZm9ybWFuY2Ug
aW4gYSBmZXcgYmVuY2htYXJrcy4gU28gaGVyZSB3ZQo+IGludHJvZHVjZSBzb21ld2hhdCBsaWdo
dGVyIHdlaWdodCBpdGVyYXRvcnMsIHByaW1hcmlseSBmb3IgdXNlIHdpdGggR0VNCj4gb2JqZWN0
cyBvciBvdGhlciBjYXNlIHdoZXJlIHdlIG5lZWQgb25seSBkZWFsIHdpdGggd2hvbGUgYWxpZ25l
ZCBwYWdlcy4KPiAKPiBVbmxpa2UgdGhlIG9sZCBpdGVyYXRvciwgdGhlIG5ldyBpdGVyYXRvcnMg
dXNlIGFuIGludGVybmFsIHN0YXRlCj4gc3RydWN0dXJlIHdoaWNoIGlzIG5vdCBpbnRlbmRlZCB0
byBiZSBhY2Nlc3NlZCBieSB0aGUgY2FsbGVyOyBpbnN0ZWFkCj4gZWFjaCB0YWtlcyBhcyBhIHBh
cmFtZXRlciBhbiBvdXRwdXQgdmFyaWFibGUgd2hpY2ggaXMgc2V0IGJlZm9yZSBlYWNoCj4gaXRl
cmF0aW9uLiBUaGlzIG1ha2VzIHRoZW0gcGFydGljdWxhcmx5IHNpbXBsZSB0byB1c2UgOikKPiAK
PiBPbmUgb2YgdGhlIG5ldyBpdGVyYXRvcnMgcHJvdmlkZXMgdGhlIGNhbGxlciB3aXRoIHRoZSBE
TUEgYWRkcmVzcyBvZgo+IGVhY2ggcGFnZSBpbiB0dXJuOyB0aGUgb3RoZXIgcHJvdmlkZXMgdGhl
ICdzdHJ1Y3QgcGFnZScgcG9pbnRlciByZXF1aXJlZAo+IGJ5IG1hbnkgbWVtb3J5IG1hbmFnZW1l
bnQgb3BlcmF0aW9ucy4KPiAKPiBWYXJpb3VzIHVzZXMgb2YgZm9yX2VhY2hfc2dfcGFnZSgpIGFy
ZSB0aGVuIGNvbnZlcnRlZCB0byB0aGUgbmV3IG1hY3Jvcy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBE
YXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgo+IENjOiBDaHJpcyBXaWxzb24g
PGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv
aTkxNV9kcnYuaCAgICAgICAgIHwgNjIgKysrKysrKysrKysrKysrKysrKysrKysrKy0tCj4gIGRy
aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgICAgICAgICB8IDIwICsrKystLS0tLQo+ICBk
cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9mZW5jZS5jICAgfCAxNCArKystLS0KPiAgZHJp
dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMgICAgIHwgNzYgKysrKysrKysrKysrKysr
Ky0tLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3VzZXJw
dHIuYyB8ICA3ICsrLQo+ICA1IGZpbGVzIGNoYW5nZWQsIDExNiBpbnNlcnRpb25zKCspLCA2MyBk
ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k
cnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBpbmRleCA2ODk0ZDhlLi4w
MWNkZTBmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiAr
KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gQEAgLTIxMjAsNiArMjEyMCwx
MCBAQCBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdF9vcHMgewo+ICAjZGVmaW5lIElOVEVMX0ZS
T05UQlVGRkVSX0FMTF9NQVNLKHBpcGUpIFwKPiAgCSgweGZmIDw8IChJTlRFTF9GUk9OVEJVRkZF
Ul9CSVRTX1BFUl9QSVBFICogKHBpcGUpKSkKPiAgCj4gK3ZvaWQgaTkxNV9nZW1fdHJhY2tfZmIo
c3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9sZCwKPiArCQkgICAgICAgc3RydWN0IGRybV9p
OTE1X2dlbV9vYmplY3QgKm5ldywKPiArCQkgICAgICAgdW5zaWduZWQgZnJvbnRidWZmZXJfYml0
cyk7Cj4gKwoKVGhhdCdzIG5vdCBhIG11Y2ggYmV0dGVyIHNwb3QsIHNpbmNlIHRoaXMgaXMgbm93
IGJlZm9yZSB0aGUgb2JqZWN0IGl0CmFjdHMgdXBvbi4gT25lIGRheSB3ZSdsbCBnZXQgb3VyIHR5
cGVzIHNlcGFyYXRlZCBmcm9tIHRoZWlyIGFjdG9ycy4KCj4gIHN0cnVjdCBkcm1faTkxNV9nZW1f
b2JqZWN0IHsKPiAgCXN0cnVjdCBkcm1fZ2VtX29iamVjdCBiYXNlOwo+ICAKPiBAQCAtMjI1MSw5
ICsyMjU1LDYxIEBAIHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0IHsKPiAgfTsKPiAgI2RlZmlu
ZSB0b19pbnRlbF9ibyh4KSBjb250YWluZXJfb2YoeCwgc3RydWN0IGRybV9pOTE1X2dlbV9vYmpl
Y3QsIGJhc2UpCj4gIAo+IC12b2lkIGk5MTVfZ2VtX3RyYWNrX2ZiKHN0cnVjdCBkcm1faTkxNV9n
ZW1fb2JqZWN0ICpvbGQsCj4gLQkJICAgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpu
ZXcsCj4gLQkJICAgICAgIHVuc2lnbmVkIGZyb250YnVmZmVyX2JpdHMpOwo+ICsvKgo+ICsgKiBO
ZXcgb3B0aW1pc2VkIFNHTCBpdGVyYXRvciBmb3IgR0VNIG9iamVjdHMKPiArICovCj4gK3N0cnVj
dCBzZ3RfaXRlciB7Cj4gKwlzdHJ1Y3Qgc2NhdHRlcmxpc3QgKnNncDsKPiArCXVuaW9uIHsKPiAr
CQl1bnNpZ25lZCBsb25nIHBmbjsKPiArCQl1bnNpZ25lZCBsb25nIGRtYTsKPiArCX0gaXg7CgpB
biBhbm9ueW1vdXMgdW5pb24gaGVyZSB3b3VsZCBiZSBzbGlnaHRseSBtb3JlIHBsZWFzYW50LiBB
bmQgd2Ugc2hvdWxkCmJlIHVzaW5nIHRoZSBjb3JyZWN0IHR5cGVzLgoKPiArCXVuc2lnbmVkIGlu
dCBjdXJyOwo+ICsJdW5zaWduZWQgaW50IG1heDsKPiArfTsKPiArCj4gKy8qIENvbnN0cnVjdG9y
IGZvciBuZXcgaXRlcmF0b3IgKi8KPiArc3RhdGljIGlubGluZSBzdHJ1Y3Qgc2d0X2l0ZXIKPiAr
X19zZ3RfaXRlcihzdHJ1Y3Qgc2NhdHRlcmxpc3QgKnNnbCwgYm9vbCBkbWEpCj4gK3sKPiArCXN0
cnVjdCBzZ3RfaXRlciBzID0geyAuc2dwID0gc2dsIH07Cj4gKwo+ICsJaWYgKHMuc2dwKSB7CgpO
b3QgYWNjZXB0YWJsZSBqdXN0IHRvIEdQRiBvdXQgaWYgcGFzc2VkIGluIGEgTlVMTD8gSXQncyBh
IEJVRyBmb3IgYWxsCm91ciB1c2UgY2FzZXMuIEFuZCB3b3VsZCBzYXZlIGEgY29uZGl0aW9uYWwg
ZXZlcnkgY2hhaW4gc3RlcC4KCj4gKwkJcy5tYXggPSBzLmN1cnIgPSBzLnNncC0+b2Zmc2V0Owo+
ICsJCXMubWF4ICs9IHMuc2dwLT5sZW5ndGg7Cj4gKwkJaWYgKGRtYSkKPiArCQkJcy5peC5kbWEg
PSBzZ19kbWFfYWRkcmVzcyhzLnNncCk7Cj4gKwkJZWxzZQo+ICsJCQlzLml4LnBmbiA9IHBhZ2Vf
dG9fcGZuKHNnX3BhZ2Uocy5zZ3ApKTsKPiArCX0KPiArCj4gKwlyZXR1cm4gczsKPiArfQo+ICsK
PiArLyoqCj4gKyAqIGZvcl9lYWNoX3NndF9kbWEgLSBpdGVyYXRlIG92ZXIgdGhlIERNQSBhZGRy
ZXNzZXMgb2YgdGhlIGdpdmVuIHNnX3RhYmxlCj4gKyAqIEBfX2RtYXA6CURNQSBhZGRyZXNzIChv
dXRwdXQpCj4gKyAqIEBfX2l0ZXI6CSdzdHJ1Y3Qgc2d0X2l0ZXInIChpdGVyYXRvciBzdGF0ZSwg
aW50ZXJuYWwpCj4gKyAqIEBfX3NndDoJc2dfdGFibGUgdG8gaXRlcmF0ZSBvdmVyIChpbnB1dCkK
PiArICovCj4gKyNkZWZpbmUgZm9yX2VhY2hfc2d0X2RtYShfX2RtYXAsIF9faXRlciwgX19zZ3Qp
CQkJCVwKPiArCWZvciAoKF9faXRlcikgPSBfX3NndF9pdGVyKChfX3NndCktPnNnbCwgdHJ1ZSk7
CQkJXAo+ICsJICAgICAoKF9fZG1hcCkgPSAoX19pdGVyKS5peC5kbWEgKyAoX19pdGVyKS5jdXJy
KTsJCVwKClRoaXMgcHJldmVudHMgdXMgdXNpbmcgZG1hX2FkZHJfdCAwLCB3aGljaCBpcyB0aGUg
ZXJyb3IgdmFsdWUgaWlyYywgc28gb2suCgo+ICsJICAgICAoKChfX2l0ZXIpLmN1cnIgKz0gUEFH
RV9TSVpFKSA8IChfX2l0ZXIpLm1heCkgfHwJCVwKPiArCQkoKF9faXRlcikgPSBfX3NndF9pdGVy
KHNnX25leHQoKF9faXRlcikuc2dwKSwgdHJ1ZSksIDApKQo+ICsKPiArLyoqCj4gKyAqIGZvcl9l
YWNoX3NndF9wYWdlIC0gaXRlcmF0ZSBvdmVyIHRoZSBwYWdlcyBvZiB0aGUgZ2l2ZW4gc2dfdGFi
bGUKPiArICogQF9fcHA6CXBhZ2UgcG9pbnRlciAob3V0cHV0KQo+ICsgKiBAX19pdGVyOgknc3Ry
dWN0IHNndF9pdGVyJyAoaXRlcmF0b3Igc3RhdGUsIGludGVybmFsKQo+ICsgKiBAX19zZ3Q6CXNn
X3RhYmxlIHRvIGl0ZXJhdGUgb3ZlciAoaW5wdXQpCj4gKyAqLwo+ICsjZGVmaW5lIGZvcl9lYWNo
X3NndF9wYWdlKF9fcHAsIF9faXRlciwgX19zZ3QpCQkJCVwKPiArCWZvciAoKF9faXRlcikgPSBf
X3NndF9pdGVyKChfX3NndCktPnNnbCwgZmFsc2UpOwkJXAo+ICsJICAgICAoKF9fcHApID0gKF9f
aXRlcikuaXgucGZuID09IDAgPyBOVUxMIDoJCQlcCj4gKwkgICAgICAgICAgIHBmbl90b19wYWdl
KChfX2l0ZXIpLml4LnBmbiArICgoX19pdGVyKS5jdXJyID4+IFBBR0VfU0hJRlQpKSk7XAoKSWYg
d2Ugc2hpZnRlZCBpbiB0aGUgX19zZ3RfaXRlcigpIHdlIGNvdWxkIGRvIHNpbXBsZXIgaW5zdHJ1
Y3Rpb25zIGluc2lkZQp0aGUgbG9vcC4gVGhlIGNvbXBpbGVyIHdvbid0IGtub3cgdGhhdCBwZm5f
dG9fcGFnZSgpIGlzIGFsd2F5cyB0cnVlLCBzbwptYXliZSBhIHBmbl90b19wYWdlKCksMSBoZXJl
IHdpbGwgaGVscD8KCj4gKwkgICAgICgoKF9faXRlcikuY3VyciArPSBQQUdFX1NJWkUpIDwgKF9f
aXRlcikubWF4KSB8fAkJXAo+ICsJCSgoX19pdGVyKSA9IF9fc2d0X2l0ZXIoc2dfbmV4dCgoX19p
dGVyKS5zZ3ApLCBmYWxzZSksIDApKQoKLS0gCkNocmlzIFdpbHNvbiwgSW50ZWwgT3BlbiBTb3Vy
Y2UgVGVjaG5vbG9neSBDZW50cmUKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl
c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v
aW50ZWwtZ2Z4Cg==