From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH v4 3/4] Introduce & use new lightweight SGL
 iterators
Date: Fri, 20 May 2016 10:56:31 +0100
Message-ID: <20160520095631.GI3590@nuc-i3427.alporthouse.com>
References: <1463704290-3491-1-git-send-email-david.s.gordon@intel.com>
 <1463704290-3491-3-git-send-email-david.s.gordon@intel.com>
 <20160520081506.GF3590@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118])
 by gabe.freedesktop.org (Postfix) with ESMTP id 7DD0F6EA9B
 for <intel-gfx@lists.freedesktop.org>; Fri, 20 May 2016 09:56:36 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20160520081506.GF3590@nuc-i3427.alporthouse.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Dave Gordon <david.s.gordon@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBNYXkgMjAsIDIwMTYgYXQgMDk6MTU6MDZBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IE9uIEZyaSwgTWF5IDIwLCAyMDE2IGF0IDAxOjMxOjI5QU0gKzAxMDAsIERhdmUgR29y
ZG9uIHdyb3RlOgo+ID4gVGhlIGV4aXN0aW5nIGZvcl9lYWNoX3NnX3BhZ2UoKSBpdGVyYXRvciBp
cyBzb21ld2hhdCBoZWF2eXdlaWdodCwgYW5kIGlzCj4gPiBsaW1pdGluZyBpOTE1IGRyaXZlciBw
ZXJmb3JtYW5jZSBpbiBhIGZldyBiZW5jaG1hcmtzLiBTbyBoZXJlIHdlCj4gPiBpbnRyb2R1Y2Ug
c29tZXdoYXQgbGlnaHRlciB3ZWlnaHQgaXRlcmF0b3JzLCBwcmltYXJpbHkgZm9yIHVzZSB3aXRo
IEdFTQo+ID4gb2JqZWN0cyBvciBvdGhlciBjYXNlIHdoZXJlIHdlIG5lZWQgb25seSBkZWFsIHdp
dGggd2hvbGUgYWxpZ25lZCBwYWdlcy4KPiA+IAo+ID4gVW5saWtlIHRoZSBvbGQgaXRlcmF0b3Is
IHRoZSBuZXcgaXRlcmF0b3JzIHVzZSBhbiBpbnRlcm5hbCBzdGF0ZQo+ID4gc3RydWN0dXJlIHdo
aWNoIGlzIG5vdCBpbnRlbmRlZCB0byBiZSBhY2Nlc3NlZCBieSB0aGUgY2FsbGVyOyBpbnN0ZWFk
Cj4gPiBlYWNoIHRha2VzIGFzIGEgcGFyYW1ldGVyIGFuIG91dHB1dCB2YXJpYWJsZSB3aGljaCBp
cyBzZXQgYmVmb3JlIGVhY2gKPiA+IGl0ZXJhdGlvbi4gVGhpcyBtYWtlcyB0aGVtIHBhcnRpY3Vs
YXJseSBzaW1wbGUgdG8gdXNlIDopCj4gPiAKPiA+IE9uZSBvZiB0aGUgbmV3IGl0ZXJhdG9ycyBw
cm92aWRlcyB0aGUgY2FsbGVyIHdpdGggdGhlIERNQSBhZGRyZXNzIG9mCj4gPiBlYWNoIHBhZ2Ug
aW4gdHVybjsgdGhlIG90aGVyIHByb3ZpZGVzIHRoZSAnc3RydWN0IHBhZ2UnIHBvaW50ZXIgcmVx
dWlyZWQKPiA+IGJ5IG1hbnkgbWVtb3J5IG1hbmFnZW1lbnQgb3BlcmF0aW9ucy4KPiA+IAo+ID4g
VmFyaW91cyB1c2VzIG9mIGZvcl9lYWNoX3NnX3BhZ2UoKSBhcmUgdGhlbiBjb252ZXJ0ZWQgdG8g
dGhlIG5ldyBtYWNyb3MuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IERhdmUgR29yZG9uIDxkYXZp
ZC5zLmdvcmRvbkBpbnRlbC5jb20+Cj4gPiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13
aWxzb24uY28udWs+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5o
ICAgICAgICAgfCA2MiArKysrKysrKysrKysrKysrKysrKysrKysrLS0KPiA+ICBkcml2ZXJzL2dw
dS9kcm0vaTkxNS9pOTE1X2dlbS5jICAgICAgICAgfCAyMCArKysrLS0tLS0KPiA+ICBkcml2ZXJz
L2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9mZW5jZS5jICAgfCAxNCArKystLS0KPiA+ICBkcml2ZXJz
L2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYyAgICAgfCA3NiArKysrKysrKysrKysrKysrLS0t
LS0tLS0tLS0tLS0tLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV91c2VycHRy
LmMgfCAgNyArKy0KPiA+ICA1IGZpbGVzIGNoYW5nZWQsIDExNiBpbnNlcnRpb25zKCspLCA2MyBk
ZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5
MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gPiBpbmRleCA2ODk0
ZDhlLi4wMWNkZTBmIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k
cnYuaAo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ID4gQEAgLTIx
MjAsNiArMjEyMCwxMCBAQCBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdF9vcHMgewo+ID4gICNk
ZWZpbmUgSU5URUxfRlJPTlRCVUZGRVJfQUxMX01BU0socGlwZSkgXAo+ID4gIAkoMHhmZiA8PCAo
SU5URUxfRlJPTlRCVUZGRVJfQklUU19QRVJfUElQRSAqIChwaXBlKSkpCj4gPiAgCj4gPiArdm9p
ZCBpOTE1X2dlbV90cmFja19mYihzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2xkLAo+ID4g
KwkJICAgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpuZXcsCj4gPiArCQkgICAgICAg
dW5zaWduZWQgZnJvbnRidWZmZXJfYml0cyk7Cj4gPiArCj4gCj4gVGhhdCdzIG5vdCBhIG11Y2gg
YmV0dGVyIHNwb3QsIHNpbmNlIHRoaXMgaXMgbm93IGJlZm9yZSB0aGUgb2JqZWN0IGl0Cj4gYWN0
cyB1cG9uLiBPbmUgZGF5IHdlJ2xsIGdldCBvdXIgdHlwZXMgc2VwYXJhdGVkIGZyb20gdGhlaXIg
YWN0b3JzLgo+IAo+ID4gIHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0IHsKPiA+ICAJc3RydWN0
IGRybV9nZW1fb2JqZWN0IGJhc2U7Cj4gPiAgCj4gPiBAQCAtMjI1MSw5ICsyMjU1LDYxIEBAIHN0
cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0IHsKPiA+ICB9Owo+ID4gICNkZWZpbmUgdG9faW50ZWxf
Ym8oeCkgY29udGFpbmVyX29mKHgsIHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0LCBiYXNlKQo+
ID4gIAo+ID4gLXZvaWQgaTkxNV9nZW1fdHJhY2tfZmIoc3RydWN0IGRybV9pOTE1X2dlbV9vYmpl
Y3QgKm9sZCwKPiA+IC0JCSAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqbmV3LAo+
ID4gLQkJICAgICAgIHVuc2lnbmVkIGZyb250YnVmZmVyX2JpdHMpOwo+ID4gKy8qCj4gPiArICog
TmV3IG9wdGltaXNlZCBTR0wgaXRlcmF0b3IgZm9yIEdFTSBvYmplY3RzCj4gPiArICovCj4gPiAr
c3RydWN0IHNndF9pdGVyIHsKPiA+ICsJc3RydWN0IHNjYXR0ZXJsaXN0ICpzZ3A7Cj4gPiArCXVu
aW9uIHsKPiA+ICsJCXVuc2lnbmVkIGxvbmcgcGZuOwo+ID4gKwkJdW5zaWduZWQgbG9uZyBkbWE7
Cj4gPiArCX0gaXg7Cj4gCj4gQW4gYW5vbnltb3VzIHVuaW9uIGhlcmUgd291bGQgYmUgc2xpZ2h0
bHkgbW9yZSBwbGVhc2FudC4gQW5kIHdlIHNob3VsZAo+IGJlIHVzaW5nIHRoZSBjb3JyZWN0IHR5
cGVzLgo+IAo+ID4gKwl1bnNpZ25lZCBpbnQgY3VycjsKPiA+ICsJdW5zaWduZWQgaW50IG1heDsK
PiA+ICt9Owo+ID4gKwo+ID4gKy8qIENvbnN0cnVjdG9yIGZvciBuZXcgaXRlcmF0b3IgKi8KPiA+
ICtzdGF0aWMgaW5saW5lIHN0cnVjdCBzZ3RfaXRlcgo+ID4gK19fc2d0X2l0ZXIoc3RydWN0IHNj
YXR0ZXJsaXN0ICpzZ2wsIGJvb2wgZG1hKQo+ID4gK3sKPiA+ICsJc3RydWN0IHNndF9pdGVyIHMg
PSB7IC5zZ3AgPSBzZ2wgfTsKPiA+ICsKPiA+ICsJaWYgKHMuc2dwKSB7Cj4gCj4gTm90IGFjY2Vw
dGFibGUganVzdCB0byBHUEYgb3V0IGlmIHBhc3NlZCBpbiBhIE5VTEw/IEl0J3MgYSBCVUcgZm9y
IGFsbAo+IG91ciB1c2UgY2FzZXMuIEFuZCB3b3VsZCBzYXZlIGEgY29uZGl0aW9uYWwgZXZlcnkg
Y2hhaW4gc3RlcC4KCk9oLCBpdCdzIGhvdyB3ZSBzdG9wIGFmdGVyIF9fc2dfbmV4dCgpLgoKT2ss
IHBsYXllZCBhIGJpdCBhbmQgdGhlIG9ubHkgdGhpbmcgdGhhdCBzdGlja3MgaXMKCiAvKgotICog
TmV3IG9wdGltaXNlZCBTR0wgaXRlcmF0b3IgZm9yIEdFTSBvYmplY3RzCisgKiBPcHRpbWlzZWQg
U0dMIGl0ZXJhdG9yIGZvciBHRU0gb2JqZWN0cwogICovCiBzdHJ1Y3Qgc2d0X2l0ZXIgewogICAg
ICAgIHN0cnVjdCBzY2F0dGVybGlzdCAqc2dwOwogICAgICAgIHVuaW9uIHsKICAgICAgICAgICAg
ICAgIHVuc2lnbmVkIGxvbmcgcGZuOwotICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBkbWE7
Ci0gICAgICAgfSBpeDsKKyAgICAgICAgICAgICAgIGRtYV9hZGRyX3QgZG1hOworICAgICAgIH07
CiAgICAgICAgdW5zaWduZWQgaW50IGN1cnI7CiAgICAgICAgdW5zaWduZWQgaW50IG1heDsKIH07
CiAKLS8qIENvbnN0cnVjdG9yIGZvciBuZXcgaXRlcmF0b3IgKi8KLXN0YXRpYyBpbmxpbmUgc3Ry
dWN0IHNndF9pdGVyCitzdGF0aWMgX19hbHdheXNfaW5saW5lIHN0cnVjdCBzZ3RfaXRlcgoKTm90
aGluZyBpcyBldmVyIG5ldyBwYXN0IHRoZSBjb21taXQgdGhhdCBpbnRyb2R1Y2VzIGl0IQoKRmlu
YWwgZGlmZiAoYSBmZXcgJSBpbiBtaWNybywgY29uc2lzdGVudGx5IGFib3ZlIHRoZSBub2lzZSk6
CgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKaW5kZXggNTNmZjQ5OTNmNWI4Li41ODZmMDY2NDY2MzAg
MTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKKysrIGIvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaApAQCAtMjI1NiwzMSArMjI1NiwyNiBAQCBzdHJ1Y3Qg
ZHJtX2k5MTVfZ2VtX29iamVjdCB7CiAjZGVmaW5lIHRvX2ludGVsX2JvKHgpIGNvbnRhaW5lcl9v
Zih4LCBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCwgYmFzZSkKIAogLyoKLSAqIE5ldyBvcHRp
bWlzZWQgU0dMIGl0ZXJhdG9yIGZvciBHRU0gb2JqZWN0cworICogT3B0aW1pc2VkIFNHTCBpdGVy
YXRvciBmb3IgR0VNIG9iamVjdHMKICAqLwotc3RydWN0IHNndF9pdGVyIHsKK3N0YXRpYyBfX2Fs
d2F5c19pbmxpbmUgc3RydWN0IHNndF9pdGVyIHsKICAgICAgICBzdHJ1Y3Qgc2NhdHRlcmxpc3Qg
KnNncDsKICAgICAgICB1bmlvbiB7CiAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIHBmbjsK
LSAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgZG1hOwotICAgICAgIH0gaXg7CisgICAgICAg
ICAgICAgICBkbWFfYWRkcl90IGRtYTsKKyAgICAgICB9OwogICAgICAgIHVuc2lnbmVkIGludCBj
dXJyOwogICAgICAgIHVuc2lnbmVkIGludCBtYXg7Ci19OwotCi0vKiBDb25zdHJ1Y3RvciBmb3Ig
bmV3IGl0ZXJhdG9yICovCi1zdGF0aWMgaW5saW5lIHN0cnVjdCBzZ3RfaXRlcgotX19zZ3RfaXRl
cihzdHJ1Y3Qgc2NhdHRlcmxpc3QgKnNnbCwgYm9vbCBkbWEpCi17Cit9IF9fc2d0X2l0ZXIoc3Ry
dWN0IHNjYXR0ZXJsaXN0ICpzZ2wsIGJvb2wgZG1hKSB7CiAgICAgICAgc3RydWN0IHNndF9pdGVy
IHMgPSB7IC5zZ3AgPSBzZ2wgfTsKIAogICAgICAgIGlmIChzLnNncCkgewogICAgICAgICAgICAg
ICAgcy5tYXggPSBzLmN1cnIgPSBzLnNncC0+b2Zmc2V0OwogICAgICAgICAgICAgICAgcy5tYXgg
Kz0gcy5zZ3AtPmxlbmd0aDsKICAgICAgICAgICAgICAgIGlmIChkbWEpCi0gICAgICAgICAgICAg
ICAgICAgICAgIHMuaXguZG1hID0gc2dfZG1hX2FkZHJlc3Mocy5zZ3ApOworICAgICAgICAgICAg
ICAgICAgICAgICBzLmRtYSA9IHNnX2RtYV9hZGRyZXNzKHMuc2dwKTsKICAgICAgICAgICAgICAg
IGVsc2UKLSAgICAgICAgICAgICAgICAgICAgICAgcy5peC5wZm4gPSBwYWdlX3RvX3BmbihzZ19w
YWdlKHMuc2dwKSk7CisgICAgICAgICAgICAgICAgICAgICAgIHMucGZuID0gcGFnZV90b19wZm4o
c2dfcGFnZShzLnNncCkpOwogICAgICAgIH0KIAogICAgICAgIHJldHVybiBzOwpAQCAtMjMxMyw5
ICsyMzA4LDkgQEAgc3RhdGljIGlubGluZSBzdHJ1Y3Qgc2NhdHRlcmxpc3QgKl9fc2dfbmV4dChz
dHJ1Y3Qgc2NhdHRlcmxpc3QgKnNnKQogICovCiAjZGVmaW5lIGZvcl9lYWNoX3NndF9kbWEoX19k
bWFwLCBfX2l0ZXIsIF9fc2d0KSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAogICAg
ICAgIGZvciAoKF9faXRlcikgPSBfX3NndF9pdGVyKChfX3NndCktPnNnbCwgdHJ1ZSk7ICAgICAg
ICAgICAgICAgICBcCi0gICAgICAgICAgICAoKF9fZG1hcCkgPSAoX19pdGVyKS5peC5kbWEgKyAo
X19pdGVyKS5jdXJyKTsgICAgICAgICAgICAgIFwKKyAgICAgICAgICAgICgoX19kbWFwKSA9IChf
X2l0ZXIpLmRtYSArIChfX2l0ZXIpLmN1cnIpOyAgICAgICAgICAgICAgICAgXAogICAgICAgICAg
ICAgKCgoX19pdGVyKS5jdXJyICs9IFBBR0VfU0laRSkgPCAoX19pdGVyKS5tYXgpIHx8ICAgICAg
ICAgICBcCi0gICAgICAgICAgICAgICAoKF9faXRlcikgPSBfX3NndF9pdGVyKF9fc2dfbmV4dCgo
X19pdGVyKS5zZ3ApLCB0cnVlKSwgMCkpCisgICAgICAgICAgICAoKF9faXRlcikgPSBfX3NndF9p
dGVyKF9fc2dfbmV4dCgoX19pdGVyKS5zZ3ApLCB0cnVlKSwgMCkpCiAKIC8qKgogICogZm9yX2Vh
Y2hfc2d0X3BhZ2UgLSBpdGVyYXRlIG92ZXIgdGhlIHBhZ2VzIG9mIHRoZSBnaXZlbiBzZ190YWJs
ZQpAQCAtMjMyNSwxMCArMjMyMCwxMCBAQCBzdGF0aWMgaW5saW5lIHN0cnVjdCBzY2F0dGVybGlz
dCAqX19zZ19uZXh0KHN0cnVjdCBzY2F0dGVybGlzdCAqc2cpCiAgKi8KICNkZWZpbmUgZm9yX2Vh
Y2hfc2d0X3BhZ2UoX19wcCwgX19pdGVyLCBfX3NndCkgICAgICAgICAgICAgICAgICAgICAgICAg
XAogICAgICAgIGZvciAoKF9faXRlcikgPSBfX3NndF9pdGVyKChfX3NndCktPnNnbCwgZmFsc2Up
OyAgICAgICAgICAgICAgICBcCi0gICAgICAgICAgICAoKF9fcHApID0gKF9faXRlcikuaXgucGZu
ID09IDAgPyBOVUxMIDogICAgICAgICAgICAgICAgICAgIFwKLSAgICAgICAgICAgICAgICAgIHBm
bl90b19wYWdlKChfX2l0ZXIpLml4LnBmbiArICgoX19pdGVyKS5jdXJyID4+IFBBR0VfU0hJRlQp
KSk7XAorICAgICAgICAgICAgKChfX3BwKSA9IChfX2l0ZXIpLnBmbiA9PSAwID8gTlVMTCA6ICAg
ICAgICAgICAgICAgICAgICAgICBcCisgICAgICAgICAgICAgcGZuX3RvX3BhZ2UoKF9faXRlciku
cGZuICsgKChfX2l0ZXIpLmN1cnIgPj4gUEFHRV9TSElGVCkpKTsgXAogICAgICAgICAgICAgKCgo
X19pdGVyKS5jdXJyICs9IFBBR0VfU0laRSkgPCAoX19pdGVyKS5tYXgpIHx8ICAgICAgICAgICBc
Ci0gICAgICAgICAgICAgICAoKF9faXRlcikgPSBfX3NndF9pdGVyKF9fc2dfbmV4dCgoX19pdGVy
KS5zZ3ApLCBmYWxzZSksIDApKQorICAgICAgICAgICAgKChfX2l0ZXIpID0gX19zZ3RfaXRlcihf
X3NnX25leHQoKF9faXRlcikuc2dwKSwgZmFsc2UpLCAwKSkKCgpBbmQgd2l0aCB0aGF0LApSZXZp
ZXdlZC1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Ci1DaHJpcwoK
LS0gCkNocmlzIFdpbHNvbiwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50cmUKX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h
aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==