From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: mhocko@kernel.org
Cc: akpm@linux-foundation.org, rientjes@google.com,
linux-mm@kvack.org, oleg@redhat.com
Subject: Re: [PATCH v3] mm,oom: speed up select_bad_process() loop.
Date: Fri, 20 May 2016 22:44:36 +0900 [thread overview]
Message-ID: <201605202244.JIC51502.FVOFOLJOQMSHtF@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <201605202241.CHG21813.FHtSFVJFMOQOLO@I-love.SAKURA.ne.jp>
Tetsuo Handa wrote:
> > > By the way, I noticed that mem_cgroup_out_of_memory() might have a bug about its
> > > return value. It returns true if hit OOM_SCAN_ABORT after chosen != NULL, false
> > > if hit OOM_SCAN_ABORT before chosen != NULL. Which is expected return value?
> >
> > true. Care to send a patch?
>
> I don't know what memory_max_write() wants to do when it found a TIF_MEMDIE thread
> in the given memcg. Thus, I can't tell whether setting chosen to NULL (which means
> mem_cgroup_out_of_memory() returns false) is the expected behavior.
>
Oops. "true" not "True" in this case meant "1" !?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-05-20 13:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 12:20 [PATCH v2] mm,oom: speed up select_bad_process() loop Tetsuo Handa
2016-05-18 12:51 ` Michal Hocko
2016-05-18 13:30 ` [PATCH v3] " Tetsuo Handa
2016-05-18 14:15 ` Michal Hocko
2016-05-18 21:09 ` Andrew Morton
2016-05-19 6:53 ` Michal Hocko
2016-05-19 7:17 ` Michal Hocko
2016-05-19 8:17 ` Michal Hocko
2016-05-20 1:50 ` Oleg Nesterov
2016-05-20 2:13 ` Oleg Nesterov
2016-05-20 6:42 ` Michal Hocko
2016-05-20 22:04 ` Oleg Nesterov
2016-05-18 14:44 ` Tetsuo Handa
2016-05-20 7:50 ` Michal Hocko
2016-05-20 11:51 ` Tetsuo Handa
2016-05-20 12:09 ` Michal Hocko
2016-05-20 13:41 ` Tetsuo Handa
2016-05-20 13:44 ` Tetsuo Handa [this message]
2016-05-20 15:23 ` Michal Hocko
2016-05-20 15:56 ` Tetsuo Handa
2016-05-23 7:55 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201605202244.JIC51502.FVOFOLJOQMSHtF@I-love.SAKURA.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=oleg@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.