From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rich Felker Date: Sat, 21 May 2016 19:17:39 +0000 Subject: Re: [PATCH v2 03/12] of: add J-Core interrupt controller bindings Message-Id: <20160521191739.GB21636@brightrain.aerifal.cx> List-Id: References: <2bdca4260d5bb2b3820e4309e2ba445c4c7bfbf6.1463708766.git.dalias@libc.org> <20160520223456.GV21636@brightrain.aerifal.cx> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linux-sh list , Ian Campbell , Jason Cooper , Kumar Gala , Marc Zyngier , Mark Rutland , Pawel Moll , Rob Herring , Thomas Gleixner On Sat, May 21, 2016 at 08:07:54PM +0200, Geert Uytterhoeven wrote: > On Sat, May 21, 2016 at 12:34 AM, Rich Felker wrote: > > On Fri, May 20, 2016 at 10:04:26AM +0200, Geert Uytterhoeven wrote: > >> On Fri, May 20, 2016 at 4:53 AM, Rich Felker wrote: > >> > +Additional properties required for aic1: > >> > + > >> > +- reg : Memory region for configuration. > >> > + > >> > +- cpu-offset : For SMP, the offset to the per-cpu memory region for > >> > + configuration, to be scaled by the cpu number. > >> > >> Does cpu-offset apply to aic1 only? > > > > The current kernel driver doesn't have any reason to _need_ cpu-offset > > for aic2, but since there are registers there that a driver (even a > > non-Linux one) may want to use, I think it makes sense that it should > > be present in the bindings. > > Hence the "for aic1" should be dropped? Yes, I've fixed that locally. Moved reg to required and cpu-offset to optional but needed for smp. Rich From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751842AbcEUTRq (ORCPT ); Sat, 21 May 2016 15:17:46 -0400 Received: from 216-12-86-13.cv.mvl.ntelos.net ([216.12.86.13]:58238 "EHLO brightrain.aerifal.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750941AbcEUTRp (ORCPT ); Sat, 21 May 2016 15:17:45 -0400 Date: Sat, 21 May 2016 15:17:39 -0400 From: Rich Felker To: Geert Uytterhoeven Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linux-sh list , Ian Campbell , Jason Cooper , Kumar Gala , Marc Zyngier , Mark Rutland , Pawel Moll , Rob Herring , Thomas Gleixner Subject: Re: [PATCH v2 03/12] of: add J-Core interrupt controller bindings Message-ID: <20160521191739.GB21636@brightrain.aerifal.cx> References: <2bdca4260d5bb2b3820e4309e2ba445c4c7bfbf6.1463708766.git.dalias@libc.org> <20160520223456.GV21636@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 21, 2016 at 08:07:54PM +0200, Geert Uytterhoeven wrote: > On Sat, May 21, 2016 at 12:34 AM, Rich Felker wrote: > > On Fri, May 20, 2016 at 10:04:26AM +0200, Geert Uytterhoeven wrote: > >> On Fri, May 20, 2016 at 4:53 AM, Rich Felker wrote: > >> > +Additional properties required for aic1: > >> > + > >> > +- reg : Memory region for configuration. > >> > + > >> > +- cpu-offset : For SMP, the offset to the per-cpu memory region for > >> > + configuration, to be scaled by the cpu number. > >> > >> Does cpu-offset apply to aic1 only? > > > > The current kernel driver doesn't have any reason to _need_ cpu-offset > > for aic2, but since there are registers there that a driver (even a > > non-Linux one) may want to use, I think it makes sense that it should > > be present in the bindings. > > Hence the "for aic1" should be dropped? Yes, I've fixed that locally. Moved reg to required and cpu-offset to optional but needed for smp. Rich