All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Viacheslav Dubeyko <slava@dubeyko.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Jaegeuk Kim <jaegeuk@kernel.org>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	Vyacheslav.Dubeyko@hgst.com, Cyril.Guyot@hgst.com,
	Adam.Manzanares@hgst.com, Damien.LeMoal@hgst.com
Subject: Re: [PATCH] f2fs: introduce on-disk layout version checking functionality
Date: Mon, 23 May 2016 01:25:42 -0700	[thread overview]
Message-ID: <20160523082542.GA27833@infradead.org> (raw)
In-Reply-To: <1463769043.2835.30.camel@slavad-ubuntu-14.04>

On Fri, May 20, 2016 at 11:30:43AM -0700, Viacheslav Dubeyko wrote:
> I am not sure that I follow to your point. The F2FS has "feature" field
> (__le32 feature) into on-disk superblock (struct f2fs_super_block). The
> suggested patch introduces the new F2FS_FEATURE_16TB_SUPPORT flag. And
> it looks like as your comment.

It does, but at the same time you also introduce a major version
superblock
field.

> So, necessary changes in on-disk layout for 16+TB volumes support will
> be incompatible with current available version of F2FS driver. It means
> that, anyway, we need to increase version of on-disk layout (major_ver
> of struct f2fs_super_block). The presence of superblock's version and
> F2FS_FEATURE_16TB_SUPPORT flag will be very useful for consistency
> checking by fsck tool.

Why is the feature not enough for that?

  reply	other threads:[~2016-05-23  8:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-19 17:46 [PATCH] f2fs: introduce on-disk layout version checking functionality Viacheslav Dubeyko
2016-05-20  7:58 ` Christoph Hellwig
2016-05-20 18:30   ` Viacheslav Dubeyko
2016-05-23  8:25     ` Christoph Hellwig [this message]
2016-05-23 20:08       ` Viacheslav Dubeyko
2016-05-24  8:52         ` Christoph Hellwig
2016-05-25  0:53           ` Viacheslav Dubeyko
2016-05-23 21:13 ` Jaegeuk Kim
2016-05-23 21:13   ` Jaegeuk Kim
2016-05-24  8:53   ` Christoph Hellwig
2016-05-25  0:34     ` Viacheslav Dubeyko
2016-05-25  1:05   ` Viacheslav Dubeyko
2016-05-25 17:12     ` Jaegeuk Kim
2016-05-25 17:46       ` Viacheslav Dubeyko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160523082542.GA27833@infradead.org \
    --to=hch@infradead.org \
    --cc=Adam.Manzanares@hgst.com \
    --cc=Cyril.Guyot@hgst.com \
    --cc=Damien.LeMoal@hgst.com \
    --cc=Vyacheslav.Dubeyko@hgst.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=slava@dubeyko.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.