From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752945AbcEWWWd (ORCPT ); Mon, 23 May 2016 18:22:33 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:33230 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951AbcEWWWb (ORCPT ); Mon, 23 May 2016 18:22:31 -0400 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Darren Hart Subject: Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended Date: Tue, 24 May 2016 00:22:28 +0200 User-Agent: KMail/1.13.7 (Linux/3.13.0-86-generic; KDE/4.14.2; x86_64; ; ) Cc: Gabriele Mazzotta , "Rafael J. Wysocki" , "D. Jared Dominguez" , "platform-driver-x86@vger.kernel.org" , Alex Hung , Andrei Borzenkov , "linux-kernel@vger.kernel.org" References: <1457740175-8327-1-git-send-email-gabriele.mzt@gmail.com> <201605240006.03580@pali> <20160523221715.GE2735@f23x64.localdomain> In-Reply-To: <20160523221715.GE2735@f23x64.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3275945.aYp4lR5EcH"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201605240022.28140@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart3275945.aYp4lR5EcH Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Tuesday 24 May 2016 00:17:15 Darren Hart wrote: > On Tue, May 24, 2016 at 12:06:03AM +0200, Pali Roh=C3=A1r wrote: > > On Monday 23 May 2016 23:26:55 Darren Hart wrote: > > > I've queued this. Thanks for your patience. > >=20 > > Ok, In that case I would update comments in patch to try it more > > clear what code is doing. >=20 > I thought I had your approval on this one Pali. Apologies if that was > not the case. Did I miss a change request from you? >=20 > If so, please point me at it, and I'll dequeue this one and wait for > an updated one. I just wanted to review that code from somebody else and decide if=20 accept it or not. Because I was not sure if it is OK... But there was no objection, so patch is OK. And I pointed that patch could have better comments to describe what it=20 is doing as at first time I was confused. So I believe that you can update patch in your queue with new version=20 which just change comments in source code (without functional changes). =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart3275945.aYp4lR5EcH Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAldDgqQACgkQi/DJPQPkQ1JSAwCaAnETD3Geil6kFwUlReVCEsph ykkAoLh4QtUvlmvFO7OP4flHaqqP6chJ =Z17y -----END PGP SIGNATURE----- --nextPart3275945.aYp4lR5EcH-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?q?Roh=C3=A1r?= Subject: Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended Date: Tue, 24 May 2016 00:22:28 +0200 Message-ID: <201605240022.28140@pali> References: <1457740175-8327-1-git-send-email-gabriele.mzt@gmail.com> <201605240006.03580@pali> <20160523221715.GE2735@f23x64.localdomain> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3275945.aYp4lR5EcH"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wm0-f43.google.com ([74.125.82.43]:33230 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951AbcEWWWb (ORCPT ); Mon, 23 May 2016 18:22:31 -0400 In-Reply-To: <20160523221715.GE2735@f23x64.localdomain> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Darren Hart Cc: Gabriele Mazzotta , "Rafael J. Wysocki" , "D. Jared Dominguez" , "platform-driver-x86@vger.kernel.org" , Alex Hung , Andrei Borzenkov , "linux-kernel@vger.kernel.org" --nextPart3275945.aYp4lR5EcH Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Tuesday 24 May 2016 00:17:15 Darren Hart wrote: > On Tue, May 24, 2016 at 12:06:03AM +0200, Pali Roh=C3=A1r wrote: > > On Monday 23 May 2016 23:26:55 Darren Hart wrote: > > > I've queued this. Thanks for your patience. > >=20 > > Ok, In that case I would update comments in patch to try it more > > clear what code is doing. >=20 > I thought I had your approval on this one Pali. Apologies if that was > not the case. Did I miss a change request from you? >=20 > If so, please point me at it, and I'll dequeue this one and wait for > an updated one. I just wanted to review that code from somebody else and decide if=20 accept it or not. Because I was not sure if it is OK... But there was no objection, so patch is OK. And I pointed that patch could have better comments to describe what it=20 is doing as at first time I was confused. So I believe that you can update patch in your queue with new version=20 which just change comments in source code (without functional changes). =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart3275945.aYp4lR5EcH Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAldDgqQACgkQi/DJPQPkQ1JSAwCaAnETD3Geil6kFwUlReVCEsph ykkAoLh4QtUvlmvFO7OP4flHaqqP6chJ =Z17y -----END PGP SIGNATURE----- --nextPart3275945.aYp4lR5EcH--