All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] perf pt: Mark PT return events as "return"
Date: Mon, 23 May 2016 17:50:49 -0700	[thread overview]
Message-ID: <20160524005049.GA22049@tassilo.jf.intel.com> (raw)
In-Reply-To: <5742F1F4.9040709@intel.com>

On Mon, May 23, 2016 at 03:05:08PM +0300, Adrian Hunter wrote:
> On 20/05/16 22:52, Andi Kleen wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> > 
> > With perf script --itrace=cr we can synthesize calls and returns out of
> > a PT log. However both calls and returns are marked with the same event,
> > called branches. This makes it difficult to read and post process,
> > because calls and returns are somewhat diffferent.
> 
> Did you consider the sample flags?
> e.g.

True. But reporting it in the event name looks nicer, so I think the patch
is still useful.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only

  reply	other threads:[~2016-05-24  0:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-20 19:52 [PATCH 1/2] perf pt: Mark PT return events as "return" Andi Kleen
2016-05-20 19:52 ` [PATCH 2/2] perf script: Support callindent Andi Kleen
2016-05-20 20:27   ` Arnaldo Carvalho de Melo
2016-05-23 12:05 ` [PATCH 1/2] perf pt: Mark PT return events as "return" Adrian Hunter
2016-05-24  0:50   ` Andi Kleen [this message]
2016-06-10 22:55 Andi Kleen
2016-06-16 12:38 ` Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160524005049.GA22049@tassilo.jf.intel.com \
    --to=ak@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=andi@firstfloor.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.