From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756150AbcEXQeO (ORCPT ); Tue, 24 May 2016 12:34:14 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59869 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752431AbcEXQeN (ORCPT ); Tue, 24 May 2016 12:34:13 -0400 Date: Tue, 24 May 2016 09:34:11 -0700 From: Greg KH To: Bart Van Assche Cc: "Bryant G. Ly" , JBottomley@odin.com, martin.petersen@oracle.com, tyreld@linux.vnet.ibm.com, akpm@linux-foundation.org, kvalo@codeaurora.org, davem@davemloft.net, mchehab@osg.samsung.com, jslaby@suse.com, joe@perches.com, bp@suse.de, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, bgly Subject: Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver Message-ID: <20160524163411.GA21800@kroah.com> References: <1464097978-88457-1-git-send-email-bryantly@linux.vnet.ibm.com> <3303bc98-ade7-62f0-71c7-11e7ef42b42d@sandisk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3303bc98-ade7-62f0-71c7-11e7ef42b42d@sandisk.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 24, 2016 at 09:25:05AM -0700, Bart Van Assche wrote: > > +static inline long h_send_crq(struct ibmvscsis_adapter *adapter, > > + u64 word1, u64 word2) > > +{ > > + long rc; > > + struct vio_dev *vdev = adapter->dma_dev; > > + > > + pr_debug("ibmvscsis: ibmvscsis_send_crq(0x%x, 0x%016llx, 0x%016llx)\n", > > + vdev->unit_address, word1, word2); > > + > > As Joe Perches already asked, please define pr_fmt() instead of including > the kernel module name in every pr_debug() statement. Even better, as this is a driver, it should be using dev_*() calls instead of pr_*() calls to properly identify the device and driver that is making the message. No driver should be using pr_*() except in _very_ limited usages. thanks, greg k-h