From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH 06/10] IB/hfi1: Add ioctl() interface for user commands Date: Tue, 24 May 2016 14:54:25 -0600 Message-ID: <20160524205425.GA7950@obsidianresearch.com> References: <20160522140351.GA10696@phlsvsds.ph.intel.com> <20160522175715.GD25500@leon.nu> <20160523122207.GA16764@phlsvsds.ph.intel.com> <20160523130312.GG25500@leon.nu> <20160523141049.GE16764@phlsvsds.ph.intel.com> <20160524175409.GI25500@leon.nu> <20160524201317.GK25500@leon.nu> <1828884A29C6694DAF28B7E6B8A82373AB050188@ORSMSX109.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1828884A29C6694DAF28B7E6B8A82373AB050188-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Hefty, Sean" Cc: "leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , Doug Ledford , "Dalessandro, Dennis" , "Haralanov, Mitko" , "Weiny, Ira" , "Marciniszyn, Mike" , linux-rdma List-Id: linux-rdma@vger.kernel.org On Tue, May 24, 2016 at 08:29:41PM +0000, Hefty, Sean wrote: > > Let's assume that you are planning to provide block of 20 ioctls per > > device. Right now, there are 10 (or 8 if we count driver families) drivers in > > drivers/infiniband/hw/ + 1 is coming (HSI) + uverbs (approximately 40) > > => 8 * 20 + 20 + 40 = 220 ioctls => we already in shortage without room > > to expansion. > > Ioctl commands are naturally scoped per open file. Unless the > opened file supports ioctls directed to every piece of hardware, I > don't see why there's an obsession with command space. The kernel standard is to have ioctl numbers be globally unique, even though technically you are right and they are scoped to a file. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html