* [Qemu-devel] [Bug 1585533] [NEW] cache-miss-rate / Invalid JSON
@ 2016-05-25 8:46 Marc Brothier
2016-05-25 8:50 ` [Qemu-devel] [Bug 1585533] " Marc Brothier
` (11 more replies)
0 siblings, 12 replies; 13+ messages in thread
From: Marc Brothier @ 2016-05-25 8:46 UTC (permalink / raw)
To: qemu-devel
Public bug reported:
Hi,
We have VMs which were started with an older version than qemu 2.1 which
added "cache-miss-rate" property for XBZRLECacheStats. While trying to
migrate the VM to a new host which is running a higher version (2.3) of
Qemu we got an exception:
virJSONValueFromString:1642 : internal error: cannot parse json {"return": {"expected-downtime": 1, "xbzrle-cache": {"bytes": 0, "cache-size": 67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0, "cache-miss": 8933}, "status": "active", "disk": {"total": 429496729600, "dirty-sync-count": 0, "remaining": 193896382464, "mbps": 0, "transferred": 235600347136, "duplicate": 0, "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 0, "normal": 0}, "setup-time": 13, "total-time": 1543124, "ram": {"total": 8599183360, "dirty-sync-count": 4, "remaining": 30695424, "mbps": 830.636997, "transferred": 3100448901, "duplicate": 1358341, "dirty-pages-rate": 7, "skipped": 0, "normal-bytes": 3082199040, "normal": 752490}}, "id": "libvirt-186200"}: lexical error: malformed number, a digit is required after the minus sign.
67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0
(right here) ------^
virNetClientStreamRaiseError:191 : stream aborted at client request
Would it be possible to improve the JSON parser to skip the key if the value is incorrect instead of throwing an exception? Then hopefully qemu 2.3 or higher is able to handle the data without this property, falling back to its default.
** Affects: qemu
Importance: Undecided
Status: Invalid
** Tags: cache-miss-rate json xbzrlecachestats
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1585533
Title:
cache-miss-rate / Invalid JSON
Status in QEMU:
Invalid
Bug description:
Hi,
We have VMs which were started with an older version than qemu 2.1
which added "cache-miss-rate" property for XBZRLECacheStats. While
trying to migrate the VM to a new host which is running a higher
version (2.3) of Qemu we got an exception:
virJSONValueFromString:1642 : internal error: cannot parse json {"return": {"expected-downtime": 1, "xbzrle-cache": {"bytes": 0, "cache-size": 67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0, "cache-miss": 8933}, "status": "active", "disk": {"total": 429496729600, "dirty-sync-count": 0, "remaining": 193896382464, "mbps": 0, "transferred": 235600347136, "duplicate": 0, "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 0, "normal": 0}, "setup-time": 13, "total-time": 1543124, "ram": {"total": 8599183360, "dirty-sync-count": 4, "remaining": 30695424, "mbps": 830.636997, "transferred": 3100448901, "duplicate": 1358341, "dirty-pages-rate": 7, "skipped": 0, "normal-bytes": 3082199040, "normal": 752490}}, "id": "libvirt-186200"}: lexical error: malformed number, a digit is required after the minus sign.
67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0
(right here) ------^
virNetClientStreamRaiseError:191 : stream aborted at client request
Would it be possible to improve the JSON parser to skip the key if the value is incorrect instead of throwing an exception? Then hopefully qemu 2.3 or higher is able to handle the data without this property, falling back to its default.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1585533/+subscriptions
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] [Bug 1585533] Re: cache-miss-rate / Invalid JSON
2016-05-25 8:46 [Qemu-devel] [Bug 1585533] [NEW] cache-miss-rate / Invalid JSON Marc Brothier
@ 2016-05-25 8:50 ` Marc Brothier
2016-05-25 11:10 ` [Qemu-devel] [Bug 1585533] [NEW] " Eric Blake
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Marc Brothier @ 2016-05-25 8:50 UTC (permalink / raw)
To: qemu-devel
Sorry, the bug is in libvirt
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1585533
Title:
cache-miss-rate / Invalid JSON
Status in QEMU:
Invalid
Bug description:
Hi,
We have VMs which were started with an older version than qemu 2.1
which added "cache-miss-rate" property for XBZRLECacheStats. While
trying to migrate the VM to a new host which is running a higher
version (2.3) of Qemu we got an exception:
virJSONValueFromString:1642 : internal error: cannot parse json {"return": {"expected-downtime": 1, "xbzrle-cache": {"bytes": 0, "cache-size": 67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0, "cache-miss": 8933}, "status": "active", "disk": {"total": 429496729600, "dirty-sync-count": 0, "remaining": 193896382464, "mbps": 0, "transferred": 235600347136, "duplicate": 0, "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 0, "normal": 0}, "setup-time": 13, "total-time": 1543124, "ram": {"total": 8599183360, "dirty-sync-count": 4, "remaining": 30695424, "mbps": 830.636997, "transferred": 3100448901, "duplicate": 1358341, "dirty-pages-rate": 7, "skipped": 0, "normal-bytes": 3082199040, "normal": 752490}}, "id": "libvirt-186200"}: lexical error: malformed number, a digit is required after the minus sign.
67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0
(right here) ------^
virNetClientStreamRaiseError:191 : stream aborted at client request
Would it be possible to improve the JSON parser to skip the key if the value is incorrect instead of throwing an exception? Then hopefully qemu 2.3 or higher is able to handle the data without this property, falling back to its default.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1585533/+subscriptions
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] [Bug 1585533] [NEW] cache-miss-rate / Invalid JSON
2016-05-25 8:46 [Qemu-devel] [Bug 1585533] [NEW] cache-miss-rate / Invalid JSON Marc Brothier
2016-05-25 8:50 ` [Qemu-devel] [Bug 1585533] " Marc Brothier
@ 2016-05-25 11:10 ` Eric Blake
2016-05-25 11:45 ` [Qemu-devel] [Bug 1585533] " Marc Brothier
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Eric Blake @ 2016-05-25 11:10 UTC (permalink / raw)
To: Bug 1585533, qemu-devel, libvir-list
[-- Attachment #1: Type: text/plain, Size: 2545 bytes --]
On 05/25/2016 02:46 AM, Marc Brothier wrote:
> Public bug reported:
>
> Hi,
>
> We have VMs which were started with an older version than qemu 2.1 which
> added "cache-miss-rate" property for XBZRLECacheStats. While trying to
> migrate the VM to a new host which is running a higher version (2.3) of
> Qemu we got an exception:
>
> virJSONValueFromString:1642 : internal error: cannot parse json {"return": {"expected-downtime": 1, "xbzrle-cache": {"bytes": 0, "cache-size": 67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0, "cache-miss": 8933}, "status": "active", "disk": {"total": 429496729600, "dirty-sync-count": 0, "remaining": 193896382464, "mbps": 0, "transferred": 235600347136, "duplicate": 0, "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 0, "normal": 0}, "setup-time": 13, "total-time": 1543124, "ram": {"total": 8599183360, "dirty-sync-count": 4, "remaining": 30695424, "mbps": 830.636997, "transferred": 3100448901, "duplicate": 1358341, "dirty-pages-rate": 7, "skipped": 0, "normal-bytes": 3082199040, "normal": 752490}}, "id": "libvirt-186200"}: lexical error: malformed number, a digit is required after the minus sign.
> 67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0
> (right here) ------^
>
> virNetClientStreamRaiseError:191 : stream aborted at client request
Wow - I've known we have a problem with qemu emitting non-compliant
JSON, but this proves that it is fatal to libvirt. I guess my series on
improving the JSON parser [1] should consider doing a fallback to
s/NaN/0/ and s/Inf/DBL_MAX/ rather than completely erroring out when a
client tries to request it. Meanwhile, it's an easy patch to qemu to
avoid division by zero when generating cache-miss-rate.
[1] https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg03424.html
>
>
> Would it be possible to improve the JSON parser to skip the key if the value is incorrect
Libvirt uses libyajl to parse JSON, and libyajl has an outstanding bug
request to support extensions to JSON such as parsing non-finite floats.
Since there has been no upstream reaction to the bug request, I
seriously doubt it will happen any time soon, so any change to tolerate
NaN in libvirt would have to be a one-off patch. It sounds like the
better fix is to make qemu emit valid JSON in the first place, rather
than making libvirt deal with broken JSON from qemu.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] [Bug 1585533] Re: cache-miss-rate / Invalid JSON
2016-05-25 8:46 [Qemu-devel] [Bug 1585533] [NEW] cache-miss-rate / Invalid JSON Marc Brothier
2016-05-25 8:50 ` [Qemu-devel] [Bug 1585533] " Marc Brothier
2016-05-25 11:10 ` [Qemu-devel] [Bug 1585533] [NEW] " Eric Blake
@ 2016-05-25 11:45 ` Marc Brothier
2016-05-25 11:50 ` Marc Brothier
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Marc Brothier @ 2016-05-25 11:45 UTC (permalink / raw)
To: qemu-devel
Ok, then I'll reopen the bug with a request to fix JSON output in qemu.
** Changed in: qemu
Status: Invalid => New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1585533
Title:
cache-miss-rate / Invalid JSON
Status in QEMU:
New
Bug description:
Hi,
We have VMs which were started with an older version than qemu 2.1
which added "cache-miss-rate" property for XBZRLECacheStats. While
trying to migrate the VM to a new host which is running a higher
version (2.3) of Qemu we got an exception:
virJSONValueFromString:1642 : internal error: cannot parse json {"return": {"expected-downtime": 1, "xbzrle-cache": {"bytes": 0, "cache-size": 67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0, "cache-miss": 8933}, "status": "active", "disk": {"total": 429496729600, "dirty-sync-count": 0, "remaining": 193896382464, "mbps": 0, "transferred": 235600347136, "duplicate": 0, "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 0, "normal": 0}, "setup-time": 13, "total-time": 1543124, "ram": {"total": 8599183360, "dirty-sync-count": 4, "remaining": 30695424, "mbps": 830.636997, "transferred": 3100448901, "duplicate": 1358341, "dirty-pages-rate": 7, "skipped": 0, "normal-bytes": 3082199040, "normal": 752490}}, "id": "libvirt-186200"}: lexical error: malformed number, a digit is required after the minus sign.
67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0
(right here) ------^
virNetClientStreamRaiseError:191 : stream aborted at client request
Would it be possible to improve the JSON parser to skip the key if the value is incorrect instead of throwing an exception? Then hopefully qemu 2.3 or higher is able to handle the data without this property, falling back to its default.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1585533/+subscriptions
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] [Bug 1585533] Re: cache-miss-rate / Invalid JSON
2016-05-25 8:46 [Qemu-devel] [Bug 1585533] [NEW] cache-miss-rate / Invalid JSON Marc Brothier
` (2 preceding siblings ...)
2016-05-25 11:45 ` [Qemu-devel] [Bug 1585533] " Marc Brothier
@ 2016-05-25 11:50 ` Marc Brothier
2016-05-25 12:49 ` Paolo Bonzini
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Marc Brothier @ 2016-05-25 11:50 UTC (permalink / raw)
To: qemu-devel
Also found a patch in qemu 2.4.0 (?) which fix a zero division:
https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg01173.html
which might be the source of the problem.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1585533
Title:
cache-miss-rate / Invalid JSON
Status in QEMU:
New
Bug description:
Hi,
We have VMs which were started with an older version than qemu 2.1
which added "cache-miss-rate" property for XBZRLECacheStats. While
trying to migrate the VM to a new host which is running a higher
version (2.3) of Qemu we got an exception:
virJSONValueFromString:1642 : internal error: cannot parse json {"return": {"expected-downtime": 1, "xbzrle-cache": {"bytes": 0, "cache-size": 67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0, "cache-miss": 8933}, "status": "active", "disk": {"total": 429496729600, "dirty-sync-count": 0, "remaining": 193896382464, "mbps": 0, "transferred": 235600347136, "duplicate": 0, "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 0, "normal": 0}, "setup-time": 13, "total-time": 1543124, "ram": {"total": 8599183360, "dirty-sync-count": 4, "remaining": 30695424, "mbps": 830.636997, "transferred": 3100448901, "duplicate": 1358341, "dirty-pages-rate": 7, "skipped": 0, "normal-bytes": 3082199040, "normal": 752490}}, "id": "libvirt-186200"}: lexical error: malformed number, a digit is required after the minus sign.
67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0
(right here) ------^
virNetClientStreamRaiseError:191 : stream aborted at client request
Would it be possible to improve the JSON parser to skip the key if the value is incorrect instead of throwing an exception? Then hopefully qemu 2.3 or higher is able to handle the data without this property, falling back to its default.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1585533/+subscriptions
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] [Bug 1585533] Re: cache-miss-rate / Invalid JSON
2016-05-25 8:46 [Qemu-devel] [Bug 1585533] [NEW] cache-miss-rate / Invalid JSON Marc Brothier
` (3 preceding siblings ...)
2016-05-25 11:50 ` Marc Brothier
@ 2016-05-25 12:49 ` Paolo Bonzini
2016-05-26 13:05 ` Marc Brothier
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Paolo Bonzini @ 2016-05-25 12:49 UTC (permalink / raw)
To: qemu-devel
Marc, what distro are you running on? QEMU 2.3 is not maintained
anymore upstream, so unless you are running on Ubuntu (and then we can
reuse this bug tracker) you'll have to reopen the bug in your distro.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1585533
Title:
cache-miss-rate / Invalid JSON
Status in QEMU:
New
Bug description:
Hi,
We have VMs which were started with an older version than qemu 2.1
which added "cache-miss-rate" property for XBZRLECacheStats. While
trying to migrate the VM to a new host which is running a higher
version (2.3) of Qemu we got an exception:
virJSONValueFromString:1642 : internal error: cannot parse json {"return": {"expected-downtime": 1, "xbzrle-cache": {"bytes": 0, "cache-size": 67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0, "cache-miss": 8933}, "status": "active", "disk": {"total": 429496729600, "dirty-sync-count": 0, "remaining": 193896382464, "mbps": 0, "transferred": 235600347136, "duplicate": 0, "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 0, "normal": 0}, "setup-time": 13, "total-time": 1543124, "ram": {"total": 8599183360, "dirty-sync-count": 4, "remaining": 30695424, "mbps": 830.636997, "transferred": 3100448901, "duplicate": 1358341, "dirty-pages-rate": 7, "skipped": 0, "normal-bytes": 3082199040, "normal": 752490}}, "id": "libvirt-186200"}: lexical error: malformed number, a digit is required after the minus sign.
67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0
(right here) ------^
virNetClientStreamRaiseError:191 : stream aborted at client request
Would it be possible to improve the JSON parser to skip the key if the value is incorrect instead of throwing an exception? Then hopefully qemu 2.3 or higher is able to handle the data without this property, falling back to its default.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1585533/+subscriptions
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] [Bug 1585533] Re: cache-miss-rate / Invalid JSON
2016-05-25 8:46 [Qemu-devel] [Bug 1585533] [NEW] cache-miss-rate / Invalid JSON Marc Brothier
` (4 preceding siblings ...)
2016-05-25 12:49 ` Paolo Bonzini
@ 2016-05-26 13:05 ` Marc Brothier
2016-05-31 6:10 ` Marc Brothier
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Marc Brothier @ 2016-05-26 13:05 UTC (permalink / raw)
To: qemu-devel
We're using Ubuntu, and we manually patched the version 2.3 with the fix
referenced. It will be soon deployed and I'll see if that fixes the
problem.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1585533
Title:
cache-miss-rate / Invalid JSON
Status in QEMU:
New
Bug description:
Hi,
We have VMs which were started with an older version than qemu 2.1
which added "cache-miss-rate" property for XBZRLECacheStats. While
trying to migrate the VM to a new host which is running a higher
version (2.3) of Qemu we got an exception:
virJSONValueFromString:1642 : internal error: cannot parse json {"return": {"expected-downtime": 1, "xbzrle-cache": {"bytes": 0, "cache-size": 67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0, "cache-miss": 8933}, "status": "active", "disk": {"total": 429496729600, "dirty-sync-count": 0, "remaining": 193896382464, "mbps": 0, "transferred": 235600347136, "duplicate": 0, "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 0, "normal": 0}, "setup-time": 13, "total-time": 1543124, "ram": {"total": 8599183360, "dirty-sync-count": 4, "remaining": 30695424, "mbps": 830.636997, "transferred": 3100448901, "duplicate": 1358341, "dirty-pages-rate": 7, "skipped": 0, "normal-bytes": 3082199040, "normal": 752490}}, "id": "libvirt-186200"}: lexical error: malformed number, a digit is required after the minus sign.
67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0
(right here) ------^
virNetClientStreamRaiseError:191 : stream aborted at client request
Would it be possible to improve the JSON parser to skip the key if the value is incorrect instead of throwing an exception? Then hopefully qemu 2.3 or higher is able to handle the data without this property, falling back to its default.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1585533/+subscriptions
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] [Bug 1585533] Re: cache-miss-rate / Invalid JSON
2016-05-25 8:46 [Qemu-devel] [Bug 1585533] [NEW] cache-miss-rate / Invalid JSON Marc Brothier
` (5 preceding siblings ...)
2016-05-26 13:05 ` Marc Brothier
@ 2016-05-31 6:10 ` Marc Brothier
2016-06-01 14:12 ` Marc Brothier
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Marc Brothier @ 2016-05-31 6:10 UTC (permalink / raw)
To: qemu-devel
We tried to migrate a VM, and now we have a new error:
error : virNetClientProgramDispatchError:177 : internal error: info
migration reply was missing return status
:(
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1585533
Title:
cache-miss-rate / Invalid JSON
Status in QEMU:
New
Bug description:
Hi,
We have VMs which were started with an older version than qemu 2.1
which added "cache-miss-rate" property for XBZRLECacheStats. While
trying to migrate the VM to a new host which is running a higher
version (2.3) of Qemu we got an exception:
virJSONValueFromString:1642 : internal error: cannot parse json {"return": {"expected-downtime": 1, "xbzrle-cache": {"bytes": 0, "cache-size": 67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0, "cache-miss": 8933}, "status": "active", "disk": {"total": 429496729600, "dirty-sync-count": 0, "remaining": 193896382464, "mbps": 0, "transferred": 235600347136, "duplicate": 0, "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 0, "normal": 0}, "setup-time": 13, "total-time": 1543124, "ram": {"total": 8599183360, "dirty-sync-count": 4, "remaining": 30695424, "mbps": 830.636997, "transferred": 3100448901, "duplicate": 1358341, "dirty-pages-rate": 7, "skipped": 0, "normal-bytes": 3082199040, "normal": 752490}}, "id": "libvirt-186200"}: lexical error: malformed number, a digit is required after the minus sign.
67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0
(right here) ------^
virNetClientStreamRaiseError:191 : stream aborted at client request
Would it be possible to improve the JSON parser to skip the key if the value is incorrect instead of throwing an exception? Then hopefully qemu 2.3 or higher is able to handle the data without this property, falling back to its default.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1585533/+subscriptions
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] [Bug 1585533] Re: cache-miss-rate / Invalid JSON
2016-05-25 8:46 [Qemu-devel] [Bug 1585533] [NEW] cache-miss-rate / Invalid JSON Marc Brothier
` (6 preceding siblings ...)
2016-05-31 6:10 ` Marc Brothier
@ 2016-06-01 14:12 ` Marc Brothier
2016-06-07 16:02 ` Marc Brothier
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Marc Brothier @ 2016-06-01 14:12 UTC (permalink / raw)
To: qemu-devel
I didn't look properly, it's the same error with the patch applied.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1585533
Title:
cache-miss-rate / Invalid JSON
Status in QEMU:
New
Bug description:
Hi,
We have VMs which were started with an older version than qemu 2.1
which added "cache-miss-rate" property for XBZRLECacheStats. While
trying to migrate the VM to a new host which is running a higher
version (2.3) of Qemu we got an exception:
virJSONValueFromString:1642 : internal error: cannot parse json {"return": {"expected-downtime": 1, "xbzrle-cache": {"bytes": 0, "cache-size": 67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0, "cache-miss": 8933}, "status": "active", "disk": {"total": 429496729600, "dirty-sync-count": 0, "remaining": 193896382464, "mbps": 0, "transferred": 235600347136, "duplicate": 0, "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 0, "normal": 0}, "setup-time": 13, "total-time": 1543124, "ram": {"total": 8599183360, "dirty-sync-count": 4, "remaining": 30695424, "mbps": 830.636997, "transferred": 3100448901, "duplicate": 1358341, "dirty-pages-rate": 7, "skipped": 0, "normal-bytes": 3082199040, "normal": 752490}}, "id": "libvirt-186200"}: lexical error: malformed number, a digit is required after the minus sign.
67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0
(right here) ------^
virNetClientStreamRaiseError:191 : stream aborted at client request
Would it be possible to improve the JSON parser to skip the key if the value is incorrect instead of throwing an exception? Then hopefully qemu 2.3 or higher is able to handle the data without this property, falling back to its default.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1585533/+subscriptions
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] [Bug 1585533] Re: cache-miss-rate / Invalid JSON
2016-05-25 8:46 [Qemu-devel] [Bug 1585533] [NEW] cache-miss-rate / Invalid JSON Marc Brothier
` (7 preceding siblings ...)
2016-06-01 14:12 ` Marc Brothier
@ 2016-06-07 16:02 ` Marc Brothier
2019-05-27 8:37 ` Thomas Huth
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Marc Brothier @ 2016-06-07 16:02 UTC (permalink / raw)
To: qemu-devel
Well, to make this work we updated the libvirt code to correct such
invalid value and put a "0" in that case for the "cache-miss-rate"
value. Can someone confirm that it putting a "0" is a valid choice, or
shall we have something else?
Thanks
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1585533
Title:
cache-miss-rate / Invalid JSON
Status in QEMU:
New
Bug description:
Hi,
We have VMs which were started with an older version than qemu 2.1
which added "cache-miss-rate" property for XBZRLECacheStats. While
trying to migrate the VM to a new host which is running a higher
version (2.3) of Qemu we got an exception:
virJSONValueFromString:1642 : internal error: cannot parse json {"return": {"expected-downtime": 1, "xbzrle-cache": {"bytes": 0, "cache-size": 67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0, "cache-miss": 8933}, "status": "active", "disk": {"total": 429496729600, "dirty-sync-count": 0, "remaining": 193896382464, "mbps": 0, "transferred": 235600347136, "duplicate": 0, "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 0, "normal": 0}, "setup-time": 13, "total-time": 1543124, "ram": {"total": 8599183360, "dirty-sync-count": 4, "remaining": 30695424, "mbps": 830.636997, "transferred": 3100448901, "duplicate": 1358341, "dirty-pages-rate": 7, "skipped": 0, "normal-bytes": 3082199040, "normal": 752490}}, "id": "libvirt-186200"}: lexical error: malformed number, a digit is required after the minus sign.
67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0
(right here) ------^
virNetClientStreamRaiseError:191 : stream aborted at client request
Would it be possible to improve the JSON parser to skip the key if the value is incorrect instead of throwing an exception? Then hopefully qemu 2.3 or higher is able to handle the data without this property, falling back to its default.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1585533/+subscriptions
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] [Bug 1585533] Re: cache-miss-rate / Invalid JSON
2016-05-25 8:46 [Qemu-devel] [Bug 1585533] [NEW] cache-miss-rate / Invalid JSON Marc Brothier
` (8 preceding siblings ...)
2016-06-07 16:02 ` Marc Brothier
@ 2019-05-27 8:37 ` Thomas Huth
2019-05-27 10:20 ` Marc Brothier
2019-07-27 4:17 ` Launchpad Bug Tracker
11 siblings, 0 replies; 13+ messages in thread
From: Thomas Huth @ 2019-05-27 8:37 UTC (permalink / raw)
To: qemu-devel
Is there still something to be done for upstream QEMU here? ...
otherwise, I assume we can close this bug now?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1585533
Title:
cache-miss-rate / Invalid JSON
Status in QEMU:
Incomplete
Bug description:
Hi,
We have VMs which were started with an older version than qemu 2.1
which added "cache-miss-rate" property for XBZRLECacheStats. While
trying to migrate the VM to a new host which is running a higher
version (2.3) of Qemu we got an exception:
virJSONValueFromString:1642 : internal error: cannot parse json {"return": {"expected-downtime": 1, "xbzrle-cache": {"bytes": 0, "cache-size": 67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0, "cache-miss": 8933}, "status": "active", "disk": {"total": 429496729600, "dirty-sync-count": 0, "remaining": 193896382464, "mbps": 0, "transferred": 235600347136, "duplicate": 0, "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 0, "normal": 0}, "setup-time": 13, "total-time": 1543124, "ram": {"total": 8599183360, "dirty-sync-count": 4, "remaining": 30695424, "mbps": 830.636997, "transferred": 3100448901, "duplicate": 1358341, "dirty-pages-rate": 7, "skipped": 0, "normal-bytes": 3082199040, "normal": 752490}}, "id": "libvirt-186200"}: lexical error: malformed number, a digit is required after the minus sign.
67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0
(right here) ------^
virNetClientStreamRaiseError:191 : stream aborted at client request
Would it be possible to improve the JSON parser to skip the key if the value is incorrect instead of throwing an exception? Then hopefully qemu 2.3 or higher is able to handle the data without this property, falling back to its default.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1585533/+subscriptions
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] [Bug 1585533] Re: cache-miss-rate / Invalid JSON
2016-05-25 8:46 [Qemu-devel] [Bug 1585533] [NEW] cache-miss-rate / Invalid JSON Marc Brothier
` (9 preceding siblings ...)
2019-05-27 8:37 ` Thomas Huth
@ 2019-05-27 10:20 ` Marc Brothier
2019-07-27 4:17 ` Launchpad Bug Tracker
11 siblings, 0 replies; 13+ messages in thread
From: Marc Brothier @ 2019-05-27 10:20 UTC (permalink / raw)
To: qemu-devel
I'm not able to test that issue anymore, you can close the ticket.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1585533
Title:
cache-miss-rate / Invalid JSON
Status in QEMU:
Incomplete
Bug description:
Hi,
We have VMs which were started with an older version than qemu 2.1
which added "cache-miss-rate" property for XBZRLECacheStats. While
trying to migrate the VM to a new host which is running a higher
version (2.3) of Qemu we got an exception:
virJSONValueFromString:1642 : internal error: cannot parse json {"return": {"expected-downtime": 1, "xbzrle-cache": {"bytes": 0, "cache-size": 67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0, "cache-miss": 8933}, "status": "active", "disk": {"total": 429496729600, "dirty-sync-count": 0, "remaining": 193896382464, "mbps": 0, "transferred": 235600347136, "duplicate": 0, "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 0, "normal": 0}, "setup-time": 13, "total-time": 1543124, "ram": {"total": 8599183360, "dirty-sync-count": 4, "remaining": 30695424, "mbps": 830.636997, "transferred": 3100448901, "duplicate": 1358341, "dirty-pages-rate": 7, "skipped": 0, "normal-bytes": 3082199040, "normal": 752490}}, "id": "libvirt-186200"}: lexical error: malformed number, a digit is required after the minus sign.
67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0
(right here) ------^
virNetClientStreamRaiseError:191 : stream aborted at client request
Would it be possible to improve the JSON parser to skip the key if the value is incorrect instead of throwing an exception? Then hopefully qemu 2.3 or higher is able to handle the data without this property, falling back to its default.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1585533/+subscriptions
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] [Bug 1585533] Re: cache-miss-rate / Invalid JSON
2016-05-25 8:46 [Qemu-devel] [Bug 1585533] [NEW] cache-miss-rate / Invalid JSON Marc Brothier
` (10 preceding siblings ...)
2019-05-27 10:20 ` Marc Brothier
@ 2019-07-27 4:17 ` Launchpad Bug Tracker
11 siblings, 0 replies; 13+ messages in thread
From: Launchpad Bug Tracker @ 2019-07-27 4:17 UTC (permalink / raw)
To: qemu-devel
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1585533
Title:
cache-miss-rate / Invalid JSON
Status in QEMU:
Expired
Bug description:
Hi,
We have VMs which were started with an older version than qemu 2.1
which added "cache-miss-rate" property for XBZRLECacheStats. While
trying to migrate the VM to a new host which is running a higher
version (2.3) of Qemu we got an exception:
virJSONValueFromString:1642 : internal error: cannot parse json {"return": {"expected-downtime": 1, "xbzrle-cache": {"bytes": 0, "cache-size": 67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0, "cache-miss": 8933}, "status": "active", "disk": {"total": 429496729600, "dirty-sync-count": 0, "remaining": 193896382464, "mbps": 0, "transferred": 235600347136, "duplicate": 0, "dirty-pages-rate": 0, "skipped": 0, "normal-bytes": 0, "normal": 0}, "setup-time": 13, "total-time": 1543124, "ram": {"total": 8599183360, "dirty-sync-count": 4, "remaining": 30695424, "mbps": 830.636997, "transferred": 3100448901, "duplicate": 1358341, "dirty-pages-rate": 7, "skipped": 0, "normal-bytes": 3082199040, "normal": 752490}}, "id": "libvirt-186200"}: lexical error: malformed number, a digit is required after the minus sign.
67108864, "cache-miss-rate": -nan, "pages": 0, "overflow": 0
(right here) ------^
virNetClientStreamRaiseError:191 : stream aborted at client request
Would it be possible to improve the JSON parser to skip the key if the value is incorrect instead of throwing an exception? Then hopefully qemu 2.3 or higher is able to handle the data without this property, falling back to its default.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1585533/+subscriptions
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2019-07-27 4:31 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-25 8:46 [Qemu-devel] [Bug 1585533] [NEW] cache-miss-rate / Invalid JSON Marc Brothier
2016-05-25 8:50 ` [Qemu-devel] [Bug 1585533] " Marc Brothier
2016-05-25 11:10 ` [Qemu-devel] [Bug 1585533] [NEW] " Eric Blake
2016-05-25 11:45 ` [Qemu-devel] [Bug 1585533] " Marc Brothier
2016-05-25 11:50 ` Marc Brothier
2016-05-25 12:49 ` Paolo Bonzini
2016-05-26 13:05 ` Marc Brothier
2016-05-31 6:10 ` Marc Brothier
2016-06-01 14:12 ` Marc Brothier
2016-06-07 16:02 ` Marc Brothier
2019-05-27 8:37 ` Thomas Huth
2019-05-27 10:20 ` Marc Brothier
2019-07-27 4:17 ` Launchpad Bug Tracker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.