From: Christoph Hellwig <hch@lst.de>
To: Tom Haynes <thomas.haynes@primarydata.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
Linux NFS Mailing list <linux-nfs@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/4] nfsd: flex file device id encoding will need the server addres
Date: Wed, 25 May 2016 17:08:39 +0200 [thread overview]
Message-ID: <20160525150839.GB27535@lst.de> (raw)
In-Reply-To: <1464152979-103988-2-git-send-email-loghyr@primarydata.com>
> diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
> index de1ff1d..b28e45b 100644
> --- a/fs/nfsd/nfs4proc.c
> +++ b/fs/nfsd/nfs4proc.c
> @@ -1270,6 +1270,7 @@ nfsd4_getdeviceinfo(struct svc_rqst *rqstp,
> nfserr = nfs_ok;
> if (gdp->gd_maxcount != 0) {
> nfserr = ops->proc_getdeviceinfo(exp->ex_path.mnt->mnt_sb,
> + rqstp,
> cstate->session->se_client, gdp);
Can you reindent the code so that the cstate->session->se_client argument
goes onto the same line as rqstp?
Otherwise this looks fine to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2016-05-25 15:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 5:09 [PATCH 0/4] Super simple flex file server Tom Haynes
2016-05-25 5:09 ` [PATCH 1/4] nfsd: flex file device id encoding will need the server addres Tom Haynes
2016-05-25 11:49 ` Jeff Layton
2016-05-25 15:08 ` Christoph Hellwig [this message]
2016-05-25 5:09 ` [PATCH 2/4] nfsd: Can leak pnfs_block_extent on error Tom Haynes
2016-05-25 11:50 ` Jeff Layton
2016-05-25 15:07 ` Christoph Hellwig
2016-05-25 18:12 ` Thomas Haynes
2016-05-25 18:20 ` J. Bruce Fields
2016-05-25 5:09 ` [PATCH 3/4] nfsd: Add a super simple flex file server Tom Haynes
2016-05-25 12:00 ` Jeff Layton
2016-05-25 12:30 ` Jeff Layton
2016-05-25 14:41 ` Thomas Haynes
2016-05-25 17:42 ` J. Bruce Fields
2016-05-25 21:57 ` Jeff Layton
2016-05-26 13:18 ` J. Bruce Fields
2016-05-25 15:15 ` Christoph Hellwig
2016-05-26 5:37 ` Thomas Haynes
2016-05-25 5:09 ` [PATCH 4/4] nfsd: Provide a config option for flex file layouts Tom Haynes
2016-05-25 15:09 ` Christoph Hellwig
2016-05-25 18:19 ` Thomas Haynes
2016-05-25 18:21 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160525150839.GB27535@lst.de \
--to=hch@lst.de \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=thomas.haynes@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.