All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Eric Wong <e@80x24.org>
Cc: Lars Schneider <larsxschneider@gmail.com>,
	Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org, Luke Diamand <luke@diamand.org>
Subject: Re: [BUG] t9801 and t9803 broken on next
Date: Wed, 25 May 2016 17:56:25 -0500	[thread overview]
Message-ID: <20160525225625.GA2634@sigill.intra.peff.net> (raw)
In-Reply-To: <20160525224907.GA18894@dcvr.yhbt.net>

On Wed, May 25, 2016 at 10:49:07PM +0000, Eric Wong wrote:

> > Thanks for the analysis. I think this is definitely the problem.  After
> > fast-import finalizes a packfile (either at the end of the program or
> > due to a checkpoint), it never discards its internal mapping of objects
> > to pack locations. It _has_ to keep such a mapping before the pack is
> > finalized, because git's regular object database doesn't know about it.
> > But afterwards, it should be able to rely on the object database.
> 
> Almost; but relying on marks is a problem since that set can contain
> mark => object_entry mappings which the normal object database won't
> know about.

Ah, thanks for finding that. I had a feeling there might be other users
of the object_entry structs, but I didn't dig.

Given that and your other responses here, I agree that just invalidating
the pack_id is probably the most sensible route.

-Peff

  parent reply	other threads:[~2016-05-25 22:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-13 10:02 [BUG] t9801 and t9803 broken on next Lars Schneider
2016-05-13 10:36 ` Eric Wong
2016-05-13 16:37   ` Junio C Hamano
2016-05-14  8:04     ` Lars Schneider
2016-05-14 18:15       ` Junio C Hamano
2016-05-17  8:07         ` Lars Schneider
2016-05-17  9:13           ` Eric Wong
2016-05-17 12:13           ` Jeff King
2016-05-19  8:19             ` Lars Schneider
2016-05-19 17:03               ` Junio C Hamano
2016-05-19 17:32                 ` Lars Schneider
2016-05-25 22:49             ` Eric Wong
2016-05-25 22:54               ` [RFC] fast-import: invalidate pack_id references after loosening Eric Wong
2016-05-25 23:09                 ` Jeff King
2016-05-26  8:02                   ` Eric Wong
2016-05-26 14:16                     ` Jeff King
2016-05-28  0:20                       ` Eric Wong
2016-05-25 22:56               ` Jeff King [this message]
2016-05-17  8:35         ` [BUG] t9801 and t9803 broken on next Luke Diamand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160525225625.GA2634@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=e@80x24.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=larsxschneider@gmail.com \
    --cc=luke@diamand.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.