From: Chris Wilson <chris@chris-wilson.co.uk>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [PATCH v2 2/6] drm/i915: Move legacy kernel context pinning to intel_ringbuffer.c
Date: Thu, 26 May 2016 11:29:13 +0100 [thread overview]
Message-ID: <20160526102913.GR15901@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <1464258124.15523.2.camel@linux.intel.com>
On Thu, May 26, 2016 at 01:22:04PM +0300, Joonas Lahtinen wrote:
> > @@ -2327,6 +2350,14 @@ void intel_cleanup_engine(struct intel_engine_cs *engine)
> >
> > i915_cmd_parser_fini_ring(engine);
> > i915_gem_batch_pool_fini(&engine->batch_pool);
> > +
> > + kctx = dev_priv->kernel_context;
> > + ce = &kctx->engine[engine->id];
>
> I'd move these two upper in the function.
We can't just yet, because it is silly and has a dev_priv == NULL check.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-05-26 10:29 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 11:48 Bug 95634, avoid fresh work on shutdown Chris Wilson
2016-05-25 11:48 ` [PATCH 1/6] drm/i915: Skip idling an idle engine Chris Wilson
2016-05-25 11:48 ` [PATCH 2/6] drm/i915: Treat kernel context as initialised Chris Wilson
2016-05-25 12:38 ` Joonas Lahtinen
2016-05-25 12:58 ` Chris Wilson
2016-05-25 12:42 ` Chris Wilson
2016-05-25 14:16 ` Mika Kuoppala
2016-05-25 14:38 ` Chris Wilson
2016-05-25 14:58 ` [PATCH] drm/i915: Defer enabling rc6 til after we submit the first batch/context Chris Wilson
2016-05-25 15:33 ` Chris Wilson
2016-05-25 17:07 ` Chris Wilson
2016-05-25 11:48 ` [PATCH 3/6] drm/i915: Mark all default contexts as uninitialised after context loss Chris Wilson
2016-05-25 12:43 ` Joonas Lahtinen
2016-05-25 11:48 ` [PATCH 4/6] drm/i915: No need to wait for idle on L3 remap Chris Wilson
2016-05-25 14:27 ` Mika Kuoppala
2016-05-25 11:48 ` [PATCH 5/6] drm/i915: Split idling from forcing context switch Chris Wilson
2016-05-25 12:57 ` Joonas Lahtinen
2016-05-25 13:12 ` Chris Wilson
2016-05-25 11:48 ` [PATCH 6/6] drm/i915: Only switch to default context when evicting from GGTT Chris Wilson
2016-05-25 12:09 ` ✗ Ro.CI.BAT: failure for series starting with [1/6] drm/i915: Skip idling an idle engine Patchwork
2016-05-25 14:04 ` [PATCH v2 1/6] " Chris Wilson
2016-05-25 14:04 ` [PATCH v2 2/6] drm/i915: Move legacy kernel context pinning to intel_ringbuffer.c Chris Wilson
2016-05-26 10:22 ` Joonas Lahtinen
2016-05-26 10:29 ` Chris Wilson [this message]
2016-05-26 11:18 ` [PATCH] " Chris Wilson
2016-05-26 11:30 ` Joonas Lahtinen
2016-05-26 12:52 ` Mika Kuoppala
2016-05-25 14:04 ` [PATCH v2 3/6] drm/i915: Treat kernel context as initialised Chris Wilson
2016-05-25 14:04 ` [PATCH v2 4/6] drm/i915: Mark all default contexts as uninitialised after context loss Chris Wilson
2016-05-25 14:04 ` [PATCH v2 5/6] drm/i915: No need to wait for idle on L3 remap Chris Wilson
2016-05-25 14:04 ` [PATCH v2 6/6] drm/i915: Split idling from forcing context switch Chris Wilson
2016-05-25 14:59 ` ✗ Ro.CI.BAT: failure for series starting with [1/6] drm/i915: Skip idling an idle engine (rev6) Patchwork
2016-05-25 15:00 ` ✗ Ro.CI.BAT: failure for series starting with [1/6] drm/i915: Skip idling an idle engine (rev7) Patchwork
2016-05-26 5:00 ` ✗ Ro.CI.BAT: failure for series starting with [1/6] drm/i915: Skip idling an idle engine (rev8) Patchwork
2016-05-26 11:20 ` ✗ Ro.CI.BAT: failure for series starting with [1/6] drm/i915: Skip idling an idle engine (rev9) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160526102913.GR15901@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=mika.kuoppala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.