From: Jeff King <peff@peff.net>
To: David Aguilar <davvid@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Armin Kunaschik <megabreit@googlemail.com>,
Git List <git@vger.kernel.org>
Subject: Re: t7610-mergetool.sh test failure
Date: Fri, 27 May 2016 01:00:54 -0400 [thread overview]
Message-ID: <20160527050054.GA25774@sigill.intra.peff.net> (raw)
In-Reply-To: <20160527044027.GA26143@gmail.com>
On Thu, May 26, 2016 at 09:40:27PM -0700, David Aguilar wrote:
> > BTW, one thing I happened to note while looking at this: running the
> > test script will write into /tmp (or wherever your $TMPDIR points).
> > Probably not a big deal, but I wonder if we should be setting $TMPDIR in
> > our test harness.
>
> We already set $HOME and various other variables to carefully
> tune the testsuite's behavior, so this sounds like a good idea
> IMO.
>
> Would there be any downsides to setting $TMPDIR equal to the
> trash directory?
The only one I can think of is that if something leaves cruft in
$TMPDIR, it could affect later tests that want to `git add`
indiscriminately. It seems unlikely.
OTOH, I do not think putting things in /tmp is hurting anything. I was
mostly just surprised by it.
-Peff
next prev parent reply other threads:[~2016-05-27 5:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 16:44 t7610-mergetool.sh test failure Armin Kunaschik
2016-05-24 16:45 ` Junio C Hamano
2016-05-24 16:53 ` Armin Kunaschik
2016-05-25 23:16 ` Jeff King
2016-05-26 1:51 ` Jeff King
2016-05-27 4:40 ` David Aguilar
2016-05-27 5:00 ` Jeff King [this message]
2016-05-27 6:33 ` Junio C Hamano
2016-05-27 18:24 ` Jeff King
2016-05-27 19:58 ` Junio C Hamano
2016-05-27 20:01 ` Jeff King
2016-06-22 16:53 ` Armin Kunaschik
2016-06-22 17:12 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160527050054.GA25774@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=megabreit@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.