From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Haozhong Zhang <haozhong.zhang@intel.com>,
Wei Liu <wei.liu2@citrix.com>,
pengtaox.zhang@intel.com,
Liu Jinsong <jinsong.liu@alibaba-inc.com>,
Christoph Egger <chegger@amazon.de>,
xudong.hao@intel.com, xen-devel@lists.xen.org,
AndrewCooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v3] x86/mce: handle reserved domain ID in XEN_MC_msrinject
Date: Fri, 27 May 2016 17:16:15 +0100 [thread overview]
Message-ID: <20160527161615.GN22076@citrix.com> (raw)
In-Reply-To: <20160527161408.GM22076@citrix.com>
On Fri, May 27, 2016 at 05:14:08PM +0100, Wei Liu wrote:
> On Fri, May 27, 2016 at 10:06:31AM -0600, Jan Beulich wrote:
> > >>> On 27.05.16 at 17:31, <wei.liu2@citrix.com> wrote:
> > > On Fri, May 27, 2016 at 03:06:08PM +0100, Wei Liu wrote:
> > >> On Fri, May 27, 2016 at 08:03:42AM -0600, Jan Beulich wrote:
> > >> > >>> On 27.05.16 at 15:30, <haozhong.zhang@intel.com> wrote:
> > >> > > Commit 26646f3 "x86/mce: translate passed-in GPA to host machine
> > >> > > address" and commit 4ddf474 "tools/xen-mceinj: Pass in GPA when
> > >> > > injecting through MSR_MCI_ADDR" forgot to consider reserved domain
> > >> > > ID and mistakenly add MC_MSRINJ_F_GPADDR flag for them, which in turn
> > >> > > causes bug reported by
> > >> > > http://lists.xenproject.org/archives/html/xen-devel/2016-05/msg02640.html.
> > >> > >
> > >> > > This patch removes MC_MSRINK_F_GPADDR flag and checks this when injecting
> > >> > > to reserved domain IDs except DOMID_SELF, and treats the passed-in
> > >> > > address as host machine address.
> > >> > >
> > >> > > Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com>
> > >> >
> > >> > Reviewed-by: Jan Beulich <jbeulich@suse.com>
> > >> >
> > >>
> > >> Release-acked-by: Wei Liu <wei.liu2@citrix.com>
> > >
> > > And queued.
> >
> > Please wait for a maintainer ack.
> >
>
> $ ./scripts/get_maintainer.pl -f xen/arch/x86/cpu/mcheck/mce.c
> Christoph Egger <chegger@amazon.de>
> Liu Jinsong <jinsong.liu@alibaba-inc.com>
> Jan Beulich <jbeulich@suse.com>
> Andrew Cooper <andrew.cooper3@citrix.com>
> xen-devel@lists.xen.org
>
OK, so looking at MAINTAINERS file:
MACHINE CHECK (MCA) & RAS
M: Christoph Egger <chegger@amazon.de>
M: Liu Jinsong <jinsong.liu@alibaba-inc.com>
S: Supported
F: xen/arch/x86/cpu/mcheck/
I will revert this patch now. Sorry for all the trouble!
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-27 16:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 13:30 [PATCH v3] x86/mce: handle reserved domain ID in XEN_MC_msrinject Haozhong Zhang
2016-05-27 14:03 ` Jan Beulich
2016-05-27 14:06 ` Wei Liu
2016-05-27 15:31 ` Wei Liu
2016-05-27 16:06 ` Jan Beulich
2016-05-27 16:14 ` Wei Liu
2016-05-27 16:16 ` Wei Liu [this message]
2016-06-01 6:38 ` Haozhong Zhang
2016-06-06 13:08 ` Wei Liu
2016-06-06 13:40 ` Egger, Christoph
2016-06-06 13:47 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160527161615.GN22076@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=chegger@amazon.de \
--cc=haozhong.zhang@intel.com \
--cc=jinsong.liu@alibaba-inc.com \
--cc=pengtaox.zhang@intel.com \
--cc=xen-devel@lists.xen.org \
--cc=xudong.hao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.