* [PATCH e2fsprogs] Apply LDFLAGS when building tests in lib/e2p
@ 2016-05-06 23:40 Filipe Brandenburger
2016-05-26 17:47 ` Filipe Brandenburger
0 siblings, 1 reply; 3+ messages in thread
From: Filipe Brandenburger @ 2016-05-06 23:40 UTC (permalink / raw)
To: Theodore Ts'o
Cc: linux-ext4, Eric Christopher, Michael Forney, Filipe Brandenburger
This was previously addressed by Michael Forney on commit 53904ae543591a
but it seems the test cases from lib/e2p (tst_ostype and tst_feature)
were missed.
Fix them by adding the same $(ALL_LDFLAGS) to those two targets.
Tested by building it on a system that depends on LDFLAGS to produce
working binaries and confirming that `make check` succeeds.
Reported-by: Eric Christopher <echristo@google.com>
Signed-off-by: Filipe Brandenburger <filbranden@google.com>
---
lib/e2p/Makefile.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/e2p/Makefile.in b/lib/e2p/Makefile.in
index 83f04ff5c04e..d109bf190051 100644
--- a/lib/e2p/Makefile.in
+++ b/lib/e2p/Makefile.in
@@ -68,12 +68,12 @@ e2p.pc: $(srcdir)/e2p.pc.in $(top_builddir)/config.status
tst_ostype: $(srcdir)/ostype.c
$(E) " LD $@"
$(Q) $(CC) -DTEST_PROGRAM -I$(top_srcdir)/lib -o tst_ostype \
- $(srcdir)/ostype.c $(ALL_CFLAGS)
+ $(srcdir)/ostype.c $(ALL_CFLAGS) $(ALL_LDFLAGS)
tst_feature: $(srcdir)/feature.c
$(E) " LD $@"
$(Q) $(CC) -DTEST_PROGRAM -I$(top_srcdir)/lib -o tst_feature \
- $(srcdir)/feature.c $(ALL_CFLAGS)
+ $(srcdir)/feature.c $(ALL_CFLAGS) $(ALL_LDFLAGS)
check:: tst_ostype tst_feature
./tst_ostype
--
2.8.0.rc3.226.g39d4020
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH e2fsprogs] Apply LDFLAGS when building tests in lib/e2p
2016-05-06 23:40 [PATCH e2fsprogs] Apply LDFLAGS when building tests in lib/e2p Filipe Brandenburger
@ 2016-05-26 17:47 ` Filipe Brandenburger
2016-05-28 23:34 ` Theodore Ts'o
0 siblings, 1 reply; 3+ messages in thread
From: Filipe Brandenburger @ 2016-05-26 17:47 UTC (permalink / raw)
To: Theodore Ts'o
Cc: linux-ext4, Eric Christopher, Michael Forney, Filipe Brandenburger
Hi Ted,
Can you please include this patch in upstream e2fsprogs git repo?
This is a complement for 53904ae543591a which added LDFLAGS to the
test cases but seemed to miss these two...
Thank you!
Filipe
On Fri, May 6, 2016 at 4:40 PM, Filipe Brandenburger
<filbranden@google.com> wrote:
> This was previously addressed by Michael Forney on commit 53904ae543591a
> but it seems the test cases from lib/e2p (tst_ostype and tst_feature)
> were missed.
>
> Fix them by adding the same $(ALL_LDFLAGS) to those two targets.
>
> Tested by building it on a system that depends on LDFLAGS to produce
> working binaries and confirming that `make check` succeeds.
>
> Reported-by: Eric Christopher <echristo@google.com>
> Signed-off-by: Filipe Brandenburger <filbranden@google.com>
> ---
> lib/e2p/Makefile.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/e2p/Makefile.in b/lib/e2p/Makefile.in
> index 83f04ff5c04e..d109bf190051 100644
> --- a/lib/e2p/Makefile.in
> +++ b/lib/e2p/Makefile.in
> @@ -68,12 +68,12 @@ e2p.pc: $(srcdir)/e2p.pc.in $(top_builddir)/config.status
> tst_ostype: $(srcdir)/ostype.c
> $(E) " LD $@"
> $(Q) $(CC) -DTEST_PROGRAM -I$(top_srcdir)/lib -o tst_ostype \
> - $(srcdir)/ostype.c $(ALL_CFLAGS)
> + $(srcdir)/ostype.c $(ALL_CFLAGS) $(ALL_LDFLAGS)
>
> tst_feature: $(srcdir)/feature.c
> $(E) " LD $@"
> $(Q) $(CC) -DTEST_PROGRAM -I$(top_srcdir)/lib -o tst_feature \
> - $(srcdir)/feature.c $(ALL_CFLAGS)
> + $(srcdir)/feature.c $(ALL_CFLAGS) $(ALL_LDFLAGS)
>
> check:: tst_ostype tst_feature
> ./tst_ostype
> --
> 2.8.0.rc3.226.g39d4020
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH e2fsprogs] Apply LDFLAGS when building tests in lib/e2p
2016-05-26 17:47 ` Filipe Brandenburger
@ 2016-05-28 23:34 ` Theodore Ts'o
0 siblings, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2016-05-28 23:34 UTC (permalink / raw)
To: Filipe Brandenburger; +Cc: linux-ext4, Eric Christopher, Michael Forney
On Thu, May 26, 2016 at 10:47:54AM -0700, Filipe Brandenburger wrote:
> Hi Ted,
>
> Can you please include this patch in upstream e2fsprogs git repo?
>
> This is a complement for 53904ae543591a which added LDFLAGS to the
> test cases but seemed to miss these two...
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-28 23:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-06 23:40 [PATCH e2fsprogs] Apply LDFLAGS when building tests in lib/e2p Filipe Brandenburger
2016-05-26 17:47 ` Filipe Brandenburger
2016-05-28 23:34 ` Theodore Ts'o
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.