From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161666AbcE3QbA (ORCPT ); Mon, 30 May 2016 12:31:00 -0400 Received: from mail.kernel.org ([198.145.29.136]:33166 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161220AbcE3Qa7 (ORCPT ); Mon, 30 May 2016 12:30:59 -0400 Date: Mon, 30 May 2016 13:30:53 -0300 From: Arnaldo Carvalho de Melo To: Arnaldo Carvalho de Melo Cc: Masami Hiramatsu , linux-kernel@vger.kernel.org, Namhyung Kim , Peter Zijlstra , Ingo Molnar , Hemant Kumar , Ananth N Mavinakayanahalli , Brendan Gregg Subject: Re: [PATCH perf/core v9 00/16] perf-probe --cache and SDT support Message-ID: <20160530163053.GA2563@kernel.org> References: <20160528151456.16098.90001.stgit@devbox> <20160530162252.GE11853@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160530162252.GE11853@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, May 30, 2016 at 01:22:52PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Sun, May 29, 2016 at 12:15:01AM +0900, Masami Hiramatsu escreveu: > > Hi, > > > > Here is the 9th version of the patchset for probe-cache and > > initial SDT support. > > Ok, for completeness sake: Where does one learn more about "SDT", I > couldn't find a description of this in this patchkit, /me goes googling > around... https://sourceware.org/gdb/onlinedocs/gdb/Static-Probe-Points.html Some lifting of this text, giving credit and checking whatever license it is under would help, I think. Mentioning some userland components that have such "Statically Defined Tracing" markers would also help testers to try it with this patchkit, I saw just one or two examples here, IIRC with libc and libstdc++. - Arnaldo > - Arnaldo > > > The previous version is here; https://lkml.org/lkml/2016/5/14/107 > > > > This version just fixes 2 points according to Hemant's comment, > > and split out the filename__readable() patch. > > > > Changes in v9: > > - [1/16,2/16] split out the filename__readable() > > - [7/16] Fix to show which event is deleted. > > - [12/16] Update list_usage to show sdt option. > > > > Thank you, > > > > --- > > > > Hemant Kumar (1): > > perf/sdt: ELF support for SDT > > > > Masami Hiramatsu (15): > > perf-symbol: Introduce filename__readable to check readability > > perf symbol: Cleanup the code flow of dso__find_kallsyms > > perf-buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid > > perf probe: Add --cache option to cache the probe definitions > > perf probe: Use cache entry if possible > > perf probe: Show all cached probes > > perf probe: Remove caches when --cache is given > > perf probe: Add group name support > > perf buildid-cache: Scan and import user SDT events to probe cache > > perf probe: Accept %sdt and %cached event name > > perf-list: Show SDT and pre-cached events > > perf-list: Skip SDTs placed in invalid binaries > > perf probe: Allow wildcard for cached events > > perf probe: Support @BUILDID or @FILE suffix for SDT events > > perf probe: Support a special SDT probe format > > > > > > tools/perf/Documentation/perf-probe.txt | 26 +- > > tools/perf/builtin-list.c | 6 > > tools/perf/builtin-probe.c | 30 ++ > > tools/perf/util/build-id.c | 295 ++++++++++++++++-- > > tools/perf/util/build-id.h | 8 > > tools/perf/util/dso.h | 5 > > tools/perf/util/parse-events.c | 83 +++++ > > tools/perf/util/parse-events.h | 2 > > tools/perf/util/probe-event.c | 492 +++++++++++++++++++++++++++--- > > tools/perf/util/probe-event.h | 7 > > tools/perf/util/probe-file.c | 504 +++++++++++++++++++++++++++++++ > > tools/perf/util/probe-file.h | 41 +++ > > tools/perf/util/symbol-elf.c | 252 ++++++++++++++++ > > tools/perf/util/symbol.c | 71 ++-- > > tools/perf/util/symbol.h | 22 + > > 15 files changed, 1712 insertions(+), 132 deletions(-) > > > > -- > > Masami Hiramatsu