From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40216)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1b7Rhn-0006P6-Nd
	for qemu-devel@nongnu.org; Mon, 30 May 2016 14:14:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1b7Rhj-00036g-8W
	for qemu-devel@nongnu.org; Mon, 30 May 2016 14:14:22 -0400
Date: Mon, 30 May 2016 11:14:16 -0700
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20160530181416.GB1366@stefanha-x1.localdomain>
References: <1463729780-31982-1-git-send-email-xiecl.fnst@cn.fujitsu.com>
	<1463729780-31982-9-git-send-email-xiecl.fnst@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="oC1+HKm2/end4ao3"
Content-Disposition: inline
In-Reply-To: <1463729780-31982-9-git-send-email-xiecl.fnst@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v19 08/10] Implement new
 driver for block replication
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
Cc: qemu devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <famz@redhat.com>, Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>, Wen Congyang <wency@cn.fujitsu.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu block <qemu-block@nongnu.org>, Jiang Yunhong <yunhong.jiang@intel.com>, Dong Eddie <eddie.dong@intel.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Markus Armbruster <armbru@redhat.com>, Gonglei <arei.gonglei@huawei.com>, Paolo Bonzini <pbonzini@redhat.com>


--oC1+HKm2/end4ao3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, May 20, 2016 at 03:36:18PM +0800, Changlong Xie wrote:
> +        /* start backup job now */
> +        error_setg(&s->blocker,
> +                   "block device is in use by internal backup job");
> +
> +        top_bs = bdrv_lookup_bs(s->top_id, s->top_id, errp);
> +        if (!top_bs || !check_top_bs(top_bs, bs)) {
> +            reopen_backing_file(s, false, NULL);
> +            aio_context_release(aio_context);
> +            return;
> +        }

Missing error_setg() with an error message when check_top_bs() fails.

--oC1+HKm2/end4ao3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJXTIL4AAoJEJykq7OBq3PIZl0H/jqQgKZv1RWCl3HQqA4kx4Dn
9m9+X0r03I9GaSWEJFiO8+jkkJ0b0C1w7hWPikz8d8VeMIYj+k2f4T3/9wprPpHA
Wm/I/nUKWGmw7z8Xh+/XVn74PEJ75q2reXskvp6U41LvJr++VqNL6lDnKzMzQy1B
uQ3KzPwZ+H2bxTDvpnE2LNdUaBMejMEME9a2EEgl0N+UW55j/zWoFreQwnUEheo9
4dYtmHTHHg66ffisE1tV8+IkzNPsozcHi6kVZqE9lwz6XV2ws8A51Z1YZBklO0Ga
HW/JibwmU0pQmHLSiL4DC4zcK1J8MkE0LPjM1XX02Eux9GhQFoEuRGYswcuXT7A=
=qB6e
-----END PGP SIGNATURE-----

--oC1+HKm2/end4ao3--