From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757062AbcEaJ3N (ORCPT ); Tue, 31 May 2016 05:29:13 -0400 Received: from mga03.intel.com ([134.134.136.65]:39370 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756904AbcEaJ3K (ORCPT ); Tue, 31 May 2016 05:29:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,395,1459839600"; d="scan'208";a="977763103" Date: Tue, 31 May 2016 09:31:32 +0800 From: Yuyang Du To: Peter Zijlstra Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, umgwanakikbuti@gmail.com, bsegall@google.com, pjt@google.com, morten.rasmussen@arm.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com Subject: Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched domain build-up Message-ID: <20160531013132.GQ18670@intel.com> References: <1464657098-24880-1-git-send-email-yuyang.du@intel.com> <1464657098-24880-2-git-send-email-yuyang.du@intel.com> <20160531092146.GT3192@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160531092146.GT3192@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 31, 2016 at 11:21:46AM +0200, Peter Zijlstra wrote: > On Tue, May 31, 2016 at 09:11:37AM +0800, Yuyang Du wrote: > > The SD_BALANCE_WAKE is irrelevant in the contexts of these two removals, > > and in addition SD_BALANCE_WAKE is not and should not be set in any > > sched_domain flags so far. > > This Changelog doesn't make any sense... How? SD_BALANCE_WAKE is not in any sched_domain flags (sd->flags), even if it is, it is not used anywhere, no? > > Signed-off-by: Yuyang Du > > --- > > kernel/sched/core.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > > index 7f2cae4..e00b8ea 100644 > > --- a/kernel/sched/core.c > > +++ b/kernel/sched/core.c > > @@ -6229,10 +6229,10 @@ static void set_domain_attribute(struct sched_domain *sd, > > request = attr->relax_domain_level; > > if (request < sd->level) { > > /* turn off idle balance on this domain */ > > - sd->flags &= ~(SD_BALANCE_WAKE|SD_BALANCE_NEWIDLE); > > + sd->flags &= ~(SD_BALANCE_NEWIDLE); > > } else { > > /* turn on idle balance on this domain */ > > - sd->flags |= (SD_BALANCE_WAKE|SD_BALANCE_NEWIDLE); > > + sd->flags |= (SD_BALANCE_NEWIDLE); > > } > > } > > > > -- > > 1.7.9.5 > >