From: Viresh Kumar <viresh.kumar@linaro.org>
To: Steve Muckle <steve.muckle@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Juri Lelli <Juri.Lelli@arm.com>,
Patrick Bellasi <patrick.bellasi@arm.com>,
Michael Turquette <mturquette@baylibre.com>
Subject: Re: [PATCH v2 1/3] cpufreq: add resolve_freq driver callback
Date: Tue, 31 May 2016 16:44:51 +0530 [thread overview]
Message-ID: <20160531111451.GF9463@vireshk-i7> (raw)
In-Reply-To: <1464231181-30741-2-git-send-email-smuckle@linaro.org>
On 25-05-16, 19:52, Steve Muckle wrote:
> +unsigned int cpufreq_driver_resolve_freq(struct cpufreq_policy *policy,
> + unsigned int target_freq)
> +{
> + struct cpufreq_frequency_table *freq_table;
> + int index, retval;
> +
> + clamp_val(target_freq, policy->min, policy->max);
Rafael will kill me for this, as I have fallen into the same trap and
copied your *incorrect* code :(
This is a useless statement unless you do:
target_freq = clamp_val(target_freq, policy->min, policy->max);
--
viresh
next prev parent reply other threads:[~2016-05-31 11:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 2:52 [PATCH v2 0/3] cpufreq: avoid redundant driver calls in schedutil Steve Muckle
2016-05-26 2:52 ` [PATCH v2 1/3] cpufreq: add resolve_freq driver callback Steve Muckle
2016-05-26 6:25 ` Viresh Kumar
2016-05-30 15:31 ` Steve Muckle
2016-05-31 5:30 ` Viresh Kumar
2016-05-31 18:48 ` Steve Muckle
2016-05-31 11:14 ` Viresh Kumar [this message]
2016-05-31 18:12 ` Steve Muckle
2016-05-26 2:53 ` [PATCH v2 2/3] cpufreq: acpi-cpufreq: add resolve_freq callback Steve Muckle
2016-05-26 6:43 ` Viresh Kumar
2016-05-30 16:20 ` Steve Muckle
2016-05-31 11:38 ` Viresh Kumar
2016-05-26 2:53 ` [PATCH v2 3/3] cpufreq: schedutil: map raw required frequency to driver frequency Steve Muckle
2016-05-26 7:16 ` Viresh Kumar
2016-05-29 0:40 ` Rafael J. Wysocki
2016-05-30 10:18 ` Viresh Kumar
2016-05-30 14:25 ` Rafael J. Wysocki
2016-05-30 15:32 ` Viresh Kumar
2016-05-30 19:08 ` Rafael J. Wysocki
2016-05-31 9:02 ` Peter Zijlstra
2016-05-31 1:49 ` Wanpeng Li
2016-05-30 16:35 ` Steve Muckle
2016-06-01 10:50 ` Viresh Kumar
2016-05-27 5:41 ` Wanpeng Li
2016-05-30 16:48 ` Steve Muckle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531111451.GF9463@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=Juri.Lelli@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=mturquette@baylibre.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=steve.muckle@linaro.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.