From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161895AbcEaFyu (ORCPT ); Tue, 31 May 2016 01:54:50 -0400 Received: from mail.kernel.org ([198.145.29.136]:37883 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751283AbcEaFyp (ORCPT ); Tue, 31 May 2016 01:54:45 -0400 Date: Tue, 31 May 2016 14:54:40 +0900 From: Masami Hiramatsu To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Namhyung Kim , Peter Zijlstra , Ingo Molnar , Hemant Kumar , Ananth N Mavinakayanahalli , Brendan Gregg Subject: Re: [PATCH perf/core v9 01/16] perf-symbol: Introduce filename__readable to check readability Message-Id: <20160531145440.70aebd1e8a2529f742978a6b@kernel.org> In-Reply-To: <20160530160447.GB11853@kernel.org> References: <20160528151456.16098.90001.stgit@devbox> <20160528151513.16098.97576.stgit@devbox> <20160530160317.GA11853@kernel.org> <20160530160447.GB11853@kernel.org> X-Mailer: Sylpheed 3.4.3 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 May 2016 13:04:47 -0300 Arnaldo Carvalho de Melo wrote: > Em Mon, May 30, 2016 at 01:03:17PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Sun, May 29, 2016 at 12:15:13AM +0900, Masami Hiramatsu escreveu: > > > Introduce filename__readable to check readability by opening > > > the file directly. Since the access(R_OK) just checks the > > > readability based on real UID/GID, it is ignored that the > > > effective UID/GID and capabilities for some special file (e.g. > > > /proc/kcore). > > > filename__readable() directly opens given file with O_RDONLY > > > so that the kernel checks it by effective UID/GID and capabilities. > > > > > > You missed the Signed-off-by line. > > This this for you this time, no need to resend. Oops, and thanks!! > > - Arnaldo -- Masami Hiramatsu