From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7mk0-0001gg-45 for qemu-devel@nongnu.org; Tue, 31 May 2016 12:42:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7mjw-0004UY-AQ for qemu-devel@nongnu.org; Tue, 31 May 2016 12:42:03 -0400 Date: Tue, 31 May 2016 18:41:48 +0200 From: Samuel Thibault Message-ID: <20160531164148.GO10830@var.bordeaux.inria.fr> References: <1464712565-14857-1-git-send-email-lvivier@redhat.com> <1464712565-14857-13-git-send-email-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464712565-14857-13-git-send-email-lvivier@redhat.com> Subject: Re: [Qemu-devel] [PATCH 12/16] slirp: Use DIV_ROUND_UP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Laurent Vivier, on Tue 31 May 2016 18:36:01 +0200, wrote: > Replace (((n) + (d) - 1) /(d)) by DIV_ROUND_UP(n,d). > > This patch is the result of coccinelle script > scripts/coccinelle/round.cocci > > Signed-off-by: Laurent Vivier Acked-by: Samuel Thibault > --- > slirp/dnssearch.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/slirp/dnssearch.c b/slirp/dnssearch.c > index aed2f13..9b16757 100644 > --- a/slirp/dnssearch.c > +++ b/slirp/dnssearch.c > @@ -262,7 +262,7 @@ int translate_dnssearch(Slirp *s, const char **names) > } > > /* reserve extra 2 header bytes for each 255 bytes of output */ > - memreq += ((memreq + MAX_OPT_LEN - 1) / MAX_OPT_LEN) * OPT_HEADER_LEN; > + memreq += DIV_ROUND_UP(memreq, MAX_OPT_LEN) * OPT_HEADER_LEN; > result = g_malloc(memreq * sizeof(*result)); > > outptr = result; > @@ -289,7 +289,7 @@ int translate_dnssearch(Slirp *s, const char **names) > domain_mkxrefs(domains, domains + num_domains - 1, 0); > memreq = domain_compactify(domains, num_domains); > > - blocks = (memreq + MAX_OPT_LEN - 1) / MAX_OPT_LEN; > + blocks = DIV_ROUND_UP(memreq, MAX_OPT_LEN); > bsrc_end = memreq; > bsrc_start = (blocks - 1) * MAX_OPT_LEN; > bdst_start = bsrc_start + blocks * OPT_HEADER_LEN; > -- > 2.5.5 > -- Samuel AUTHOR FvwmM4 is the result of a random bit mutation on a hard disk, presumably a result of a cosmic-ray or some such thing. (extrait de la page de man de FvwmM4)