From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756024AbcEaIAb (ORCPT ); Tue, 31 May 2016 04:00:31 -0400 Received: from mail.kernel.org ([198.145.29.136]:45045 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755478AbcEaIA3 (ORCPT ); Tue, 31 May 2016 04:00:29 -0400 Date: Tue, 31 May 2016 17:00:16 +0900 From: Masami Hiramatsu To: Arnaldo Carvalho de Melo Cc: Arnaldo Carvalho de Melo , Masami Hiramatsu , linux-kernel@vger.kernel.org, Namhyung Kim , Peter Zijlstra , Ingo Molnar , Hemant Kumar , Ananth N Mavinakayanahalli , Brendan Gregg Subject: Re: [PATCH perf/core v9 00/16] perf-probe --cache and SDT support Message-Id: <20160531170016.54b540ba6803380ac03afc98@kernel.org> In-Reply-To: <20160530163053.GA2563@kernel.org> References: <20160528151456.16098.90001.stgit@devbox> <20160530162252.GE11853@kernel.org> <20160530163053.GA2563@kernel.org> X-Mailer: Sylpheed 3.4.3 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 May 2016 13:30:53 -0300 Arnaldo Carvalho de Melo wrote: > Em Mon, May 30, 2016 at 01:22:52PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Sun, May 29, 2016 at 12:15:01AM +0900, Masami Hiramatsu escreveu: > > > Hi, > > > > > > Here is the 9th version of the patchset for probe-cache and > > > initial SDT support. > > > > Ok, for completeness sake: Where does one learn more about "SDT", I > > couldn't find a description of this in this patchkit, /me goes googling > > around... > > https://sourceware.org/gdb/onlinedocs/gdb/Static-Probe-Points.html > > Some lifting of this text, giving credit and checking whatever license > it is under would help, I think. Hmm, would you mean we'd better add links(urls) in Documentation/perf-probe.txt? > Mentioning some userland components that have such "Statically Defined > Tracing" markers would also help testers to try it with this patchkit, I > saw just one or two examples here, IIRC with libc and libstdc++. Yeah, and it depends on the binary which your distro provides. Fotunately, Redhat provided binaries usually enables SDTs :) As you can see the below page, we can add a testcase for sdt in perftool itself (this also requires sdt.h provided by systemtap-devel) https://sourceware.org/systemtap/wiki/AddingUserSpaceProbingToApps Then, user can run tests to ensure it. Thank you! > > - Arnaldo > > > - Arnaldo > > > > > The previous version is here; https://lkml.org/lkml/2016/5/14/107 > > > > > > This version just fixes 2 points according to Hemant's comment, > > > and split out the filename__readable() patch. > > > > > > Changes in v9: > > > - [1/16,2/16] split out the filename__readable() > > > - [7/16] Fix to show which event is deleted. > > > - [12/16] Update list_usage to show sdt option. > > > > > > Thank you, > > > > > > --- > > > > > > Hemant Kumar (1): > > > perf/sdt: ELF support for SDT > > > > > > Masami Hiramatsu (15): > > > perf-symbol: Introduce filename__readable to check readability > > > perf symbol: Cleanup the code flow of dso__find_kallsyms > > > perf-buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid > > > perf probe: Add --cache option to cache the probe definitions > > > perf probe: Use cache entry if possible > > > perf probe: Show all cached probes > > > perf probe: Remove caches when --cache is given > > > perf probe: Add group name support > > > perf buildid-cache: Scan and import user SDT events to probe cache > > > perf probe: Accept %sdt and %cached event name > > > perf-list: Show SDT and pre-cached events > > > perf-list: Skip SDTs placed in invalid binaries > > > perf probe: Allow wildcard for cached events > > > perf probe: Support @BUILDID or @FILE suffix for SDT events > > > perf probe: Support a special SDT probe format > > > > > > > > > tools/perf/Documentation/perf-probe.txt | 26 +- > > > tools/perf/builtin-list.c | 6 > > > tools/perf/builtin-probe.c | 30 ++ > > > tools/perf/util/build-id.c | 295 ++++++++++++++++-- > > > tools/perf/util/build-id.h | 8 > > > tools/perf/util/dso.h | 5 > > > tools/perf/util/parse-events.c | 83 +++++ > > > tools/perf/util/parse-events.h | 2 > > > tools/perf/util/probe-event.c | 492 +++++++++++++++++++++++++++--- > > > tools/perf/util/probe-event.h | 7 > > > tools/perf/util/probe-file.c | 504 +++++++++++++++++++++++++++++++ > > > tools/perf/util/probe-file.h | 41 +++ > > > tools/perf/util/symbol-elf.c | 252 ++++++++++++++++ > > > tools/perf/util/symbol.c | 71 ++-- > > > tools/perf/util/symbol.h | 22 + > > > 15 files changed, 1712 insertions(+), 132 deletions(-) > > > > > > -- > > > Masami Hiramatsu -- Masami Hiramatsu