From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [PATCH RFC 15/15] pci/arm: Add pci-testdev PCI device operation test Date: Tue, 31 May 2016 22:27:06 +0200 Message-ID: <20160531202706.iqhwhhcn5g2ut47t@hawk.localdomain> References: <8708e6176b157efee5811b583ab1af608aa6d44b.1460190352.git.agordeev@redhat.com> <20160422173341.zn2miw6kt37ebtxi@hawk.localdomain> <20160529200318.GB28592@agordeev.lab.eng.brq.redhat.com> <20160530061511.ebeeldztwbrx52zl@hawk.localdomain> <20160531201324.GA16522@agordeev.lab.eng.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, Thomas Huth To: Alexander Gordeev Return-path: Received: from mx1.redhat.com ([209.132.183.28]:41781 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813AbcEaU1K (ORCPT ); Tue, 31 May 2016 16:27:10 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 761EA64D2F for ; Tue, 31 May 2016 20:27:10 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160531201324.GA16522@agordeev.lab.eng.brq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, May 31, 2016 at 10:13:25PM +0200, Alexander Gordeev wrote: > On Mon, May 30, 2016 at 08:15:11AM +0200, Andrew Jones wrote: > > > int main(void) > > > { > > > int ret = pci_probe(); > > > > > > report("PCI bus probing", ret); > > > if (!ret) > > > goto done; > > > > > > pci_print(); > > Would you like to make this dump optional? > I.e. with --verbose command line argument? Not sure yet. We can change it later. > > > > if (pci_find_dev(PCI_VENDOR_ID_REDHAT, > > > PCI_DEVICE_ID_REDHAT_TEST) == PCIDEVADDR_INVALID) > > > goto done; > > > > > > ret = pci_testdev(); > > > report("PCI test device passed %d tests", > > > ret >= PCI_TESTDEV_NUM_BARS * PCI_TESTDEV_NUM_TESTS, ret); > > > > > > done: > > > return report_summary(); > > > } > > > > Yup, that's fine. > > > > drew > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html