From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751901AbcFBFCX (ORCPT ); Thu, 2 Jun 2016 01:02:23 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:51017 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750931AbcFBFCW (ORCPT ); Thu, 2 Jun 2016 01:02:22 -0400 Date: Wed, 01 Jun 2016 22:02:20 -0700 (PDT) Message-Id: <20160601.220220.760215551109095573.davem@davemloft.net> To: colin.king@canonical.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, tklauser@distanz.ch, jcmvbkbc@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][V2] net/ethoc: fix null dereference on error exit path From: David Miller In-Reply-To: <1464787010-3089-1-git-send-email-colin.king@canonical.com> References: <1464787010-3089-1-git-send-email-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 01 Jun 2016 22:02:21 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Wed, 1 Jun 2016 14:16:50 +0100 > From: Colin Ian King > > priv is assigned to NULL however some of the early error exit paths to > label 'free' dereference priv, causing a null pointer dereference. > > Move the label 'free' to just the free_netdev statement, and add a new > exit path 'free2' for the error cases were clk_disable_unprepare needs > calling before the final free. > > Fixes issue found by CoverityScan, CID#113260 > > Signed-off-by: Colin Ian King Applied, thanks.