All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: David Miller <davem@davemloft.net>
Cc: buytenh@wantstofly.org, kaber@trash.net, netdev@vger.kernel.org,
	jpirko@redhat.com
Subject: [v2 PATCH 0/2] macvlan: Avoid unnecessary multicast cloning
Date: Wed, 1 Jun 2016 11:42:18 +0800	[thread overview]
Message-ID: <20160601034218.GA31335@gondor.apana.org.au> (raw)
In-Reply-To: <20160531.140713.2187659962450926738.davem@davemloft.net>

On Tue, May 31, 2016 at 02:07:13PM -0700, David Miller wrote:
> 
> I think you need to set the vlan->port->mc_filter to all 1's in the
> PROMISC/ALLMUTI branch here.
> 
> Otherwise packets won't properly pass your new hash test.

Good point.  Here's v2.

This patch tries to improve macvlan multicast performance by
maintaining a filter hash at the macvlan_port level so that we
can quickly determine whether a given packet is needed or not.

It is preceded by a patch that fixes a potential use-after-free
bug that I discovered while looking over this.

v2 fixed a bug where promiscuous/allmulti settings weren't handled
correctly.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2016-06-01  3:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-26 23:44 [PATCH,RFC] macvlan: Handle broadcasts inline if we have only a few macvlans Lennert Buytenhek
2016-05-27 17:56 ` Cong Wang
2016-05-27 18:03   ` Lennert Buytenhek
2016-05-30  8:17 ` [PATCH 0/2] macvlan: Avoid unnecessary multicast cloning Herbert Xu
2016-05-30  8:23   ` [PATCH 1/2] macvlan: Fix potential use-after free for broadcasts Herbert Xu
2016-05-30  8:28   ` [PATCH 2/2] macvlan: Avoid unnecessary multicast cloning Herbert Xu
2016-05-31 21:07     ` David Miller
2016-06-01  3:42       ` Herbert Xu [this message]
2016-06-01  3:43         ` [v2 PATCH 1/2] macvlan: Fix potential use-after free for broadcasts Herbert Xu
2016-06-01  4:19           ` Cong Wang
2016-06-01  4:27             ` Herbert Xu
2016-06-01 23:36               ` Cong Wang
2016-06-01  3:45         ` [v2 PATCH 2/2] macvlan: Avoid unnecessary multicast cloning Herbert Xu
2016-06-02  0:49         ` [v2 PATCH 0/2] " David Miller
2016-05-30 16:27   ` [PATCH " Lennert Buytenhek
2016-05-31  0:49     ` Herbert Xu
2016-05-31 18:40       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160601034218.GA31335@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=buytenh@wantstofly.org \
    --cc=davem@davemloft.net \
    --cc=jpirko@redhat.com \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.