From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161021AbcFAHBR (ORCPT ); Wed, 1 Jun 2016 03:01:17 -0400 Received: from down.free-electrons.com ([37.187.137.238]:57327 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757396AbcFAHBQ (ORCPT ); Wed, 1 Jun 2016 03:01:16 -0400 Date: Wed, 1 Jun 2016 09:01:14 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Mark Brown , Liam Girdwood , linux-arm-kernel , linux-kernel , Lee Jones Subject: Re: [PATCH resend v2 5/6] ARM: dts: sun9i: a80-optimus: Disable dummy regulators vcc3v0, vcc3v3, vcc5v0 Message-ID: <20160601070114.GQ4908@lukather> References: <1464711804-19256-1-git-send-email-wens@csie.org> <1464711804-19256-6-git-send-email-wens@csie.org> <20160531190113.GO4908@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jPC/Tkukgh9ZDT79" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jPC/Tkukgh9ZDT79 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 01, 2016 at 10:45:51AM +0800, Chen-Yu Tsai wrote: > On Wed, Jun 1, 2016 at 3:01 AM, Maxime Ripard > wrote: > > Hi, > > > > On Wed, Jun 01, 2016 at 12:23:23AM +0800, Chen-Yu Tsai wrote: > >> These 3 regulators are provided in sunxi-common-regulators.dtsi. > >> 3.0V/3.3V and 5.0V are commonly used voltages in Allwinner devices. > >> These dummy regulators provide a stand-in when bindings that require > >> one, but the real regulator is not supported yet. > >> > >> Since these are no longer needed, we can disable them. > >> > >> Signed-off-by: Chen-Yu Tsai > >> --- > >> arch/arm/boot/dts/sun9i-a80-optimus.dts | 12 ++++++++++++ > >> 1 file changed, 12 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/sun9i-a80-optimus.dts b/arch/arm/boot/d= ts/sun9i-a80-optimus.dts > >> index 6cfc02194035..991337d1d6f1 100644 > >> --- a/arch/arm/boot/dts/sun9i-a80-optimus.dts > >> +++ b/arch/arm/boot/dts/sun9i-a80-optimus.dts > >> @@ -322,6 +322,18 @@ > >> > >> #include "axp809.dtsi" > >> > >> +®_vcc3v0 { > >> + status =3D "disabled"; > >> +}; > >> + > >> +®_vcc3v3 { > >> + status =3D "disabled"; > >> +}; > >> + > >> +®_vcc5v0 { > >> + status =3D "disabled"; > >> +}; > >> + > > > > Why not remove the include entirely? >=20 > reg_usb1_vbus is still used. Or I could just copy it and > get rid of the include. Ah yes, it is on the Optimus (but not the cubieboard I initially looked at). Since we have that other regulator usb3 regulator, we can simply remove it. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --jPC/Tkukgh9ZDT79 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXTog6AAoJEBx+YmzsjxAg0EMP/RcjHZ0FVkPUEDsuBSEnSxJW axat0csUm8/Zjii3TGVdpgtCECCWIvoOEbNO1ZXhG5mUVVOgUrMni79MQPtTsqBg PujHG3qRQgJWdI5c7tFL+GkERxF4rmlahViesgDE/Mk2D7kmy9coWIrqrTxs4nLn zSE/cu1MaF56lgbJ+57lBQ+w94efrE0of/60xXrJXnrXXNGSj1XFDaQKKpvSqesM ldtIGeVjJXQVQQCsa39C2rDokUPkA6YcoZ0iYH99D6GUNYfsnagbNjRE8QDEt05s kW4EO1kmvuwIyurdeYXsWqc67eQoSc67zBsnQ7E3b46OelrhZD5t4QHLuyYjBxRD J0wc+sgtxpPzbhP7T82Rbj2LqOStRO+obqFn8rD6RToj2VZDf6mMqbXtq0pViBDD n8BRWAJ22+JyDKWoUqz+gPURLikqNXI8PAokKseGDny2PFJv/OpnSsjSpC3Z3LLI bdS1AxbJrT38oV7133ME5RbNl1gwfd6of9DIQ4Fjy4OW6GlbHRgCKHYj1uCnFoIe Zof/qu5+7/pOvLFQwxRCSaSXfWZKHhcBjkxaMRir6ZWbE329GzThn20exPNmS/+Q 8yIAoAMJrb/rxv+ZQwFVbI6qa8EmRTbPKDyfPJLaIKKIeme/eWlw6PLMVv2n3h15 IRIq9TJ0BuYLCnZEk2XK =a8gX -----END PGP SIGNATURE----- --jPC/Tkukgh9ZDT79-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Wed, 1 Jun 2016 09:01:14 +0200 Subject: [PATCH resend v2 5/6] ARM: dts: sun9i: a80-optimus: Disable dummy regulators vcc3v0, vcc3v3, vcc5v0 In-Reply-To: References: <1464711804-19256-1-git-send-email-wens@csie.org> <1464711804-19256-6-git-send-email-wens@csie.org> <20160531190113.GO4908@lukather> Message-ID: <20160601070114.GQ4908@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jun 01, 2016 at 10:45:51AM +0800, Chen-Yu Tsai wrote: > On Wed, Jun 1, 2016 at 3:01 AM, Maxime Ripard > wrote: > > Hi, > > > > On Wed, Jun 01, 2016 at 12:23:23AM +0800, Chen-Yu Tsai wrote: > >> These 3 regulators are provided in sunxi-common-regulators.dtsi. > >> 3.0V/3.3V and 5.0V are commonly used voltages in Allwinner devices. > >> These dummy regulators provide a stand-in when bindings that require > >> one, but the real regulator is not supported yet. > >> > >> Since these are no longer needed, we can disable them. > >> > >> Signed-off-by: Chen-Yu Tsai > >> --- > >> arch/arm/boot/dts/sun9i-a80-optimus.dts | 12 ++++++++++++ > >> 1 file changed, 12 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/sun9i-a80-optimus.dts b/arch/arm/boot/dts/sun9i-a80-optimus.dts > >> index 6cfc02194035..991337d1d6f1 100644 > >> --- a/arch/arm/boot/dts/sun9i-a80-optimus.dts > >> +++ b/arch/arm/boot/dts/sun9i-a80-optimus.dts > >> @@ -322,6 +322,18 @@ > >> > >> #include "axp809.dtsi" > >> > >> +®_vcc3v0 { > >> + status = "disabled"; > >> +}; > >> + > >> +®_vcc3v3 { > >> + status = "disabled"; > >> +}; > >> + > >> +®_vcc5v0 { > >> + status = "disabled"; > >> +}; > >> + > > > > Why not remove the include entirely? > > reg_usb1_vbus is still used. Or I could just copy it and > get rid of the include. Ah yes, it is on the Optimus (but not the cubieboard I initially looked at). Since we have that other regulator usb3 regulator, we can simply remove it. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: