From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [SeaBIOS] [PATCH v5] fw/pci: Add support for mapping Intel IGD via QEMU Date: Wed, 1 Jun 2016 08:19:30 -0600 Message-ID: <20160601081930.1fb0e2ed@t450s.home> References: <20160517203151.6996.95545.stgit@gimli.home> <1464773214.8823.16.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: seabios@seabios.org, kvm@vger.kernel.org, qemu-devel@nongnu.org To: Gerd Hoffmann Return-path: Received: from mx1.redhat.com ([209.132.183.28]:45707 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754104AbcFAOTc (ORCPT ); Wed, 1 Jun 2016 10:19:32 -0400 In-Reply-To: <1464773214.8823.16.camel@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, 01 Jun 2016 11:26:54 +0200 Gerd Hoffmann wrote: > On Di, 2016-05-17 at 14:44 -0600, Alex Williamson wrote: > > QEMU provides two fw_cfg files to support IGD. The first holds the > > OpRegion data which holds the Video BIOS Table (VBT). This needs to > > be copied into reserved memory and the address stored in the ASL > > Storage register of the device at 0xFC offset in PCI config space. > > The OpRegion is generally 8KB. This file is named "etc/igd-opregion". > > > > The second file tells us the required size of the stolen memory space > > for the device. This space requires 1MB alignment and is generally > > either 1MB to 8MB depending on hardware config, but may be hundreds of > > MB for user specified stolen memory. The base address of the reserved > > memory allocated for this is written back to the Base Data of Stolen > > Memory register (BDSM) at PCI config offset 0x5C on the device. This > > file is named "etc/igd-bdsm-size". > > > > QEMU documents these fw_cfg entries in docs/igd-assign.txt. > > > > Signed-off-by: Alex Williamson > > --- > > > > v6: fw_cfg BDSM entry now holds an 8-byte size integer as suggested > > by Gerd. Also renamed to etc/igd-bdsm-size. Filter based on bdf > > to only make use of this for the Intel VGA device at address > > 00:02.0, not that QEMU should attach this to anything else. > > > > As always, comments appreciated. I expect this will be on hold > > pending the QEMU support: > > > > http://thread.gmane.org/gmane.comp.emulators.kvm.devel/152123 > > qemu patches are merged meanwhile. > > Patch applied to master and cherry-picked into 1.9-stable. Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b86zi-00031l-Nx for qemu-devel@nongnu.org; Wed, 01 Jun 2016 10:19:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b86zc-0007v0-NA for qemu-devel@nongnu.org; Wed, 01 Jun 2016 10:19:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53539) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b86zc-0007uu-Gs for qemu-devel@nongnu.org; Wed, 01 Jun 2016 10:19:32 -0400 Date: Wed, 1 Jun 2016 08:19:30 -0600 From: Alex Williamson Message-ID: <20160601081930.1fb0e2ed@t450s.home> In-Reply-To: <1464773214.8823.16.camel@redhat.com> References: <20160517203151.6996.95545.stgit@gimli.home> <1464773214.8823.16.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH v5] fw/pci: Add support for mapping Intel IGD via QEMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: seabios@seabios.org, kvm@vger.kernel.org, qemu-devel@nongnu.org On Wed, 01 Jun 2016 11:26:54 +0200 Gerd Hoffmann wrote: > On Di, 2016-05-17 at 14:44 -0600, Alex Williamson wrote: > > QEMU provides two fw_cfg files to support IGD. The first holds the > > OpRegion data which holds the Video BIOS Table (VBT). This needs to > > be copied into reserved memory and the address stored in the ASL > > Storage register of the device at 0xFC offset in PCI config space. > > The OpRegion is generally 8KB. This file is named "etc/igd-opregion". > > > > The second file tells us the required size of the stolen memory space > > for the device. This space requires 1MB alignment and is generally > > either 1MB to 8MB depending on hardware config, but may be hundreds of > > MB for user specified stolen memory. The base address of the reserved > > memory allocated for this is written back to the Base Data of Stolen > > Memory register (BDSM) at PCI config offset 0x5C on the device. This > > file is named "etc/igd-bdsm-size". > > > > QEMU documents these fw_cfg entries in docs/igd-assign.txt. > > > > Signed-off-by: Alex Williamson > > --- > > > > v6: fw_cfg BDSM entry now holds an 8-byte size integer as suggested > > by Gerd. Also renamed to etc/igd-bdsm-size. Filter based on bdf > > to only make use of this for the Intel VGA device at address > > 00:02.0, not that QEMU should attach this to anything else. > > > > As always, comments appreciated. I expect this will be on hold > > pending the QEMU support: > > > > http://thread.gmane.org/gmane.comp.emulators.kvm.devel/152123 > > qemu patches are merged meanwhile. > > Patch applied to master and cherry-picked into 1.9-stable. Thanks!