From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v2 01/21] drm: Export drm_dev_init() for
	subclassing
Date: Wed, 1 Jun 2016 12:01:44 +0200
Message-ID: <20160601100144.GU7231@phenom.ffwll.local>
References: <1464597519-16659-1-git-send-email-chris@chris-wilson.co.uk>
 <1464597519-16659-2-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <1464597519-16659-2-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gTW9uLCBNYXkgMzAsIDIwMTYgYXQgMDk6Mzg6MTlBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IEluIG9yZGVyIHRvIGFsbG93IGRyaXZlcnMgdG8gcGFjayB0aGVpciBwcml2YXRlcyBh
bmQgZHJtX2RldmljZSBpbnRvIG9uZQo+IHN0cnVjdCAoZS5nLiBmb3Igc3ViY2xhc3NpbmcpLCBl
eHBvcnQgdGhlIGluaXRpYWxpc2F0aW9uIHJvdXRpbmVzIGZvcgo+IHN0cnVjdCBkcm1fZGV2aWNl
Lgo+IAo+IHYyOiBNaXNzZWQgcmV0dXJuIHJldC4gVGhhdCBlcnJvciBwYXRoIGhhZCBvbmx5IG9u
ZSBqb2IgdG8gZG8hCj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJp
cy13aWxzb24uY28udWs+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwu
Y2g+Cj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiAtLS0KPiAgZHJpdmVy
cy9ncHUvZHJtL2RybV9kcnYuYyB8IDYzICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr
KysrKy0tLS0tLS0tLS0tCj4gIGluY2x1ZGUvZHJtL2RybVAuaCAgICAgICAgfCAgMyArKysKPiAg
MiBmaWxlcyBjaGFuZ2VkLCA1MiBpbnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkKPiAKPiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9k
cm1fZHJ2LmMKPiBpbmRleCBiZmY4OTIyNmEzNDQuLmYwNTUzY2NkNGY3MSAxMDA2NDQKPiAtLS0g
YS9kcml2ZXJzL2dwdS9kcm0vZHJtX2Rydi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9k
cnYuYwo+IEBAIC01NDksMTEgKzU0OSwxMiBAQCBzdGF0aWMgdm9pZCBkcm1fZnNfaW5vZGVfZnJl
ZShzdHJ1Y3QgaW5vZGUgKmlub2RlKQo+ICB9Cj4gIAo+ICAvKioKPiAtICogZHJtX2Rldl9hbGxv
YyAtIEFsbG9jYXRlIG5ldyBEUk0gZGV2aWNlCj4gLSAqIEBkcml2ZXI6IERSTSBkcml2ZXIgdG8g
YWxsb2NhdGUgZGV2aWNlIGZvcgo+ICsgKiBkcm1fZGV2X2luaXQgLSBJbml0aWFsaXNlIG5ldyBE
Uk0gZGV2aWNlCj4gKyAqIEBkZXY6IERSTSBkZXZpY2UKPiArICogQGRyaXZlcjogRFJNIGRyaXZl
cgo+ICAgKiBAcGFyZW50OiBQYXJlbnQgZGV2aWNlIG9iamVjdAo+ICAgKgo+IC0gKiBBbGxvY2F0
ZSBhbmQgaW5pdGlhbGl6ZSBhIG5ldyBEUk0gZGV2aWNlLiBObyBkZXZpY2UgcmVnaXN0cmF0aW9u
IGlzIGRvbmUuCj4gKyAqIEluaXRpYWxpemUgYSBuZXcgRFJNIGRldmljZS4gTm8gZGV2aWNlIHJl
Z2lzdHJhdGlvbiBpcyBkb25lLgo+ICAgKiBDYWxsIGRybV9kZXZfcmVnaXN0ZXIoKSB0byBhZHZl
cnRpY2UgdGhlIGRldmljZSB0byB1c2VyIHNwYWNlIGFuZCByZWdpc3RlciBpdAo+ICAgKiB3aXRo
IG90aGVyIGNvcmUgc3Vic3lzdGVtcy4gVGhpcyBzaG91bGQgYmUgZG9uZSBsYXN0IGluIHRoZSBk
ZXZpY2UKPiAgICogaW5pdGlhbGl6YXRpb24gc2VxdWVuY2UgdG8gbWFrZSBzdXJlIHVzZXJzcGFj
ZSBjYW4ndCBhY2Nlc3MgYW4gaW5jb25zaXN0ZW50Cj4gQEAgLTU2NSwxOCArNTY2LDE0IEBAIHN0
YXRpYyB2b2lkIGRybV9mc19pbm9kZV9mcmVlKHN0cnVjdCBpbm9kZSAqaW5vZGUpCj4gICAqIE5v
dGUgdGhhdCBmb3IgcHVyZWx5IHZpcnR1YWwgZGV2aWNlcyBAcGFyZW50IGNhbiBiZSBOVUxMLgoK
TWF5YmUgYWRkICJEcml2ZXJzIHdoaWNoIGRvbid0IHdhbnQgdG8gYWxsb2NhdGUgdGhlaXIgb3du
IGRldmljZSBzdHJ1Y3R1cmUKZW1iZWRkaW5nICZkcm1fZGV2aWNlIGNhbiBpbnN0ZWFkIGp1c3Qg
Y2FsbCBkcm1fZGV2X2FsbG9jKCkuIgo+ICAgKgo+ICAgKiBSRVRVUk5TOgo+IC0gKiBQb2ludGVy
IHRvIG5ldyBEUk0gZGV2aWNlLCBvciBOVUxMIGlmIG91dCBvZiBtZW1vcnkuCj4gKyAqIDAgb24g
c3VjY2Vzcywgb3IgZXJyb3IgY29kZSBvbiBmYWlsdXJlLgo+ICAgKi8KPiAtc3RydWN0IGRybV9k
ZXZpY2UgKmRybV9kZXZfYWxsb2Moc3RydWN0IGRybV9kcml2ZXIgKmRyaXZlciwKPiAtCQkJCSBz
dHJ1Y3QgZGV2aWNlICpwYXJlbnQpCj4gK2ludCBkcm1fZGV2X2luaXQoc3RydWN0IGRybV9kZXZp
Y2UgKmRldiwKPiArCQkgc3RydWN0IGRybV9kcml2ZXIgKmRyaXZlciwKPiArCQkgc3RydWN0IGRl
dmljZSAqcGFyZW50KQo+ICB7Cj4gLQlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2Owo+ICAJaW50IHJl
dDsKPiAgCj4gLQlkZXYgPSBremFsbG9jKHNpemVvZigqZGV2KSwgR0ZQX0tFUk5FTCk7Cj4gLQlp
ZiAoIWRldikKPiAtCQlyZXR1cm4gTlVMTDsKPiAtCj4gIAlrcmVmX2luaXQoJmRldi0+cmVmKTsK
PiAgCWRldi0+ZGV2ID0gcGFyZW50Owo+ICAJZGV2LT5kcml2ZXIgPSBkcml2ZXI7Cj4gQEAgLTYz
OCw3ICs2MzUsNyBAQCBzdHJ1Y3QgZHJtX2RldmljZSAqZHJtX2Rldl9hbGxvYyhzdHJ1Y3QgZHJt
X2RyaXZlciAqZHJpdmVyLAo+ICAJCQlnb3RvIGVycl9zZXR1bmlxdWU7Cj4gIAl9Cj4gIAo+IC0J
cmV0dXJuIGRldjsKPiArCXJldHVybiAwOwo+ICAKPiAgZXJyX3NldHVuaXF1ZToKPiAgCWlmIChk
cm1fY29yZV9jaGVja19mZWF0dXJlKGRldiwgRFJJVkVSX0dFTSkpCj4gQEAgLTY1Myw4ICs2NTAs
NDYgQEAgZXJyX21pbm9yczoKPiAgCWRybV9mc19pbm9kZV9mcmVlKGRldi0+YW5vbl9pbm9kZSk7
Cj4gIGVycl9mcmVlOgo+ICAJbXV0ZXhfZGVzdHJveSgmZGV2LT5tYXN0ZXJfbXV0ZXgpOwo+IC0J
a2ZyZWUoZGV2KTsKPiAtCXJldHVybiBOVUxMOwo+ICsJcmV0dXJuIHJldDsKCmZvciAiZ290byBl
cnJfbWlub3JzIiB5b3UgbmVlZCB0byBzZXQgcmV0IGZpcnN0LCBvdGhlcndpc2Ugd2UnbGwgZmFp
bCBhbmQKcmV0dXJuIDAuIFdhc24ndCBhIHByb2JsZW0gYmVjYXVzZSBvZiB0aGUgdW5jb25kaXRp
b25hbCByZXR1cm4gTlVMTCBoZXJlLgoKPiArfQo+ICtFWFBPUlRfU1lNQk9MKGRybV9kZXZfaW5p
dCk7Cj4gKwo+ICsvKioKPiArICogZHJtX2Rldl9hbGxvYyAtIEFsbG9jYXRlIG5ldyBEUk0gZGV2
aWNlCj4gKyAqIEBkcml2ZXI6IERSTSBkcml2ZXIgdG8gYWxsb2NhdGUgZGV2aWNlIGZvcgo+ICsg
KiBAcGFyZW50OiBQYXJlbnQgZGV2aWNlIG9iamVjdAo+ICsgKgo+ICsgKiBBbGxvY2F0ZSBhbmQg
aW5pdGlhbGl6ZSBhIG5ldyBEUk0gZGV2aWNlLiBObyBkZXZpY2UgcmVnaXN0cmF0aW9uIGlzIGRv
bmUuCj4gKyAqIENhbGwgZHJtX2Rldl9yZWdpc3RlcigpIHRvIGFkdmVydGljZSB0aGUgZGV2aWNl
IHRvIHVzZXIgc3BhY2UgYW5kIHJlZ2lzdGVyIGl0Cj4gKyAqIHdpdGggb3RoZXIgY29yZSBzdWJz
eXN0ZW1zLiBUaGlzIHNob3VsZCBiZSBkb25lIGxhc3QgaW4gdGhlIGRldmljZQo+ICsgKiBpbml0
aWFsaXphdGlvbiBzZXF1ZW5jZSB0byBtYWtlIHN1cmUgdXNlcnNwYWNlIGNhbid0IGFjY2VzcyBh
biBpbmNvbnNpc3RlbnQKPiArICogc3RhdGUuCj4gKyAqCj4gKyAqIFRoZSBpbml0aWFsIHJlZi1j
b3VudCBvZiB0aGUgb2JqZWN0IGlzIDEuIFVzZSBkcm1fZGV2X3JlZigpIGFuZAo+ICsgKiBkcm1f
ZGV2X3VucmVmKCkgdG8gdGFrZSBhbmQgZHJvcCBmdXJ0aGVyIHJlZi1jb3VudHMuCj4gKyAqCj4g
KyAqIE5vdGUgdGhhdCBmb3IgcHVyZWx5IHZpcnR1YWwgZGV2aWNlcyBAcGFyZW50IGNhbiBiZSBO
VUxMLgoKTWF5YmUgd2UgY2FuIGFsc28gYWRkICJEcml2ZXJzIHdoaWNoIHdhbnQgdG8gc3ViY2xh
c3MvZW1iZWQgc3RydWN0CiZkcm1fZGV2aWNlIHNob3VsZCBpbnN0ZWFkIGxvb2sgYXQgZHJtX2Rl
dl9pbml0KCkuIgoKPiArICoKPiArICogUkVUVVJOUzoKPiArICogUG9pbnRlciB0byBuZXcgRFJN
IGRldmljZSwgb3IgTlVMTCBpZiBvdXQgb2YgbWVtb3J5Lgo+ICsgKi8KPiArc3RydWN0IGRybV9k
ZXZpY2UgKmRybV9kZXZfYWxsb2Moc3RydWN0IGRybV9kcml2ZXIgKmRyaXZlciwKPiArCQkJCSBz
dHJ1Y3QgZGV2aWNlICpwYXJlbnQpCj4gK3sKPiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXY7Cj4g
KwlpbnQgcmV0Owo+ICsKPiArCWRldiA9IGt6YWxsb2Moc2l6ZW9mKCpkZXYpLCBHRlBfS0VSTkVM
KTsKPiArCWlmICghZGV2KQo+ICsJCXJldHVybiBOVUxMOwo+ICsKPiArCXJldCA9IGRybV9kZXZf
aW5pdChkZXYsIGRyaXZlciwgcGFyZW50KTsKPiArCWlmIChyZXQpIHsKPiArCQlrZnJlZShkZXYp
Owo+ICsJCXJldHVybiBOVUxMOwo+ICsJfQo+ICsKPiArCXJldHVybiBkZXY7Cj4gIH0KPiAgRVhQ
T1JUX1NZTUJPTChkcm1fZGV2X2FsbG9jKTsKPiAgCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJt
L2RybVAuaCBiL2luY2x1ZGUvZHJtL2RybVAuaAo+IGluZGV4IGM1ZDI5NTA1ZjkzNy4uMTJkYzVm
OWNhZDg5IDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybVAuaAo+ICsrKyBiL2luY2x1ZGUv
ZHJtL2RybVAuaAo+IEBAIC0xMDc1LDYgKzEwNzUsOSBAQCBleHRlcm4gdm9pZCBkcm1fc3lzZnNf
aG90cGx1Z19ldmVudChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiAgCj4gIHN0cnVjdCBkcm1f
ZGV2aWNlICpkcm1fZGV2X2FsbG9jKHN0cnVjdCBkcm1fZHJpdmVyICpkcml2ZXIsCj4gIAkJCQkg
c3RydWN0IGRldmljZSAqcGFyZW50KTsKPiAraW50IGRybV9kZXZfaW5pdChzdHJ1Y3QgZHJtX2Rl
dmljZSAqZGV2LAo+ICsJCSBzdHJ1Y3QgZHJtX2RyaXZlciAqZHJpdmVyLAo+ICsJCSBzdHJ1Y3Qg
ZGV2aWNlICpwYXJlbnQpOwo+ICB2b2lkIGRybV9kZXZfcmVmKHN0cnVjdCBkcm1fZGV2aWNlICpk
ZXYpOwo+ICB2b2lkIGRybV9kZXZfdW5yZWYoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4gIGlu
dCBkcm1fZGV2X3JlZ2lzdGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGxvbmcg
ZmxhZ3MpOwoKV2l0aCB0aGUgb25lIGJ1ZyBpbiB0aGUgZXJyb3IgaGFuZGxpbmcgZml4ZWQsIGFu
ZCB0aGUga2VybmVsZG9jIGF1Z21lbnRlZDoKClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxk
YW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKPiAtLSAKPiAyLjguMQo+IAoKLS0gCkRhbmllbCBWZXR0
ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xs
LmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs
LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov
L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=