From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 01/21] drm: Export drm_dev_init() for subclassing Date: Wed, 1 Jun 2016 12:07:28 +0200 Message-ID: <20160601100728.GV7231@phenom.ffwll.local> References: <1464597519-16659-1-git-send-email-chris@chris-wilson.co.uk> <1464597519-16659-2-git-send-email-chris@chris-wilson.co.uk> <20160601100144.GU7231@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id DC0236E954 for ; Wed, 1 Jun 2016 10:07:33 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id q62so5216019wmg.3 for ; Wed, 01 Jun 2016 03:07:33 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20160601100144.GU7231@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBKdW4gMDEsIDIwMTYgYXQgMTI6MDE6NDRQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBNb24sIE1heSAzMCwgMjAxNiBhdCAwOTozODoxOUFNICswMTAwLCBDaHJpcyBX aWxzb24gd3JvdGU6Cj4gPiBJbiBvcmRlciB0byBhbGxvdyBkcml2ZXJzIHRvIHBhY2sgdGhlaXIg cHJpdmF0ZXMgYW5kIGRybV9kZXZpY2UgaW50byBvbmUKPiA+IHN0cnVjdCAoZS5nLiBmb3Igc3Vi Y2xhc3NpbmcpLCBleHBvcnQgdGhlIGluaXRpYWxpc2F0aW9uIHJvdXRpbmVzIGZvcgo+ID4gc3Ry dWN0IGRybV9kZXZpY2UuCj4gPiAKPiA+IHYyOiBNaXNzZWQgcmV0dXJuIHJldC4gVGhhdCBlcnJv ciBwYXRoIGhhZCBvbmx5IG9uZSBqb2IgdG8gZG8hCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IENo cmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+ID4gQ2M6IERhbmllbCBWZXR0 ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gPiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2RybV9kcnYuYyB8IDYzICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tCj4gPiAgaW5jbHVk ZS9kcm0vZHJtUC5oICAgICAgICB8ICAzICsrKwo+ID4gIDIgZmlsZXMgY2hhbmdlZCwgNTIgaW5z ZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vZHJtX2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9kcnYuYwo+ID4gaW5kZXgg YmZmODkyMjZhMzQ0Li5mMDU1M2NjZDRmNzEgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vZHJtX2Rydi5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2Rydi5jCj4gPiBAQCAt NTQ5LDExICs1NDksMTIgQEAgc3RhdGljIHZvaWQgZHJtX2ZzX2lub2RlX2ZyZWUoc3RydWN0IGlu b2RlICppbm9kZSkKPiA+ICB9Cj4gPiAgCj4gPiAgLyoqCj4gPiAtICogZHJtX2Rldl9hbGxvYyAt IEFsbG9jYXRlIG5ldyBEUk0gZGV2aWNlCj4gPiAtICogQGRyaXZlcjogRFJNIGRyaXZlciB0byBh bGxvY2F0ZSBkZXZpY2UgZm9yCj4gPiArICogZHJtX2Rldl9pbml0IC0gSW5pdGlhbGlzZSBuZXcg RFJNIGRldmljZQo+ID4gKyAqIEBkZXY6IERSTSBkZXZpY2UKPiA+ICsgKiBAZHJpdmVyOiBEUk0g ZHJpdmVyCj4gPiAgICogQHBhcmVudDogUGFyZW50IGRldmljZSBvYmplY3QKPiA+ICAgKgo+ID4g LSAqIEFsbG9jYXRlIGFuZCBpbml0aWFsaXplIGEgbmV3IERSTSBkZXZpY2UuIE5vIGRldmljZSBy ZWdpc3RyYXRpb24gaXMgZG9uZS4KPiA+ICsgKiBJbml0aWFsaXplIGEgbmV3IERSTSBkZXZpY2Uu IE5vIGRldmljZSByZWdpc3RyYXRpb24gaXMgZG9uZS4KPiA+ICAgKiBDYWxsIGRybV9kZXZfcmVn aXN0ZXIoKSB0byBhZHZlcnRpY2UgdGhlIGRldmljZSB0byB1c2VyIHNwYWNlIGFuZCByZWdpc3Rl ciBpdAo+ID4gICAqIHdpdGggb3RoZXIgY29yZSBzdWJzeXN0ZW1zLiBUaGlzIHNob3VsZCBiZSBk b25lIGxhc3QgaW4gdGhlIGRldmljZQo+ID4gICAqIGluaXRpYWxpemF0aW9uIHNlcXVlbmNlIHRv IG1ha2Ugc3VyZSB1c2Vyc3BhY2UgY2FuJ3QgYWNjZXNzIGFuIGluY29uc2lzdGVudAo+ID4gQEAg LTU2NSwxOCArNTY2LDE0IEBAIHN0YXRpYyB2b2lkIGRybV9mc19pbm9kZV9mcmVlKHN0cnVjdCBp bm9kZSAqaW5vZGUpCj4gPiAgICogTm90ZSB0aGF0IGZvciBwdXJlbHkgdmlydHVhbCBkZXZpY2Vz IEBwYXJlbnQgY2FuIGJlIE5VTEwuCj4gCj4gTWF5YmUgYWRkICJEcml2ZXJzIHdoaWNoIGRvbid0 IHdhbnQgdG8gYWxsb2NhdGUgdGhlaXIgb3duIGRldmljZSBzdHJ1Y3R1cmUKPiBlbWJlZGRpbmcg JmRybV9kZXZpY2UgY2FuIGluc3RlYWQganVzdCBjYWxsIGRybV9kZXZfYWxsb2MoKS4iCj4gPiAg ICoKPiA+ICAgKiBSRVRVUk5TOgo+ID4gLSAqIFBvaW50ZXIgdG8gbmV3IERSTSBkZXZpY2UsIG9y IE5VTEwgaWYgb3V0IG9mIG1lbW9yeS4KPiA+ICsgKiAwIG9uIHN1Y2Nlc3MsIG9yIGVycm9yIGNv ZGUgb24gZmFpbHVyZS4KPiA+ICAgKi8KPiA+IC1zdHJ1Y3QgZHJtX2RldmljZSAqZHJtX2Rldl9h bGxvYyhzdHJ1Y3QgZHJtX2RyaXZlciAqZHJpdmVyLAo+ID4gLQkJCQkgc3RydWN0IGRldmljZSAq cGFyZW50KQo+ID4gK2ludCBkcm1fZGV2X2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ ICsJCSBzdHJ1Y3QgZHJtX2RyaXZlciAqZHJpdmVyLAo+ID4gKwkJIHN0cnVjdCBkZXZpY2UgKnBh cmVudCkKPiA+ICB7Cj4gPiAtCXN0cnVjdCBkcm1fZGV2aWNlICpkZXY7Cj4gPiAgCWludCByZXQ7 Cj4gPiAgCj4gPiAtCWRldiA9IGt6YWxsb2Moc2l6ZW9mKCpkZXYpLCBHRlBfS0VSTkVMKTsKPiA+ IC0JaWYgKCFkZXYpCj4gPiAtCQlyZXR1cm4gTlVMTDsKPiA+IC0KPiA+ICAJa3JlZl9pbml0KCZk ZXYtPnJlZik7Cj4gPiAgCWRldi0+ZGV2ID0gcGFyZW50Owo+ID4gIAlkZXYtPmRyaXZlciA9IGRy aXZlcjsKPiA+IEBAIC02MzgsNyArNjM1LDcgQEAgc3RydWN0IGRybV9kZXZpY2UgKmRybV9kZXZf YWxsb2Moc3RydWN0IGRybV9kcml2ZXIgKmRyaXZlciwKPiA+ICAJCQlnb3RvIGVycl9zZXR1bmlx dWU7Cj4gPiAgCX0KPiA+ICAKPiA+IC0JcmV0dXJuIGRldjsKPiA+ICsJcmV0dXJuIDA7Cj4gPiAg Cj4gPiAgZXJyX3NldHVuaXF1ZToKPiA+ICAJaWYgKGRybV9jb3JlX2NoZWNrX2ZlYXR1cmUoZGV2 LCBEUklWRVJfR0VNKSkKPiA+IEBAIC02NTMsOCArNjUwLDQ2IEBAIGVycl9taW5vcnM6Cj4gPiAg CWRybV9mc19pbm9kZV9mcmVlKGRldi0+YW5vbl9pbm9kZSk7Cj4gPiAgZXJyX2ZyZWU6Cj4gPiAg CW11dGV4X2Rlc3Ryb3koJmRldi0+bWFzdGVyX211dGV4KTsKPiA+IC0Ja2ZyZWUoZGV2KTsKPiA+ IC0JcmV0dXJuIE5VTEw7Cj4gPiArCXJldHVybiByZXQ7Cj4gCj4gZm9yICJnb3RvIGVycl9taW5v cnMiIHlvdSBuZWVkIHRvIHNldCByZXQgZmlyc3QsIG90aGVyd2lzZSB3ZSdsbCBmYWlsIGFuZAo+ IHJldHVybiAwLiBXYXNuJ3QgYSBwcm9ibGVtIGJlY2F1c2Ugb2YgdGhlIHVuY29uZGl0aW9uYWwg cmV0dXJuIE5VTEwgaGVyZS4KPiAKPiA+ICt9Cj4gPiArRVhQT1JUX1NZTUJPTChkcm1fZGV2X2lu aXQpOwo+ID4gKwo+ID4gKy8qKgo+ID4gKyAqIGRybV9kZXZfYWxsb2MgLSBBbGxvY2F0ZSBuZXcg RFJNIGRldmljZQo+ID4gKyAqIEBkcml2ZXI6IERSTSBkcml2ZXIgdG8gYWxsb2NhdGUgZGV2aWNl IGZvcgo+ID4gKyAqIEBwYXJlbnQ6IFBhcmVudCBkZXZpY2Ugb2JqZWN0Cj4gPiArICoKPiA+ICsg KiBBbGxvY2F0ZSBhbmQgaW5pdGlhbGl6ZSBhIG5ldyBEUk0gZGV2aWNlLiBObyBkZXZpY2UgcmVn aXN0cmF0aW9uIGlzIGRvbmUuCj4gPiArICogQ2FsbCBkcm1fZGV2X3JlZ2lzdGVyKCkgdG8gYWR2 ZXJ0aWNlIHRoZSBkZXZpY2UgdG8gdXNlciBzcGFjZSBhbmQgcmVnaXN0ZXIgaXQKPiA+ICsgKiB3 aXRoIG90aGVyIGNvcmUgc3Vic3lzdGVtcy4gVGhpcyBzaG91bGQgYmUgZG9uZSBsYXN0IGluIHRo ZSBkZXZpY2UKPiA+ICsgKiBpbml0aWFsaXphdGlvbiBzZXF1ZW5jZSB0byBtYWtlIHN1cmUgdXNl cnNwYWNlIGNhbid0IGFjY2VzcyBhbiBpbmNvbnNpc3RlbnQKPiA+ICsgKiBzdGF0ZS4KPiA+ICsg Kgo+ID4gKyAqIFRoZSBpbml0aWFsIHJlZi1jb3VudCBvZiB0aGUgb2JqZWN0IGlzIDEuIFVzZSBk cm1fZGV2X3JlZigpIGFuZAo+ID4gKyAqIGRybV9kZXZfdW5yZWYoKSB0byB0YWtlIGFuZCBkcm9w IGZ1cnRoZXIgcmVmLWNvdW50cy4KPiA+ICsgKgo+ID4gKyAqIE5vdGUgdGhhdCBmb3IgcHVyZWx5 IHZpcnR1YWwgZGV2aWNlcyBAcGFyZW50IGNhbiBiZSBOVUxMLgo+IAo+IE1heWJlIHdlIGNhbiBh bHNvIGFkZCAiRHJpdmVycyB3aGljaCB3YW50IHRvIHN1YmNsYXNzL2VtYmVkIHN0cnVjdAo+ICZk cm1fZGV2aWNlIHNob3VsZCBpbnN0ZWFkIGxvb2sgYXQgZHJtX2Rldl9pbml0KCkuIgo+IAo+ID4g KyAqCj4gPiArICogUkVUVVJOUzoKPiA+ICsgKiBQb2ludGVyIHRvIG5ldyBEUk0gZGV2aWNlLCBv ciBOVUxMIGlmIG91dCBvZiBtZW1vcnkuCj4gPiArICovCj4gPiArc3RydWN0IGRybV9kZXZpY2Ug KmRybV9kZXZfYWxsb2Moc3RydWN0IGRybV9kcml2ZXIgKmRyaXZlciwKPiA+ICsJCQkJIHN0cnVj dCBkZXZpY2UgKnBhcmVudCkKPiA+ICt7Cj4gPiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXY7Cj4g PiArCWludCByZXQ7Cj4gPiArCj4gPiArCWRldiA9IGt6YWxsb2Moc2l6ZW9mKCpkZXYpLCBHRlBf S0VSTkVMKTsKPiA+ICsJaWYgKCFkZXYpCj4gPiArCQlyZXR1cm4gTlVMTDsKPiA+ICsKPiA+ICsJ cmV0ID0gZHJtX2Rldl9pbml0KGRldiwgZHJpdmVyLCBwYXJlbnQpOwo+ID4gKwlpZiAocmV0KSB7 Cj4gPiArCQlrZnJlZShkZXYpOwo+ID4gKwkJcmV0dXJuIE5VTEw7Cj4gPiArCX0KPiA+ICsKPiA+ ICsJcmV0dXJuIGRldjsKPiA+ICB9Cj4gPiAgRVhQT1JUX1NZTUJPTChkcm1fZGV2X2FsbG9jKTsK PiA+ICAKPiA+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1QLmggYi9pbmNsdWRlL2RybS9k cm1QLmgKPiA+IGluZGV4IGM1ZDI5NTA1ZjkzNy4uMTJkYzVmOWNhZDg5IDEwMDY0NAo+ID4gLS0t IGEvaW5jbHVkZS9kcm0vZHJtUC5oCj4gPiArKysgYi9pbmNsdWRlL2RybS9kcm1QLmgKPiA+IEBA IC0xMDc1LDYgKzEwNzUsOSBAQCBleHRlcm4gdm9pZCBkcm1fc3lzZnNfaG90cGx1Z19ldmVudChz dHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiA+ICAKPiA+ICBzdHJ1Y3QgZHJtX2RldmljZSAqZHJt X2Rldl9hbGxvYyhzdHJ1Y3QgZHJtX2RyaXZlciAqZHJpdmVyLAo+ID4gIAkJCQkgc3RydWN0IGRl dmljZSAqcGFyZW50KTsKPiA+ICtpbnQgZHJtX2Rldl9pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYsCj4gPiArCQkgc3RydWN0IGRybV9kcml2ZXIgKmRyaXZlciwKPiA+ICsJCSBzdHJ1Y3QgZGV2 aWNlICpwYXJlbnQpOwo+ID4gIHZvaWQgZHJtX2Rldl9yZWYoc3RydWN0IGRybV9kZXZpY2UgKmRl dik7Cj4gPiAgdm9pZCBkcm1fZGV2X3VucmVmKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ID4g IGludCBkcm1fZGV2X3JlZ2lzdGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGxv bmcgZmxhZ3MpOwo+IAo+IFdpdGggdGhlIG9uZSBidWcgaW4gdGhlIGVycm9yIGhhbmRsaW5nIGZp eGVkLCBhbmQgdGhlIGtlcm5lbGRvYyBhdWdtZW50ZWQ6Cj4gCj4gUmV2aWV3ZWQtYnk6IERhbmll bCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+CgpyLWIgcmV0cmFjdGVkLCB0aGlzIGlz IGEgYml0IGluY29tcGxldGUgc2luY2UgaXQgZG9lc24ndCBoYW5kbGUKZHJtX2Rldl9yZWxlYXNl LiBJIHRoaW5rIHdlIGFsc28gc2hvdWxkIGFkZCBhbiBvcHRpb25hbCAtPmRldmljZV9mcmVlCmNh bGxiYWNrIGFuZCB1c2UgdGhhdCBpbiBkcm1fZGV2X3JlbGVhc2UgaW5zdGVhZCBvZiBrZnJlZSgp LgoKVGhhdCB3b3VsZCBmaW5hbGx5IG1ha2UgdGhlIGRybV9kZXZpY2UgcmVmY291bnRpbmcgYWxz byBzb21ld2hhdCB1c2VmdWwsCnNpbmNlIHJpZ2h0IG5vdyB5b3UgaGF2ZSB0byByZWxlYXNlIGRy aXZlci1wcml2YXRlIHN0dWZmIGJlZm9yZSB0aGUgZGV2aWNlCmlzIGFjdHVhbGx5IGdvbmUsIHdo aWNoIGlzIGJ1Z2d5LiBPciBqdXN0IGxlYWssIHdoaWNoIGlzIGFsc28gYnVnZ3kgOy0pCi1EYW5p ZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9u Cmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo=