From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161180AbcFAOVm (ORCPT ); Wed, 1 Jun 2016 10:21:42 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34004 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753839AbcFAOVl (ORCPT ); Wed, 1 Jun 2016 10:21:41 -0400 Date: Wed, 1 Jun 2016 16:21:38 +0200 From: Michal Hocko To: Vlastimil Babka Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mel Gorman , Joonsoo Kim , David Rientjes , Rik van Riel Subject: Re: [PATCH v2 18/18] mm, vmscan: use proper classzone_idx in should_continue_reclaim() Message-ID: <20160601142138.GX26601@dhcp22.suse.cz> References: <20160531130818.28724-1-vbabka@suse.cz> <20160531130818.28724-19-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160531130818.28724-19-vbabka@suse.cz> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 31-05-16 15:08:18, Vlastimil Babka wrote: [...] > @@ -2364,11 +2350,12 @@ static inline bool should_continue_reclaim(struct zone *zone, > } > > static bool shrink_zone(struct zone *zone, struct scan_control *sc, > - bool is_classzone) > + int classzone_idx) > { > struct reclaim_state *reclaim_state = current->reclaim_state; > unsigned long nr_reclaimed, nr_scanned; > bool reclaimable = false; > + bool is_classzone = (classzone_idx == zone_idx(zone)); > > do { > struct mem_cgroup *root = sc->target_mem_cgroup; > @@ -2450,7 +2437,7 @@ static bool shrink_zone(struct zone *zone, struct scan_control *sc, > reclaimable = true; > > } while (should_continue_reclaim(zone, sc->nr_reclaimed - nr_reclaimed, > - sc->nr_scanned - nr_scanned, sc)); > + sc->nr_scanned - nr_scanned, sc, classzone_idx)); > > return reclaimable; > } > @@ -2580,7 +2567,7 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc) > /* need some check for avoid more shrink_zone() */ > } > > - shrink_zone(zone, sc, zone_idx(zone) == classzone_idx); > + shrink_zone(zone, sc, classzone_idx); this should be is_classzone, right? -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f200.google.com (mail-lb0-f200.google.com [209.85.217.200]) by kanga.kvack.org (Postfix) with ESMTP id B48706B0264 for ; Wed, 1 Jun 2016 10:21:41 -0400 (EDT) Received: by mail-lb0-f200.google.com with SMTP id ne4so10633313lbc.1 for ; Wed, 01 Jun 2016 07:21:41 -0700 (PDT) Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com. [74.125.82.66]) by mx.google.com with ESMTPS id n143si4110839wmd.96.2016.06.01.07.21.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Jun 2016 07:21:40 -0700 (PDT) Received: by mail-wm0-f66.google.com with SMTP id n184so6732231wmn.1 for ; Wed, 01 Jun 2016 07:21:40 -0700 (PDT) Date: Wed, 1 Jun 2016 16:21:38 +0200 From: Michal Hocko Subject: Re: [PATCH v2 18/18] mm, vmscan: use proper classzone_idx in should_continue_reclaim() Message-ID: <20160601142138.GX26601@dhcp22.suse.cz> References: <20160531130818.28724-1-vbabka@suse.cz> <20160531130818.28724-19-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160531130818.28724-19-vbabka@suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Vlastimil Babka Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mel Gorman , Joonsoo Kim , David Rientjes , Rik van Riel On Tue 31-05-16 15:08:18, Vlastimil Babka wrote: [...] > @@ -2364,11 +2350,12 @@ static inline bool should_continue_reclaim(struct zone *zone, > } > > static bool shrink_zone(struct zone *zone, struct scan_control *sc, > - bool is_classzone) > + int classzone_idx) > { > struct reclaim_state *reclaim_state = current->reclaim_state; > unsigned long nr_reclaimed, nr_scanned; > bool reclaimable = false; > + bool is_classzone = (classzone_idx == zone_idx(zone)); > > do { > struct mem_cgroup *root = sc->target_mem_cgroup; > @@ -2450,7 +2437,7 @@ static bool shrink_zone(struct zone *zone, struct scan_control *sc, > reclaimable = true; > > } while (should_continue_reclaim(zone, sc->nr_reclaimed - nr_reclaimed, > - sc->nr_scanned - nr_scanned, sc)); > + sc->nr_scanned - nr_scanned, sc, classzone_idx)); > > return reclaimable; > } > @@ -2580,7 +2567,7 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc) > /* need some check for avoid more shrink_zone() */ > } > > - shrink_zone(zone, sc, zone_idx(zone) == classzone_idx); > + shrink_zone(zone, sc, classzone_idx); this should be is_classzone, right? -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org