From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758681AbcFAPXk (ORCPT ); Wed, 1 Jun 2016 11:23:40 -0400 Received: from mail-yw0-f196.google.com ([209.85.161.196]:34819 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758623AbcFAPXi convert rfc822-to-8bit (ORCPT ); Wed, 1 Jun 2016 11:23:38 -0400 Date: Wed, 1 Jun 2016 12:23:29 -0300 From: Gustavo Padovan To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, daniel@ffwll.ch, chris@chris-wilson.co.uk Subject: Re: [PATCH 01/11] dma-buf/fence: make fence context 64 bit v2 Message-ID: <20160601152329.GE11486@joana> Mail-Followup-To: Gustavo Padovan , Christian =?iso-8859-1?Q?K=F6nig?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, daniel@ffwll.ch, chris@chris-wilson.co.uk References: <1464786612-5010-1-git-send-email-deathsimple@vodafone.de> <1464786612-5010-2-git-send-email-deathsimple@vodafone.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <1464786612-5010-2-git-send-email-deathsimple@vodafone.de> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-06-01 Christian König : > From: Christian König > > Fence contexts are created on the fly (for example) by the GPU scheduler used > in the amdgpu driver as a result of an userspace request. Because of this > userspace could in theory force a wrap around of the 32bit context number > if it doesn't behave well. > > Avoid this by increasing the context number to 64bits. This way even when > userspace manages to allocate a billion contexts per second it takes more > than 500 years for the context number to wrap around. > > v2: fix printf formats as well. > > Signed-off-by: Christian König > --- > drivers/dma-buf/fence.c | 8 ++++---- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c | 2 +- > drivers/gpu/drm/etnaviv/etnaviv_gpu.h | 2 +- > drivers/gpu/drm/nouveau/nouveau_fence.h | 3 ++- > drivers/gpu/drm/qxl/qxl_release.c | 2 +- > drivers/gpu/drm/radeon/radeon.h | 2 +- > drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +- > drivers/staging/android/sync.h | 3 ++- > include/linux/fence.h | 13 +++++++------ > 10 files changed, 21 insertions(+), 18 deletions(-) Reviewed-by: Gustavo Padovan Gustavo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH 01/11] dma-buf/fence: make fence context 64 bit v2 Date: Wed, 1 Jun 2016 12:23:29 -0300 Message-ID: <20160601152329.GE11486@joana> References: <1464786612-5010-1-git-send-email-deathsimple@vodafone.de> <1464786612-5010-2-git-send-email-deathsimple@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yw0-f195.google.com (mail-yw0-f195.google.com [209.85.161.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6B10E891AB for ; Wed, 1 Jun 2016 15:23:33 +0000 (UTC) Received: by mail-yw0-f195.google.com with SMTP id l126so2981757ywe.3 for ; Wed, 01 Jun 2016 08:23:33 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1464786612-5010-2-git-send-email-deathsimple@vodafone.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org MjAxNi0wNi0wMSBDaHJpc3RpYW4gS8O2bmlnIDxkZWF0aHNpbXBsZUB2b2RhZm9uZS5kZT46Cgo+ IEZyb206IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4KPiAKPiBG ZW5jZSBjb250ZXh0cyBhcmUgY3JlYXRlZCBvbiB0aGUgZmx5IChmb3IgZXhhbXBsZSkgYnkgdGhl IEdQVSBzY2hlZHVsZXIgdXNlZAo+IGluIHRoZSBhbWRncHUgZHJpdmVyIGFzIGEgcmVzdWx0IG9m IGFuIHVzZXJzcGFjZSByZXF1ZXN0LiBCZWNhdXNlIG9mIHRoaXMKPiB1c2Vyc3BhY2UgY291bGQg aW4gdGhlb3J5IGZvcmNlIGEgd3JhcCBhcm91bmQgb2YgdGhlIDMyYml0IGNvbnRleHQgbnVtYmVy Cj4gaWYgaXQgZG9lc24ndCBiZWhhdmUgd2VsbC4KPiAKPiBBdm9pZCB0aGlzIGJ5IGluY3JlYXNp bmcgdGhlIGNvbnRleHQgbnVtYmVyIHRvIDY0Yml0cy4gVGhpcyB3YXkgZXZlbiB3aGVuCj4gdXNl cnNwYWNlIG1hbmFnZXMgdG8gYWxsb2NhdGUgYSBiaWxsaW9uIGNvbnRleHRzIHBlciBzZWNvbmQg aXQgdGFrZXMgbW9yZQo+IHRoYW4gNTAwIHllYXJzIGZvciB0aGUgY29udGV4dCBudW1iZXIgdG8g d3JhcCBhcm91bmQuCj4gCj4gdjI6IGZpeCBwcmludGYgZm9ybWF0cyBhcyB3ZWxsLgo+IAo+IFNp Z25lZC1vZmYtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4K PiAtLS0KPiAgZHJpdmVycy9kbWEtYnVmL2ZlbmNlLmMgICAgICAgICAgICAgICAgIHwgIDggKysr Ky0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1LmggICAgIHwgIDIgKy0K PiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3NhLmMgIHwgIDIgKy0KPiAgZHJp dmVycy9ncHUvZHJtL2V0bmF2aXYvZXRuYXZpdl9ncHUuaCAgIHwgIDIgKy0KPiAgZHJpdmVycy9n cHUvZHJtL25vdXZlYXUvbm91dmVhdV9mZW5jZS5oIHwgIDMgKystCj4gIGRyaXZlcnMvZ3B1L2Ry bS9xeGwvcXhsX3JlbGVhc2UuYyAgICAgICB8ICAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS9yYWRl b24vcmFkZW9uLmggICAgICAgICB8ICAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS92bXdnZngvdm13 Z2Z4X2ZlbmNlLmMgICB8ICAyICstCj4gIGRyaXZlcnMvc3RhZ2luZy9hbmRyb2lkL3N5bmMuaCAg ICAgICAgICB8ICAzICsrLQo+ICBpbmNsdWRlL2xpbnV4L2ZlbmNlLmggICAgICAgICAgICAgICAg ICAgfCAxMyArKysrKysrLS0tLS0tCj4gIDEwIGZpbGVzIGNoYW5nZWQsIDIxIGluc2VydGlvbnMo KyksIDE4IGRlbGV0aW9ucygtKQoKUmV2aWV3ZWQtYnk6IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2 by5wYWRvdmFuQGNvbGxhYm9yYS5jby51az4KCglHdXN0YXZvCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=