From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161122AbcFAPZ0 (ORCPT ); Wed, 1 Jun 2016 11:25:26 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:35643 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758657AbcFAPZX convert rfc822-to-8bit (ORCPT ); Wed, 1 Jun 2016 11:25:23 -0400 Date: Wed, 1 Jun 2016 12:25:19 -0300 From: Gustavo Padovan To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, daniel@ffwll.ch, chris@chris-wilson.co.uk Subject: Re: [PATCH 02/11] dma-buf/fence: add fence_array fences v6 Message-ID: <20160601152519.GF11486@joana> Mail-Followup-To: Gustavo Padovan , Christian =?iso-8859-1?Q?K=F6nig?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, daniel@ffwll.ch, chris@chris-wilson.co.uk References: <1464786612-5010-1-git-send-email-deathsimple@vodafone.de> <1464786612-5010-3-git-send-email-deathsimple@vodafone.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <1464786612-5010-3-git-send-email-deathsimple@vodafone.de> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-06-01 Christian König : > From: Gustavo Padovan > > struct fence_collection inherits from struct fence and carries a > collection of fences that needs to be waited together. > > It is useful to translate a sync_file to a fence to remove the complexity > of dealing with sync_files on DRM drivers. So even if there are many > fences in the sync_file that needs to waited for a commit to happen, > they all get added to the fence_collection and passed for DRM use as > a standard struct fence. > > That means that no changes needed to any driver besides supporting fences. > > fence_collection's fence doesn't belong to any timeline context, so > fence_is_later() and fence_later() are not meant to be called with > fence_collections fences. > > v2: Comments by Daniel Vetter: > - merge fence_collection_init() and fence_collection_add() > - only add callbacks at ->enable_signalling() > - remove fence_collection_put() > - check for type on to_fence_collection() > - adjust fence_is_later() and fence_later() to WARN_ON() if they > are used with collection fences. > > v3: - Initialize fence_cb.node at fence init. > > Comments by Chris Wilson: > - return "unbound" on fence_collection_get_timeline_name() > - don't stop adding callbacks if one fails > - remove redundant !! on fence_collection_enable_signaling() > - remove redundant () on fence_collection_signaled > - use fence_default_wait() instead > > v4 (chk): Rework, simplification and cleanup: > - Drop FENCE_NO_CONTEXT handling, always allocate a context. > - Rename to fence_array. > - Return fixed driver name. > - Register only one callback at a time. > - Document that create function takes ownership of array. > > v5 (chk): More work and fixes: > - Avoid deadlocks by adding all callbacks at once again. > - Stop trying to remove the callbacks. > - Provide context and sequence number for the array fence. > > v6 (chk): Fixes found during testing > - Fix stupid typo in _enable_signaling(). > > Signed-off-by: Gustavo Padovan > Signed-off-by: Christian König > --- > drivers/dma-buf/Makefile | 2 +- > drivers/dma-buf/fence-array.c | 127 ++++++++++++++++++++++++++++++++++++++++++ > include/linux/fence-array.h | 72 ++++++++++++++++++++++++ > 3 files changed, 200 insertions(+), 1 deletion(-) > create mode 100644 drivers/dma-buf/fence-array.c > create mode 100644 include/linux/fence-array.h This is working fine to me. Once the commit message is fixed: Reviewed-by: Gustavo Padovan You need to Cc Sumit here to decide who is picking these patches. It would be better to get them through the drm trees so we would need his Ack at least. Gustavo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH 02/11] dma-buf/fence: add fence_array fences v6 Date: Wed, 1 Jun 2016 12:25:19 -0300 Message-ID: <20160601152519.GF11486@joana> References: <1464786612-5010-1-git-send-email-deathsimple@vodafone.de> <1464786612-5010-3-git-send-email-deathsimple@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yw0-f195.google.com (mail-yw0-f195.google.com [209.85.161.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0140F6E9E6 for ; Wed, 1 Jun 2016 15:25:24 +0000 (UTC) Received: by mail-yw0-f195.google.com with SMTP id l126so2989588ywe.3 for ; Wed, 01 Jun 2016 08:25:23 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1464786612-5010-3-git-send-email-deathsimple@vodafone.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org MjAxNi0wNi0wMSBDaHJpc3RpYW4gS8O2bmlnIDxkZWF0aHNpbXBsZUB2b2RhZm9uZS5kZT46Cgo+ IEZyb206IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNvbGxhYm9yYS5jby51az4K PiAKPiBzdHJ1Y3QgZmVuY2VfY29sbGVjdGlvbiBpbmhlcml0cyBmcm9tIHN0cnVjdCBmZW5jZSBh bmQgY2FycmllcyBhCj4gY29sbGVjdGlvbiBvZiBmZW5jZXMgdGhhdCBuZWVkcyB0byBiZSB3YWl0 ZWQgdG9nZXRoZXIuCj4gCj4gSXQgaXMgdXNlZnVsIHRvIHRyYW5zbGF0ZSBhIHN5bmNfZmlsZSB0 byBhIGZlbmNlIHRvIHJlbW92ZSB0aGUgY29tcGxleGl0eQo+IG9mIGRlYWxpbmcgd2l0aCBzeW5j X2ZpbGVzIG9uIERSTSBkcml2ZXJzLiBTbyBldmVuIGlmIHRoZXJlIGFyZSBtYW55Cj4gZmVuY2Vz IGluIHRoZSBzeW5jX2ZpbGUgdGhhdCBuZWVkcyB0byB3YWl0ZWQgZm9yIGEgY29tbWl0IHRvIGhh cHBlbiwKPiB0aGV5IGFsbCBnZXQgYWRkZWQgdG8gdGhlIGZlbmNlX2NvbGxlY3Rpb24gYW5kIHBh c3NlZCBmb3IgRFJNIHVzZSBhcwo+IGEgc3RhbmRhcmQgc3RydWN0IGZlbmNlLgo+IAo+IFRoYXQg bWVhbnMgdGhhdCBubyBjaGFuZ2VzIG5lZWRlZCB0byBhbnkgZHJpdmVyIGJlc2lkZXMgc3VwcG9y dGluZyBmZW5jZXMuCj4gCj4gZmVuY2VfY29sbGVjdGlvbidzIGZlbmNlIGRvZXNuJ3QgYmVsb25n IHRvIGFueSB0aW1lbGluZSBjb250ZXh0LCBzbwo+IGZlbmNlX2lzX2xhdGVyKCkgYW5kIGZlbmNl X2xhdGVyKCkgYXJlIG5vdCBtZWFudCB0byBiZSBjYWxsZWQgd2l0aAo+IGZlbmNlX2NvbGxlY3Rp b25zIGZlbmNlcy4KPiAKPiB2MjogQ29tbWVudHMgYnkgRGFuaWVsIFZldHRlcjoKPiAJLSBtZXJn ZSBmZW5jZV9jb2xsZWN0aW9uX2luaXQoKSBhbmQgZmVuY2VfY29sbGVjdGlvbl9hZGQoKQo+IAkt IG9ubHkgYWRkIGNhbGxiYWNrcyBhdCAtPmVuYWJsZV9zaWduYWxsaW5nKCkKPiAJLSByZW1vdmUg ZmVuY2VfY29sbGVjdGlvbl9wdXQoKQo+IAktIGNoZWNrIGZvciB0eXBlIG9uIHRvX2ZlbmNlX2Nv bGxlY3Rpb24oKQo+IAktIGFkanVzdCBmZW5jZV9pc19sYXRlcigpIGFuZCBmZW5jZV9sYXRlcigp IHRvIFdBUk5fT04oKSBpZiB0aGV5Cj4gCWFyZSB1c2VkIHdpdGggY29sbGVjdGlvbiBmZW5jZXMu Cj4gCj4gdjM6IC0gSW5pdGlhbGl6ZSBmZW5jZV9jYi5ub2RlIGF0IGZlbmNlIGluaXQuCj4gCj4g ICAgIENvbW1lbnRzIGJ5IENocmlzIFdpbHNvbjoKPiAJLSByZXR1cm4gInVuYm91bmQiIG9uIGZl bmNlX2NvbGxlY3Rpb25fZ2V0X3RpbWVsaW5lX25hbWUoKQo+IAktIGRvbid0IHN0b3AgYWRkaW5n IGNhbGxiYWNrcyBpZiBvbmUgZmFpbHMKPiAJLSByZW1vdmUgcmVkdW5kYW50ICEhIG9uIGZlbmNl X2NvbGxlY3Rpb25fZW5hYmxlX3NpZ25hbGluZygpCj4gCS0gcmVtb3ZlIHJlZHVuZGFudCAoKSBv biBmZW5jZV9jb2xsZWN0aW9uX3NpZ25hbGVkCj4gCS0gdXNlIGZlbmNlX2RlZmF1bHRfd2FpdCgp IGluc3RlYWQKPiAKPiB2NCAoY2hrKTogUmV3b3JrLCBzaW1wbGlmaWNhdGlvbiBhbmQgY2xlYW51 cDoKPiAJLSBEcm9wIEZFTkNFX05PX0NPTlRFWFQgaGFuZGxpbmcsIGFsd2F5cyBhbGxvY2F0ZSBh IGNvbnRleHQuCj4gCS0gUmVuYW1lIHRvIGZlbmNlX2FycmF5Lgo+IAktIFJldHVybiBmaXhlZCBk cml2ZXIgbmFtZS4KPiAJLSBSZWdpc3RlciBvbmx5IG9uZSBjYWxsYmFjayBhdCBhIHRpbWUuCj4g CS0gRG9jdW1lbnQgdGhhdCBjcmVhdGUgZnVuY3Rpb24gdGFrZXMgb3duZXJzaGlwIG9mIGFycmF5 Lgo+IAo+IHY1IChjaGspOiBNb3JlIHdvcmsgYW5kIGZpeGVzOgo+IAktIEF2b2lkIGRlYWRsb2Nr cyBieSBhZGRpbmcgYWxsIGNhbGxiYWNrcyBhdCBvbmNlIGFnYWluLgo+IAktIFN0b3AgdHJ5aW5n IHRvIHJlbW92ZSB0aGUgY2FsbGJhY2tzLgo+IAktIFByb3ZpZGUgY29udGV4dCBhbmQgc2VxdWVu Y2UgbnVtYmVyIGZvciB0aGUgYXJyYXkgZmVuY2UuCj4gCj4gdjYgKGNoayk6IEZpeGVzIGZvdW5k IGR1cmluZyB0ZXN0aW5nCj4gCS0gRml4IHN0dXBpZCB0eXBvIGluIF9lbmFibGVfc2lnbmFsaW5n KCkuCj4gCj4gU2lnbmVkLW9mZi1ieTogR3VzdGF2byBQYWRvdmFuIDxndXN0YXZvLnBhZG92YW5A Y29sbGFib3JhLmNvLnVrPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlz dGlhbi5rb2VuaWdAYW1kLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9kbWEtYnVmL01ha2VmaWxlICAg ICAgfCAgIDIgKy0KPiAgZHJpdmVycy9kbWEtYnVmL2ZlbmNlLWFycmF5LmMgfCAxMjcgKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIGluY2x1ZGUvbGludXgvZmVu Y2UtYXJyYXkuaCAgIHwgIDcyICsrKysrKysrKysrKysrKysrKysrKysrKwo+ICAzIGZpbGVzIGNo YW5nZWQsIDIwMCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gIGNyZWF0ZSBtb2RlIDEw MDY0NCBkcml2ZXJzL2RtYS1idWYvZmVuY2UtYXJyYXkuYwo+ICBjcmVhdGUgbW9kZSAxMDA2NDQg aW5jbHVkZS9saW51eC9mZW5jZS1hcnJheS5oCgpUaGlzIGlzIHdvcmtpbmcgZmluZSB0byBtZS4g T25jZSB0aGUgY29tbWl0IG1lc3NhZ2UgaXMgZml4ZWQ6CgpSZXZpZXdlZC1ieTogR3VzdGF2byBQ YWRvdmFuIDxndXN0YXZvLnBhZG92YW5AY29sbGFib3JhLmNvLnVrPgoKWW91IG5lZWQgdG8gQ2Mg U3VtaXQgaGVyZSB0byBkZWNpZGUgd2hvIGlzIHBpY2tpbmcgdGhlc2UgcGF0Y2hlcy4KSXQgd291 bGQgYmUgYmV0dGVyIHRvIGdldCB0aGVtIHRocm91Z2ggdGhlIGRybSB0cmVlcyBzbyB3ZSB3b3Vs ZCBuZWVkCmhpcyBBY2sgYXQgbGVhc3QuCgoJR3VzdGF2bwpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK