From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753031AbcFBJdu (ORCPT ); Thu, 2 Jun 2016 05:33:50 -0400 Received: from merlin.infradead.org ([205.233.59.134]:50699 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752103AbcFBJds (ORCPT ); Thu, 2 Jun 2016 05:33:48 -0400 Date: Thu, 2 Jun 2016 11:33:04 +0200 From: Peter Zijlstra To: Vineet Gupta Cc: "torvalds@linux-foundation.org" , "mingo@kernel.org" , "tglx@linutronix.de" , "will.deacon@arm.com" , "paulmck@linux.vnet.ibm.com" , "boqun.feng@gmail.com" , "waiman.long@hpe.com" , "fweisbec@gmail.com" , "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , "rth@twiddle.net" , "linux@arm.linux.org.uk" , "egtvedt@samfundet.no" , "realmz6@gmail.com" , "ysato@users.sourceforge.jp" , "rkuo@codeaurora.org" , "tony.luck@intel.com" , "geert@linux-m68k.org" , "james.hogan@imgtec.com" , "ralf@linux-mips.org" , "dhowells@redhat.com" , "jejb@parisc-linux.org" , "mpe@ellerman.id.au" , "schwidefsky@de.ibm.com" , "dalias@libc.org" , "davem@davemloft.net" , "cmetcalf@mellanox.com" , "jcmvbkbc@gmail.com" , "arnd@arndb.de" , "dbueso@suse.de" , "fengguang.wu@intel.com" Subject: Re: [PATCH -v2 00/33] implement atomic_fetch_$op Message-ID: <20160602093304.GX3190@twins.programming.kicks-ass.net> References: <20160531101925.702692792@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 02, 2016 at 09:27:36AM +0000, Vineet Gupta wrote: > On Tuesday 31 May 2016 03:59 PM, Peter Zijlstra wrote: > > Notes: > > - arc asm/atomic.h is a bit of a mess after the eznps merge, I would > > recommend a restructure or split of that file, but could not find > > the will to do it. > > - arc, metag and tile could convert to _relaxed. > > Yes that was bothering me too. The split is indeed in order. However good news is > even w/o it I have decent cleanup as all the backoff retry code can now be > removed. The hardware guys did their foo and production RTL with latest h/w > release doesn't suffer from the scond livelock problem. I'd disabled the config > option for some time and now the code can be removed as well. > > What's ur merge plan - are u going to rebase/respin once more so I can push those > updates to Linus for 4.7-rc2. Or you could carry those ARC patches in ur tree - > ahead of ur series. I'd much rather prefer the revert / cleanup before adding new > code which extends the back off code only to be deleted later. I was hoping to get these into tip for v4.8, I can rebase on whatever changes you make in v4.7 no problem. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH -v2 00/33] implement atomic_fetch_$op Date: Thu, 2 Jun 2016 11:33:04 +0200 Message-ID: <20160602093304.GX3190@twins.programming.kicks-ass.net> References: <20160531101925.702692792@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from merlin.infradead.org ([205.233.59.134]:50699 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752103AbcFBJds (ORCPT ); Thu, 2 Jun 2016 05:33:48 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Vineet Gupta Cc: "torvalds@linux-foundation.org" , "mingo@kernel.org" , "tglx@linutronix.de" , "will.deacon@arm.com" , "paulmck@linux.vnet.ibm.com" , "boqun.feng@gmail.com" , "waiman.long@hpe.com" , "fweisbec@gmail.com" , "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , "rth@twiddle.net" , "linux@arm.linux.org.uk" , "egtvedt@samfundet.no" , "realmz6@gmail.com" , "ysato@users.sourceforge.jp" , "rkuo@codeaurora.org" , "tony.luck@intel.com" , "geert@linux-m68k.org" On Thu, Jun 02, 2016 at 09:27:36AM +0000, Vineet Gupta wrote: > On Tuesday 31 May 2016 03:59 PM, Peter Zijlstra wrote: > > Notes: > > - arc asm/atomic.h is a bit of a mess after the eznps merge, I would > > recommend a restructure or split of that file, but could not find > > the will to do it. > > - arc, metag and tile could convert to _relaxed. > > Yes that was bothering me too. The split is indeed in order. However good news is > even w/o it I have decent cleanup as all the backoff retry code can now be > removed. The hardware guys did their foo and production RTL with latest h/w > release doesn't suffer from the scond livelock problem. I'd disabled the config > option for some time and now the code can be removed as well. > > What's ur merge plan - are u going to rebase/respin once more so I can push those > updates to Linus for 4.7-rc2. Or you could carry those ARC patches in ur tree - > ahead of ur series. I'd much rather prefer the revert / cleanup before adding new > code which extends the back off code only to be deleted later. I was hoping to get these into tip for v4.8, I can rebase on whatever changes you make in v4.7 no problem.