From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8QNj-0005IT-Aj for qemu-devel@nongnu.org; Thu, 02 Jun 2016 07:01:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8QNh-000828-Ha for qemu-devel@nongnu.org; Thu, 02 Jun 2016 07:01:42 -0400 Date: Thu, 2 Jun 2016 13:01:32 +0200 From: Kevin Wolf Message-ID: <20160602110132.GC6867@noname.redhat.com> References: <1464815413-613-1-git-send-email-eblake@redhat.com> <1464815413-613-5-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464815413-613-5-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 04/13] block: Switch bdrv_write_zeroes() to byte interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz , Stefan Hajnoczi , Fam Zheng , "Denis V. Lunev" , Juan Quintela , Amit Shah Am 01.06.2016 um 23:10 hat Eric Blake geschrieben: > Rename to bdrv_pwrite_zeroes() to let the compiler ensure we > cater to the updated semantics. Do the same for > bdrv_aio_write_zeroes() and bdrv_co_write_zeroes(). Two of the > three places map to the byte-based counterparts; but for now, > since we have no byte-based aio write, we still require sector > alignment in those callers, via assertions. As it happens, I sent a patch (and you already reviewed it) that removes the AIO function anyway because those callers don't exist. :-) So this patch will conflict with it, but I guess I can resolve that while rebasing. Kevin