From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932866AbcFBVXs (ORCPT ); Thu, 2 Jun 2016 17:23:48 -0400 Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:45238 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932383AbcFBVXq (ORCPT ); Thu, 2 Jun 2016 17:23:46 -0400 Date: Fri, 3 Jun 2016 00:23:39 +0300 From: Sakari Ailus To: Pavel Machek Cc: Ivaylo Dimitrov , pali.rohar@gmail.com, sre@kernel.org, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, patrikbachan@gmail.com, serge@hallyn.com, linux-media@vger.kernel.org, mchehab@osg.samsung.com Subject: Re: [PATCHv5] support for AD5820 camera auto-focus coil Message-ID: <20160602212338.GS26360@valkosipuli.retiisi.org.uk> References: <20160524090433.GA1277@amd> <20160524091746.GA14536@amd> <20160525212659.GK26360@valkosipuli.retiisi.org.uk> <20160527205140.GA26767@amd> <20160531212222.GP26360@valkosipuli.retiisi.org.uk> <20160531213437.GA28397@amd> <20160601152439.GQ26360@valkosipuli.retiisi.org.uk> <20160601220840.GA21946@amd> <20160602074544.GR26360@valkosipuli.retiisi.org.uk> <20160602192737.GA7984@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160602192737.GA7984@amd> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 02, 2016 at 09:27:37PM +0200, Pavel Machek wrote: > On Thu 2016-06-02 10:45:45, Sakari Ailus wrote: > > On Thu, Jun 02, 2016 at 12:08:40AM +0200, Pavel Machek wrote: > > > On Wed 2016-06-01 18:24:39, Sakari Ailus wrote: > > > > Hi Pavel, > > > > > > > > Well, it does not use any dt properties. So there's not really much to > > > > > discuss with dt people... > > > > > > > > > > Maybe "ad5820" needs to go to list of simple i2c drivers somewhere, > > > > > but... > > > > > > > > It's an I2C device and it does use a regulator. Not a lot, though, these are > > > > both quite basic stuff. This should still be documented as the people who > > > > write the DT bindings (in general) aren't expected to read driver code as > > > > well. That's at least my understanding. > > > > > > Yep, you are right, I forgot about the regulator. Something like this? > > > > > > Thanks, > > > Pavel > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/ad5820.txt b/Documentation/devicetree/bindings/media/i2c/ad5820.txt > > > new file mode 100644 > > > index 0000000..87c98f1 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/i2c/ad5820.txt > > > > I might use the compatible string as such as a part of the file name. Up to > > you. > > Sorry, can't do that, for consistency with other ad* files in the directory. > > > > @@ -0,0 +1,20 @@ > > > +* Analog Devices AD5820 autofocus coil > > > + > > > +Required Properties: > > > + > > > + - compatible: Must contain "adi,ad5820" > > > + > > > + - reg: I2C slave address > > > + > > > + - VANA-supply: supply of voltage for VANA pin > > > + > > > +Example: > > > + > > > + /* D/A converter for auto-focus */ > > > > There is definitely D/A conversion happening there but I'm not sure I'd > > characterise the device as such. They're typically called "voice coil > > drivers", perhaps because the devices are similar to a parts of a > > loudspeaker. > > Well, I'm pretty sure I did not invent that comment, but I can drop > it. Both are fine for me. -- Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk From mboxrd@z Thu Jan 1 00:00:00 1970 From: sakari.ailus@iki.fi (Sakari Ailus) Date: Fri, 3 Jun 2016 00:23:39 +0300 Subject: [PATCHv5] support for AD5820 camera auto-focus coil In-Reply-To: <20160602192737.GA7984@amd> References: <20160524090433.GA1277@amd> <20160524091746.GA14536@amd> <20160525212659.GK26360@valkosipuli.retiisi.org.uk> <20160527205140.GA26767@amd> <20160531212222.GP26360@valkosipuli.retiisi.org.uk> <20160531213437.GA28397@amd> <20160601152439.GQ26360@valkosipuli.retiisi.org.uk> <20160601220840.GA21946@amd> <20160602074544.GR26360@valkosipuli.retiisi.org.uk> <20160602192737.GA7984@amd> Message-ID: <20160602212338.GS26360@valkosipuli.retiisi.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jun 02, 2016 at 09:27:37PM +0200, Pavel Machek wrote: > On Thu 2016-06-02 10:45:45, Sakari Ailus wrote: > > On Thu, Jun 02, 2016 at 12:08:40AM +0200, Pavel Machek wrote: > > > On Wed 2016-06-01 18:24:39, Sakari Ailus wrote: > > > > Hi Pavel, > > > > > > > > Well, it does not use any dt properties. So there's not really much to > > > > > discuss with dt people... > > > > > > > > > > Maybe "ad5820" needs to go to list of simple i2c drivers somewhere, > > > > > but... > > > > > > > > It's an I2C device and it does use a regulator. Not a lot, though, these are > > > > both quite basic stuff. This should still be documented as the people who > > > > write the DT bindings (in general) aren't expected to read driver code as > > > > well. That's at least my understanding. > > > > > > Yep, you are right, I forgot about the regulator. Something like this? > > > > > > Thanks, > > > Pavel > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/ad5820.txt b/Documentation/devicetree/bindings/media/i2c/ad5820.txt > > > new file mode 100644 > > > index 0000000..87c98f1 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/i2c/ad5820.txt > > > > I might use the compatible string as such as a part of the file name. Up to > > you. > > Sorry, can't do that, for consistency with other ad* files in the directory. > > > > @@ -0,0 +1,20 @@ > > > +* Analog Devices AD5820 autofocus coil > > > + > > > +Required Properties: > > > + > > > + - compatible: Must contain "adi,ad5820" > > > + > > > + - reg: I2C slave address > > > + > > > + - VANA-supply: supply of voltage for VANA pin > > > + > > > +Example: > > > + > > > + /* D/A converter for auto-focus */ > > > > There is definitely D/A conversion happening there but I'm not sure I'd > > characterise the device as such. They're typically called "voice coil > > drivers", perhaps because the devices are similar to a parts of a > > loudspeaker. > > Well, I'm pretty sure I did not invent that comment, but I can drop > it. Both are fine for me. -- Sakari Ailus e-mail: sakari.ailus at iki.fi XMPP: sailus at retiisi.org.uk